Skip to contentSkip to conversation

googletest: move to release 1.10.0

PATCH Superseded Lei YU 4 participants 5 messages Nov 21, 2019 – Nov 29, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lei YU

author
#0 lore raw

PATCH 1/1 googletest: move to release 1.10.0

The googletest recipe was using 1.8.1 tag, and in the recipe it was using the git revision instead of the tag release.

Rename it to googletest_git.bb and use the 1.10.0 release revision to get the latest release.

---
 meta-oe/recipes-test/googletest/googletest_1.8.1.bb | 21 ---------------------
 meta-oe/recipes-test/googletest/googletest_git.bb   | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 21 deletions(-)
 delete mode 100644 meta-oe/recipes-test/googletest/googletest_1.8.1.bb
 create mode 100644 meta-oe/recipes-test/googletest/googletest_git.bb
meta-oe/recipes-test/googletest/googletest_1.8.1.bb deleted +0 -21
deleted file mode 100644
index 362d69f..0000000
@@ -1,21 +0,0 @@
-DESCRIPTION = "Google's framework for writing C++ tests"
-HOMEPAGE = "https://github.com/google/googletest"
-SECTION = "libs"
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
-                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
-
-PROVIDES += "gmock gtest"
-
-S = "${WORKDIR}/git"
-SRCREV = "2fe3bd994b3189899d93f1d5a881e725e046fdc2"
-SRC_URI = "git://github.com/google/googletest.git"
-
-inherit cmake
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-dbg = "1"
-
-RDEPENDS_${PN}-dev += "${PN}-staticdev"
-
-BBCLASSEXTEND = "native nativesdk"
meta-oe/recipes-test/googletest/googletest_git.bb new file +21 -0
new file mode 100644
index 0000000..e1df9b6
@@ -0,0 +1,21 @@
+DESCRIPTION = "Google's framework for writing C++ tests"
+HOMEPAGE = "https://github.com/google/googletest"
+SECTION = "libs"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
+                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
+
+PROVIDES += "gmock gtest"
+
+S = "${WORKDIR}/git"
+SRCREV = "703bd9caab50b139428cea1aaff9974ebee5742e"
+SRC_URI = "git://github.com/google/googletest.git"
+
+inherit cmake
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-dbg = "1"
+
+RDEPENDS_${PN}-dev += "${PN}-staticdev"
+
+BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Lei YU

The googletest recipe was using 1.8.1 tag, and in the recipe it was using the git revision instead of the tag release.

Rename it to googletest_git.bb and use the 1.10.0 release revision to get the latest release.
...

When removing the version from the recipe name you have to set PV manually.

Quoted 14 lines
meta-oe/recipes-test/googletest/googletest_git.bb new file +11 -0
@@ -0,0 +1,21 @@
+DESCRIPTION = "Google's framework for writing C++ tests"
+HOMEPAGE = "https://github.com/google/googletest"
+SECTION = "libs"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://googlemock/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a \
+                    file://googletest/LICENSE;md5=cbbd27594afd089daa160d3a16dd515a"
+
+PROVIDES += "gmock gtest"
+
+S = "${WORKDIR}/git"
+SRCREV = "703bd9caab50b139428cea1aaff9974ebee5742e"

meta-oe/recipes-test/googletest/googletest_git.bb line 21

Quoted 10 lines
meta-oe/recipes-test/googletest/googletest_git.bb new file +10 -0
+SRC_URI = "git://github.com/google/googletest.git"
+
+inherit cmake
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-dbg = "1"
+
+RDEPENDS_${PN}-dev += "${PN}-staticdev"
+
+BBCLASSEXTEND = "native nativesdk"

cu
Adrian

author
#2 lore raw
Quoted 10 lines · Adrian Bunk
Quoted 6 lines · Lei YU

The googletest recipe was using 1.8.1 tag, and in the recipe it was using the git revision instead of the tag release.

Rename it to googletest_git.bb and use the 1.10.0 release revision to get the latest release.
...

When removing the version from the recipe name you have to set PV manually.

Fixed and sent v2 patch.
Thanks.

#3 lore raw
Quoted 7 lines · Lei YU
Quoted 5 lines · Adrian Bunk
Quoted 3 lines · Lei YU

The googletest recipe was using 1.8.1 tag, and in the recipe it was using the git revision instead of the tag release.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Rename it to googletest_git.bb and use the 1.10.0 release revision to get the latest release.
...

When removing the version from the recipe name you have to set PV manually.

Fixed and sent v2 patch.

Thanks, I have rebased this one on top of v1, as v1 was already merged.

Quoted 6 lines

Thanks.
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 22 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Khem Raj
Sent: den 25 november 2019 06:03
To: Lei YU <[email protected]>
Cc: openembeded-devel <[email protected]>; Adrian Bunk <[email protected]>
Subject: Re: [oe] [meta-oe][PATCH] googletest: move to release 1.10.0

Quoted 8 lines · Lei YU
Quoted 6 lines · Adrian Bunk
Quoted 4 lines · Lei YU

The googletest recipe was using 1.8.1 tag, and in the recipe it was using the git revision instead of the tag release.

Rename it to googletest_git.bb and use the 1.10.0 release revision

to

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

get the latest release.
...

Quoted 8 lines
Quoted 1 line
Quoted 1 line

When removing the version from the recipe name you have to set PV

manually.

Quoted 2 lines

Fixed and sent v2 patch.

Thanks, I have rebased this one on top of v1, as v1 was already merged.

Quoted 1 line

Thanks.

Please move the version back to the file name rather than setting PV. Since the SRCREV matches the 1.10.0 tag there is no reason to set PV in the recipe instead of having it in the file name.

Not having the version in the file name prevents having versioned bbappend files.

//Peter