Skip to contentSkip to conversation

media: i2c: lt6911uxe: Fix Kconfig dependencies:

PATCH In review Arnd Bergmann 4 participants 6 messages Mar 14, 2025 – Apr 30, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: lt6911uxe: Fix Kconfig dependencies:

From: Arnd Bergmann <[email protected]>

The new driver fails to build if I2C is disabled:

drivers/media/i2c/lt6911uxe.c:703:1: error: data definition has no type or storage class [-Werror]
703 | module_i2c_driver(lt6911uxe_i2c_driver);

or if I2C is on but V4L2_CCI_I2C is not:

ERROR: modpost: "cci_write" [drivers/media/i2c/lt6911uxe.ko] undefined!
ERROR: modpost: "cci_read" [drivers/media/i2c/lt6911uxe.ko] undefined!

For both by adding a dependency on I2C and selecting V4L2_CCI_I2C, which follows the common practice for these.

Fixes e49563c3be09 ("media: i2c: add lt6911uxe hdmi bridge driver")
---
 drivers/media/i2c/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/Kconfig +2 -1
index e576b213084d..b06365d02ef1 100644
@@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
 
 config VIDEO_LT6911UXE
 	tristate "Lontium LT6911UXE decoder"
-	depends on ACPI && VIDEO_DEV
+	depends on ACPI && VIDEO_DEV && I2C
 	select V4L2_FWNODE
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor-level driver for the Lontium
 	  LT6911UXE HDMI to MIPI CSI-2 bridge.
Signature · 1 line
2.39.5
#1 lore raw

Hi Arnd,

Quoted 26 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The new driver fails to build if I2C is disabled:

drivers/media/i2c/lt6911uxe.c:703:1: error: data definition has no type or storage class [-Werror]
703 | module_i2c_driver(lt6911uxe_i2c_driver);

or if I2C is on but V4L2_CCI_I2C is not:

ERROR: modpost: "cci_write" [drivers/media/i2c/lt6911uxe.ko] undefined!
ERROR: modpost: "cci_read" [drivers/media/i2c/lt6911uxe.ko] undefined!

For both by adding a dependency on I2C and selecting V4L2_CCI_I2C, which follows the common practice for these.

Fixes e49563c3be09 ("media: i2c: add lt6911uxe hdmi bridge driver")
---
 drivers/media/i2c/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/Kconfig +0 -0
index e576b213084d..b06365d02ef1 100644

drivers/media/i2c/Kconfig config VIDEO_ISL7998X · line 1157

Quoted 10 lines
drivers/media/i2c/Kconfig +2 -1
@@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
 
 config VIDEO_LT6911UXE
 	tristate "Lontium LT6911UXE decoder"
-	depends on ACPI && VIDEO_DEV
+	depends on ACPI && VIDEO_DEV && I2C
 	select V4L2_FWNODE
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor-level driver for the Lontium
 	  LT6911UXE HDMI to MIPI CSI-2 bridge.

Thanks for your fix.

Lkp is a bit weird to me, because it tested a warning in patch v6 likes below:

kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
when selected by VIDEO_LT6911UXE

So I remove this select flag and passed lkp build test in patch v7. But now it encounters build error again, I'm curious why...

Thanks,
Dongcheng

#2 lore raw
Quoted 17 lines · Dongcheng

drivers/media/i2c/Kconfig config VIDEO_ISL7998X · line 1157

Quoted 13 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

drivers/media/i2c/Kconfig +2 -1
@@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
 
 config VIDEO_LT6911UXE
 	tristate "Lontium LT6911UXE decoder"
-	depends on ACPI && VIDEO_DEV
+	depends on ACPI && VIDEO_DEV && I2C
 	select V4L2_FWNODE
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor-level driver for the Lontium
 	  LT6911UXE HDMI to MIPI CSI-2 bridge.

Thanks for your fix.

Quoted 5 lines

Lkp is a bit weird to me, because it tested a warning in patch v6 likes below:

kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
when selected by VIDEO_LT6911UXE

What was the full warning? The only dependency I see in V4L2_CCI_I2C is CONFIG_I2C itself, and that is what I add above.

Quoted 2 lines

So I remove this select flag and passed lkp build test in patch v7. But now it encounters build error again, I'm curious why...

I don't currently get any more build errors with my patch added in, and I think this should be sufficient. Can you forward me the errors and config you get with my patch?

Arnd

#3 lore raw

Hi all,

Quoted 27 lines · Arnd Bergmann
Quoted 17 lines · Dongcheng

drivers/media/i2c/Kconfig config VIDEO_ISL7998X · line 1157

Quoted 13 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

drivers/media/i2c/Kconfig +2 -1
@@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
 
 config VIDEO_LT6911UXE
 	tristate "Lontium LT6911UXE decoder"
-	depends on ACPI && VIDEO_DEV
+	depends on ACPI && VIDEO_DEV && I2C
 	select V4L2_FWNODE
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor-level driver for the Lontium
 	  LT6911UXE HDMI to MIPI CSI-2 bridge.

Thanks for your fix.

Quoted 5 lines

Lkp is a bit weird to me, because it tested a warning in patch v6 likes below:

kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
when selected by VIDEO_LT6911UXE

What was the full warning? The only dependency I see in V4L2_CCI_I2C is CONFIG_I2C itself, and that is what I add above.

Quoted 6 lines
Quoted 2 lines

So I remove this select flag and passed lkp build test in patch v7. But now it encounters build error again, I'm curious why...

I don't currently get any more build errors with my patch added in, and I think this should be sufficient. Can you forward me the errors and config you get with my patch?

FYI: I plan to take Arnd's patch tomorrow to be in time for the merge window.

If more issues are found, then they can be on top later.

Regards,

Hans

Quoted 3 lines

Arnd

#4 lore raw
Quoted 6 lines · Hans Verkuil
Quoted 5 lines · Arnd Bergmann
Quoted 2 lines · Dongcheng

So I remove this select flag and passed lkp build test in patch v7. But now it encounters build error again, I'm curious why...

Quoted 7 lines
Quoted 3 lines

I don't currently get any more build errors with my patch added in, and I think this should be sufficient. Can you forward me the errors and config you get with my patch?

FYI: I plan to take Arnd's patch tomorrow to be in time for the merge window.

If more issues are found, then they can be on top later.

Not sure what happened: I see that my patch was in next-20250424 and earlier but is now missing again, so the link failure returned.

It was in git://linuxtv.org/media-ci/media-pending.git at the time along with two more patches that are now also missing:

d51adf038ebe media: cec: tda9950: add back i2c dependency
118b34092e37 media: i2c: lt6911uxe: add two selects to Kconfig
0dce5b44bd38 media: platform: synopsys: VIDEO_SYNOPSYS_HDMIRX should depend on ARCH_ROCKCHIP

Arnd

#5 lore raw
Quoted 18 lines · Arnd Bergmann
Quoted 6 lines · Hans Verkuil
Quoted 5 lines · Arnd Bergmann
Quoted 2 lines · Dongcheng

So I remove this select flag and passed lkp build test in patch v7. But now it encounters build error again, I'm curious why...

Quoted 7 lines
Quoted 3 lines

I don't currently get any more build errors with my patch added in, and I think this should be sufficient. Can you forward me the errors and config you get with my patch?

FYI: I plan to take Arnd's patch tomorrow to be in time for the merge window.

If more issues are found, then they can be on top later.

Not sure what happened: I see that my patch was in next-20250424 and earlier but is now missing again, so the link failure returned.

Quoted 8 lines

It was in git://linuxtv.org/media-ci/media-pending.git at the time along with two more patches that are now also missing:

d51adf038ebe media: cec: tda9950: add back i2c dependency
118b34092e37 media: i2c: lt6911uxe: add two selects to Kconfig
0dce5b44bd38 media: platform: synopsys: VIDEO_SYNOPSYS_HDMIRX should depend on ARCH_ROCKCHIP

Arnd

I believe Mauro is working on preparing a PR for 6.15 with these patches. They are here:

https://git.linuxtv.org/media-ci/media-pending.git/log/?h=fixes

Regards,

Hans