selftests: tcp_ao: set the timeout to 2 minutes
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 selftests: tcp_ao: set the timeout to 2 minutes
The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
---
Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...
--- tools/testing/selftests/net/tcp_ao/settings | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/net/tcp_ao/settings
tools/testing/selftests/net/tcp_ao/settings new file +1 -0
@@ -0,0 +1 @@ +timeout=120
Signature · 1 line
2.43.0
Quoted 7 lines · Jakub Kicinski
The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
Fixes d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")Signed-off-by Jakub Kicinski <[email protected]>
Thanks!
Quoted 4 lines
---
Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...
I'll fix and send a patch for rst selftests on Thursday/Friday :)
Quoted 14 lines
--- tools/testing/selftests/net/tcp_ao/settings | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/net/tcp_ao/settingstools/testing/selftests/net/tcp_ao/settings new file +0
-0
tools/testing/selftests/net/tcp_ao/settings line 1
Quoted 1 line
tools/testing/selftests/net/tcp_ao/settings new file +1
-0@@ -0,0 +1 @@ +timeout=120
Thanks,
Dmitry
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 24 Jan 2024 15:36:30 -0800 you wrote:
The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.
Fixes d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")Signed-off-by Jakub Kicinski <[email protected]>[...]
Here is the summary with links:
- [net] selftests: tcp_ao: set the timeout to 2 minutes
https://git.kernel.org/netdev/net/c/39b383d77961
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html