Skip to contentSkip to conversation

selftests: tcp_ao: set the timeout to 2 minutes

PATCH Applied Jakub Kicinski 3 participants 3 messages Jan 24, 2024 – Jan 26, 2024

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: tcp_ao: set the timeout to 2 minutes

The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.

Fixes d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")

---
Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...

---
 tools/testing/selftests/net/tcp_ao/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/net/tcp_ao/settings
tools/testing/selftests/net/tcp_ao/settings new file +1 -0
new file mode 100644
index 000000000000..6091b45d226b
@@ -0,0 +1 @@
+timeout=120
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jakub Kicinski

The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.

Fixes d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")

Thanks!

Quoted 4 lines

---
Long story short I looked at the output for bench-lookups_ipv6 and it seems to be a trivial timeout problem. With this we're at 22/24 passing for TCP AO, the reset case failures aren't as obvious...

I'll fix and send a patch for rst selftests on Thursday/Friday :)

Quoted 14 lines
---
 tools/testing/selftests/net/tcp_ao/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/net/tcp_ao/settings
tools/testing/selftests/net/tcp_ao/settings new file +0 -0
new file mode 100644
index 000000000000..6091b45d226b

tools/testing/selftests/net/tcp_ao/settings line 1

Quoted 1 line
tools/testing/selftests/net/tcp_ao/settings new file +1 -0
@@ -0,0 +1 @@
+timeout=120

Thanks,
Dmitry

#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Wed, 24 Jan 2024 15:36:30 -0800 you wrote:

The default timeout for tests is 45sec, bench-lookups_ipv6 seems to take around 50sec when running in a VM without HW acceleration. Give it a 2x margin and set the timeout to 120sec.

Fixes d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")

[...]

Here is the summary with links:
- [net] selftests: tcp_ao: set the timeout to 2 minutes

    https://git.kernel.org/netdev/net/c/39b383d77961

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html