Skip to contentSkip to conversation

fbcon: mark fbcon_registered_fb static

PATCH Applied Min-Hua Chen 2 participants 3 messages Aug 4, 2023 – Aug 15, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fbcon: mark fbcon_registered_fb static

Mark fbcon_registered_fb, and fbcon_num_registered_fb static to fix the following sparse warnings:

drivers/video/fbdev/core/fbcon.c:105:16: sparse: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? drivers/video/fbdev/core/fbcon.c:106:5: sparse: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?

No functional change intended.

---

change since v1:
1. registered_fb and num_registered_fb are still used in drivers/staging/olpc_dcon, so do keep them as-is.
2. change the subject to fbcon: mark fbcon_registered_fb static

---
 drivers/video/fbdev/core/fbcon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/core/fbcon.c +2 -2
index 887fad44e7ec..976900d6893c 100644
@@ -102,8 +102,8 @@ enum {
 
 static struct fbcon_display fb_display[MAX_NR_CONSOLES];
 
-struct fb_info *fbcon_registered_fb[FB_MAX];
-int fbcon_num_registered_fb;
+static struct fb_info *fbcon_registered_fb[FB_MAX];
+static int fbcon_num_registered_fb;
 
 #define fbcon_for_each_registered_fb(i)		\
 	for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)		\
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 10 lines · Min-Hua Chen

Mark fbcon_registered_fb, and fbcon_num_registered_fb static to fix the following sparse warnings:

drivers/video/fbdev/core/fbcon.c:105:16: sparse: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? drivers/video/fbdev/core/fbcon.c:106:5: sparse: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?

No functional change intended.

applied to the for-next-6.6 branch.

Thanks,
Helge

Quoted 26 lines

---

change since v1:
1. registered_fb and num_registered_fb are still used in drivers/staging/olpc_dcon, so do keep them as-is.
2. change the subject to fbcon: mark fbcon_registered_fb static

---
  drivers/video/fbdev/core/fbcon.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/core/fbcon.c +2 -2
index 887fad44e7ec..976900d6893c 100644
@@ -102,8 +102,8 @@ enum {
 
  static struct fbcon_display fb_display[MAX_NR_CONSOLES];
 
-struct fb_info *fbcon_registered_fb[FB_MAX];
-int fbcon_num_registered_fb;
+static struct fb_info *fbcon_registered_fb[FB_MAX];
+static int fbcon_num_registered_fb;
 
  #define fbcon_for_each_registered_fb(i)		\
  	for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)		\
maintainer
#2 lore raw
Quoted 7 lines · Helge Deller
Quoted 6 lines · Min-Hua Chen

Mark fbcon_registered_fb, and fbcon_num_registered_fb static to fix the following sparse warnings:

drivers/video/fbdev/core/fbcon.c:105:16: sparse: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? drivers/video/fbdev/core/fbcon.c:106:5: sparse: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?

Quoted 6 lines
Quoted 4 lines

No functional change intended.

applied to the for-next-6.6 branch.

Just dropped it again, since it was already applied by Daniel to the drm-misc tree ...

Helge

Quoted 32 lines

Thanks,
Helge

Quoted 26 lines

---

change since v1:
1. registered_fb and num_registered_fb are still used in drivers/staging/olpc_dcon, so do keep them as-is.
2. change the subject to fbcon: mark fbcon_registered_fb static
---
  drivers/video/fbdev/core/fbcon.c | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/core/fbcon.c +2 -2
index 887fad44e7ec..976900d6893c 100644
@@ -102,8 +102,8 @@ enum {
 
   static struct fbcon_display fb_display[MAX_NR_CONSOLES];
 
-struct fb_info *fbcon_registered_fb[FB_MAX];
-int fbcon_num_registered_fb;
+static struct fb_info *fbcon_registered_fb[FB_MAX];
+static int fbcon_num_registered_fb;
 
   #define fbcon_for_each_registered_fb(i)        \
       for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)        \