Skip to contentSkip to conversation

staging: rtl8192e: replace kmalloc/memset with kzalloc

PATCH Superseded Elena Afanasova 2 participants 2 messages Oct 23, 2020 – Oct 25, 2020 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8192e: replace kmalloc/memset with kzalloc

Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too. Found with Coccinelle.

---
Changes in v2:
- correct the subject line
- correct the commit message

 drivers/staging/rtl8192e/rtllib_tx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8192e/rtllib_tx.c +1 -3
index e0d79daca24a..c9959bb4ab63 100644
@@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,
 	struct rtllib_txb *txb;
 	int i;
 
-	txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
-		      gfp_mask);
+	txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
 	if (!txb)
 		return NULL;
 
-	memset(txb, 0, sizeof(struct rtllib_txb));
 	txb->nr_frags = nr_frags;
 	txb->frag_size = cpu_to_le16(txb_size);
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 17 lines · Elena Afanasova

Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too. Found with Coccinelle.

---
Changes in v2:
- correct the subject line
- correct the commit message

 drivers/staging/rtl8192e/rtllib_tx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8192e/rtllib_tx.c +0 -0
index e0d79daca24a..c9959bb4ab63 100644

drivers/staging/rtl8192e/rtllib_tx.c static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size, · line 208

Quoted 6 lines
drivers/staging/rtl8192e/rtllib_tx.c +1 -2
@@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,
 	struct rtllib_txb *txb;
 	int i;
 
-	txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
-		      gfp_mask);
+	txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);

Same here, please always use array_size()