Skip to contentSkip to conversation

btrfs/010: what's the purpose of test case

DISCUSSION Xu Wang 2 participants 2 messages Nov 3, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Xu Wang

author
#1 lore raw

Hi,

I run the btrfs/010 for kernel 3.10, the result is failed. When I read the case, I think it may be wrong. So I post this letter, and wanna to verify it.

The case(btrfs/010) firstly produced a file with some extents in a sub volume, then created 2 snaps of the sub volume. Then defrag the file in sub volume, and hope the extents numbers are same for sub volume, snap1 and snap2.
The btrfs's snapshot is based on cow, so defrag the original sub volume's file will not affect the file in snapshot? Am I right?
If I am right, the operation "num_extent_orig=_extent_count $subvol/foobar" in btrfs/010 should be before the defrag operation. And I will send a patch to fix it.

Best regards,

Signature · 8 lines
George Wang 王旭

Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom
#2 lore raw
Quoted 5 lines · Xu Wang

Hi,

I run the btrfs/010 for kernel 3.10, the result is failed. When I read the case, I think it may be wrong. So I post this letter, and wanna to verify it.

Quoted 7 lines

The case(btrfs/010) firstly produced a file with some extents in a sub volume, then created 2 snaps of the sub volume. Then defrag the file in sub volume, and hope the extents numbers are same for sub volume, snap1 and snap2.
The btrfs's snapshot is based on cow, so defrag the original sub volume's file will not affect the file in snapshot? Am I right?
If I am right, the operation "num_extent_orig=_extent_count $subvol/foobar" in btrfs/010 should be before the defrag operation. And I will send a patch to fix it.

The test fails because snapshot aware defrag was disabled in the kernel sometime ago due to some issues with that feature. The change that disabled it was backported to 3.10:

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=a082f872743e09fe2cdf870b2d8f1b5dccd36cf7

The test is correct and works without that patch.

Quoted 17 lines

Best regards,

--
George Wang 王旭

Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom

--
To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 5 lines
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."