Skip to contentSkip to conversation

Request for reviews for 4.4-st61, 4.4-cip96

DISCUSSION Ulrich Hecht 3 participants 3 messages Feb 11, 2025 – Feb 12, 2025

lore
Share & tools
lore
#0 lore raw

Hi!

Here's the manual backports for the next 4.4 kernel release. They can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc

Seems like all manual backports to 4.19 applied cleanly, so there is nothing to re-review.

65a3da457f648 phy: core: Fix an OF node refcount leakage in of_phy_provider_lookup() fbb00ee18cfb9 batman-adv: Remove uninitialized data in full table TT response b317a37e42dbc leds: class: Protect brightness_show() with led_cdev->led_access mutex 20e3dfc5e6312 net: inet: do not leave a dangling sk pointer in inet_create() 9f3769378767d af_packet: avoid erroring out after sock_init_data() in packet_create() dc4d74d36b1bc nilfs2: fix potential out-of-bounds memory access in nilfs_find_entry() e2f28a0cb0a81 netfilter: x_tables: fix LED ID check in led_tg_check()

Thanks for having a look.

CU
Uli

#1 lore raw

Hi!

Quoted 4 lines

Here's the manual backports for the next 4.4 kernel release. They can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc

Seems like all manual backports to 4.19 applied cleanly, so there is nothing to re-review.

a 65a3da457f648 phy: core: Fix an OF node refcount leakage in of_phy_provider_lookup() a fbb00ee18cfb9 batman-adv: Remove uninitialized data in full table TT response a b317a37e42dbc leds: class: Protect brightness_show() with led_cdev->led_access mutex a 20e3dfc5e6312 net: inet: do not leave a dangling sk pointer in inet_create() a 9f3769378767d af_packet: avoid erroring out after sock_init_data() in packet_create() a dc4d74d36b1bc nilfs2: fix potential out-of-bounds memory access in nilfs_find_entry()

These look good to me.

Quoted 1 line

e2f28a0cb0a81 netfilter: x_tables: fix LED ID check in led_tg_check()

It is strange to use memchr for this, and memchr second argument is integer. But if the patch was good enough for mainline, I think we can live with it.

Best regards,
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw
In reply to Ulrich Hecht

Hi Uli,

Thanks for update 4.4.y-st.

Quoted 28 lines

-----Original Message-----
From: Ulrich Hecht <[email protected]>
Sent: Tuesday, February 11, 2025 11:14 AM
To: [email protected]; [email protected]; iwamatsu nobuhiro(岩松 信 洋 ○DITC□DIT○OST) <[email protected]>
Subject: Request for reviews for 4.4-st61, 4.4-cip96

Hi!

Here's the manual backports for the next 4.4 kernel release. They can be found in
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linu
x-4.4.y-st-rc

Seems like all manual backports to 4.19 applied cleanly, so there is nothing to re-review.

65a3da457f648 phy: core: Fix an OF node refcount leakage in of_phy_provider_lookup()
fbb00ee18cfb9 batman-adv: Remove uninitialized data in full table TT response b317a37e42dbc leds: class: Protect brightness_show() with led_cdev->led_access mutex
20e3dfc5e6312 net: inet: do not leave a dangling sk pointer in inet_create() 9f3769378767d af_packet: avoid erroring out after sock_init_data() in packet_create() dc4d74d36b1bc nilfs2: fix potential out-of-bounds memory access in nilfs_find_entry()
e2f28a0cb0a81 netfilter: x_tables: fix LED ID check in led_tg_check()

Quoted 2 lines

Thanks for having a look.

I reviewed these, I don't see anything wrong with these patches.

Best regards,
Nobuhiro