Skip to contentSkip to conversation

pinctrl: tegra: Use noirq suspend/resume callbacks

PATCH In review Vidya Sagar 3 participants 3 messages Jun 4, 2020 – Jun 10, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: tegra: Use noirq suspend/resume callbacks

Use noirq suspend/resume callbacks as other drivers which implement noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to configure the signals used by their respective devices in the noirq phase.

---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/tegra/pinctrl-tegra.c +2 -2
index 21661f6490d6..195cfe557511 100644
@@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
 }
 
 const struct dev_pm_ops tegra_pinctrl_pm = {
-	.suspend = &tegra_pinctrl_suspend,
-	.resume = &tegra_pinctrl_resume
+	.suspend_noirq = &tegra_pinctrl_suspend,
+	.resume_noirq = &tegra_pinctrl_resume
 };
 
 static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

04.06.2020 20:49, Vidya Sagar пишет:

Quoted 15 lines

Use noirq suspend/resume callbacks as other drivers which implement noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to configure the signals used by their respective devices in the noirq phase.

---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/tegra/pinctrl-tegra.c +0 -0
index 21661f6490d6..195cfe557511 100644

drivers/pinctrl/tegra/pinctrl-tegra.c static int tegra_pinctrl_resume(struct device *dev) · line 738

Quoted 10 lines
drivers/pinctrl/tegra/pinctrl-tegra.c +2 -2
@@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
 }
 
 const struct dev_pm_ops tegra_pinctrl_pm = {
-	.suspend = &tegra_pinctrl_suspend,
-	.resume = &tegra_pinctrl_resume
+	.suspend_noirq = &tegra_pinctrl_suspend,
+	.resume_noirq = &tegra_pinctrl_resume
 };
 
 static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)

That's a good catch! Perhaps I2C on later Tegra SoCs also should suffer similarly to the PCIe.

#2 lore raw
In reply to Vidya Sagar
Quoted 5 lines · Vidya Sagar

Use noirq suspend/resume callbacks as other drivers which implement noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to configure the signals used by their respective devices in the noirq phase.

Patch applied for fixes.

Yours,
Linus Walleij