Skip to contentSkip to conversation

tools/misc: Remove obsolete xen-bugtool

PATCH In review Hans van Kranenburg 3 participants 3 messages Feb 3, 2019 – Feb 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/misc: Remove obsolete xen-bugtool

xen-bugtool relies on code that has been removed in commit 9e8672f1c3 "tools: remove xend and associated python modules", more than 5 years ago. Remove it, since it confuses users.

-$ /usr/sbin/xen-bugtool
Traceback (most recent call last):
File "/usr/sbin/xen-bugtool", line 9, in <module>
from xen.util import bugtool
ImportError: No module named xen.util

---
 docs/README.xen-bugtool | 16 ----------------
 tools/misc/Makefile     |  2 --
 tools/misc/xen-bugtool  | 17 -----------------
 3 files changed, 35 deletions(-)
 delete mode 100644 docs/README.xen-bugtool
 delete mode 100644 tools/misc/xen-bugtool
docs/README.xen-bugtool deleted +0 -16
deleted file mode 100644
index a7e95ef4ce..0000000000
@@ -1,16 +0,0 @@
-xen-bugtool
-===========
-
-The xen-bugtool command line application will collate the Xen dmesg output,
-details of the hardware configuration of your machine, information about the
-build of Xen that you are using, plus, if you allow it, various logs.
-
-The information collated can either be posted to a Xen Bugzilla bug (this bug
-must already exist in the system, and you must be a registered user there), or
-it can be saved as a .tar.bz2 for sending or archiving.
-
-The collated logs may contain private information, and if you are at all
-worried about that, you should not use this tool, or you should explicitly
-exclude those logs from the archive.
-
-xen-bugtool is wholly interactive, so simply run it, and answer the questions.
tools/misc/Makefile +0 -2
index eaa28793ef..fd91202950 100644
@@ -17,7 +17,6 @@ INSTALL_BIN                    += xencov_split
 INSTALL_BIN += $(INSTALL_BIN-y)
 
 # Everything to be installed in regular sbin/
-INSTALL_SBIN                   += xen-bugtool
 INSTALL_SBIN-$(CONFIG_MIGRATE) += xen-hptool
 INSTALL_SBIN-$(CONFIG_X86)     += xen-hvmcrash
 INSTALL_SBIN-$(CONFIG_X86)     += xen-hvmctx
@@ -41,7 +40,6 @@ INSTALL_PRIVBIN                += xenpvnetboot
 TARGETS_ALL := $(INSTALL_BIN) $(INSTALL_SBIN) $(INSTALL_PRIVBIN)
 
 # Everything which only needs copying to install
-TARGETS_COPY += xen-bugtool
 TARGETS_COPY += xen-ringwatch
 TARGETS_COPY += xencons
 TARGETS_COPY += xencov_split
tools/misc/xen-bugtool deleted +0 -17
deleted file mode 100644
index a3742b4787..0000000000
@@ -1,17 +0,0 @@
-#!/usr/bin/env python
-
-#  -*- mode: python; -*-
-
-# Copyright (c) 2005, XenSource Ltd.
-
-import sys
-
-from xen.util import bugtool
-
-
-if __name__ == "__main__":
-    try:
-        sys.exit(bugtool.main())
-    except KeyboardInterrupt:
-        print "\nInterrupted."
-        sys.exit(1)
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 10 lines · Hans van Kranenburg

xen-bugtool relies on code that has been removed in commit 9e8672f1c3 "tools: remove xend and associated python modules", more than 5 years ago. Remove it, since it confuses users.

-$ /usr/sbin/xen-bugtool
Traceback (most recent call last):
File "/usr/sbin/xen-bugtool", line 9, in <module>
from xen.util import bugtool
ImportError: No module named xen.util

Quoted 4 lines

I think we want that in 4.12. So:

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#2 lore raw
In reply to Hans van Kranenburg
Quoted 4 lines · Hans van Kranenburg

xen-bugtool relies on code that has been removed in commit 9e8672f1c3 "tools: remove xend and associated python modules", more than 5 years ago. Remove it, since it confuses users.

Quoted 8 lines

-$ /usr/sbin/xen-bugtool
Traceback (most recent call last):
File "/usr/sbin/xen-bugtool", line 9, in <module>
from xen.util import bugtool
ImportError: No module named xen.util

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel