clk: tegra: tegra124-emc: Fix potential memory leak
Subsystems (3)
PATCH 1/1 clk: tegra: tegra124-emc: Fix potential memory leak
The tegra and tegra needs to be freed in the error handling path, otherwise it will be leaked.
--- drivers/clk/tegra/clk-tegra124-emc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/tegra/clk-tegra124-emc.c +2 -0
@@ -464,6 +464,7 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra, err =load_one_timing_from_dt (tegra, timing, child);if (err) {of_node_put (child); +kfree (tegra->timings);return err; }
@@ -515,6 +516,7 @@ struct clk *tegra124_clk_register_emc(void __iomem *base, struct device_node *np err =load_timings_from_dt (tegra, node, node_ram_code);if (err) {of_node_put (node); +kfree (tegra);return ERR_PTR (err); } }
Signature · 1 line
2.17.1
Stephen Boyd
maintainerQuoting Yuan Can (2022-12-09 01:41:24)
Quoted 6 lines
The tegra and tegra needs to be freed in the error handling path, otherwise it will be leaked.
Fixes 2db04f16b589 ("clk: tegra: Add EMC clock driver")Signed-off-by Yuan Can <[email protected]>---
Will anyone at Nvidia review this?
Quoted 22 lines · Yuan Can
The tegra and tegra needs to be freed in the error handling path, otherwise it will be leaked.
Fixes 2db04f16b589 ("clk: tegra: Add EMC clock driver")Signed-off-by Yuan Can <[email protected]>--- drivers/clk/tegra/clk-tegra124-emc.c | 2 ++ 1 file changed, 2 insertions(+)drivers/clk/tegra/clk-tegra124-emc.c +1
-0@@ -464,6 +464,7 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra, err =load_one_timing_from_dt (tegra, timing, child);if (err) {of_node_put (child); +kfree (tegra->timings);return err; }
drivers/clk/tegra/clk-tegra124-emc.c struct clk *tegra124_clk_register_emc(void __iomem *base, struct device_node *np · line 522
Quoted 7 lines
drivers/clk/tegra/clk-tegra124-emc.c +1
-0@@ -515,6 +516,7 @@ struct clk *tegra124_clk_register_emc(void __iomem *base, struct device_node *np err =load_timings_from_dt (tegra, node, node_ram_code);if (err) {of_node_put (node); +kfree (tegra);return ERR_PTR (err); } }
Don't we need another kfree(tegra) in case the clk_register() fails? We could do that as a follow-up and this patch isn't wrong, so:
Quoting Yuan Can (2022-12-09 01:41:24)
Quoted 6 lines
The tegra and tegra needs to be freed in the error handling path, otherwise it will be leaked.
Fixes 2db04f16b589 ("clk: tegra: Add EMC clock driver")Signed-off-by Yuan Can <[email protected]>---
Applied to clk-next