Skip to contentSkip to conversation

arm: sunxi: Allwinner A10 SPI driver

PATCH New Stefan Mavrodiev 4 participants 16 messages Feb 6, 2018 – Feb 15, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 arm: sunxi: Allwinner A10 SPI driver

Add spi driver for sun4i, sun5i and sun7i SoCs. The driver is adapted from mailine kernel.

---
Changes for v4:
- Sync patch with u-boot-sunxi (80719938c9f901cc6b90b85d8065d084a03c06ae)
- Change wait_for_bits() to wait_for_bits_le32()
- Change CCTL register modification
- Some coding style changes
- Add flash subnode in the DT
- Disable spl build of sf_probe
- Enable CONFIG_DM_SPI_FLASH
- Set enviroment in spi flash

Changes for v3:
- Add required changes in dts and defeconfig file for testing

Changes for v2:
- Updated copyright including original owners
- Remove write/read register function. They are replaced with direct opts
- Some coding style changes

 drivers/spi/Kconfig     |   5 +
 drivers/spi/Makefile    |   1 +
 drivers/spi/sun4i_spi.c | 456 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 462 insertions(+)
 create mode 100644 drivers/spi/sun4i_spi.c
drivers/spi/Kconfig +5 -0
index 1e95dc4..bb9f800 100644
@@ -148,6 +148,11 @@ config STM32_QSPI
 	  used to access the SPI NOR flash chips on platforms embedding
 	  this ST IP core.
 
+config SUN4I_SPI
+	bool "Allwinner A10 SoCs SPI controller"
+	help
+	  SPI driver for Allwinner sun4i, sun5i and sun7i SoCs
+
 config TEGRA114_SPI
 	bool "nVidia Tegra114 SPI driver"
 	help
drivers/spi/Makefile +1 -0
index 4b6000f..794e70c 100644
@@ -44,6 +44,7 @@ obj-$(CONFIG_SANDBOX_SPI) += sandbox_spi.o
 obj-$(CONFIG_SH_SPI) += sh_spi.o
 obj-$(CONFIG_SH_QSPI) += sh_qspi.o
 obj-$(CONFIG_STM32_QSPI) += stm32_qspi.o
+obj-$(CONFIG_SUN4I_SPI) += sun4i_spi.o
 obj-$(CONFIG_TEGRA114_SPI) += tegra114_spi.o
 obj-$(CONFIG_TEGRA20_SFLASH) += tegra20_sflash.o
 obj-$(CONFIG_TEGRA20_SLINK) += tegra20_slink.o
drivers/spi/sun4i_spi.c new file +456 -0

456 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

The testing log is:

U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200)
DRAM: 1024 MiB

  CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
  Trying to boot from FEL

U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200) Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

  I2C:   ready
  DRAM:  1 GiB
  MMC:   SUNXI SD/MMC: 0
  Loading Environment from SPI Flash... SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB
  OK
  In:    serial
  Out:   serial
  Err:   serial
  Allwinner mUSB OTG (Peripheral)
  SCSI:  SATA link 0 timeout.
  AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
  flags: ncq stag pm led clo only pmp pio slum part ccc apst
  Net:   No ethernet found.
  starting USB...
  USB0:   USB EHCI 1.00
  USB1:   USB OHCI 1.0
  USB2:   USB EHCI 1.00
  USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB

# Erase
=> sf erase 0x1000 0x100
SF: 256 bytes @ 0x1000 Erased: ERROR
=> sf erase 0x1000 0x1000
SF: 4096 bytes @ 0x1000 Erased: OK

# Test
=> sf test 0 100000
SPI flash test:
0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
Test passed
0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

# Try write/read
=> sf erase 0x1000 0x1000
SF: 4096 bytes @ 0x1000 Erased: OK

=> md.b 0x50000000 0x100

  50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53    .M.h.Hi..x..3f.S
  50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc    .S.y.3y.........
  50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb    ...S..f......s..
  50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf    .K.......S.}.8o.
  50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb    ...^.......v....
  50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7    .._.............
  50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7    .n._.zb..f.m..G.
  50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db    ................
  50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3    ......./........
  50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee    <../.^o../+.?...
  500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77    o^..;[email protected]
  500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4    ..}.TJh.}.S.....
  500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f    s.<.........=...
  500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf    .I.......z...z{.
  500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8    ...?............
  500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f    ....!.Z.z}..1.?o

=> sf write 0x50000000 0x1000 0x100
device 0 offset 0x1000, size 0x100
SF: 256 bytes @ 0x1000 Written: OK
=> sf read 0x51000000 0x1000 0x100
device 0 offset 0x1000, size 0x100
SF: 256 bytes @ 0x1000 Read: OK

=> cmp.b 0x50000000 0x51000000 0x100
Total of 256 byte(s) were the same

---
 arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30 ++++++++++++++++++++++++++++++
 configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
 drivers/mtd/spi/Makefile                   |  4 +++-
 include/configs/sunxi-common.h             |  2 ++
 4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +30 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
 	aliases {
 		serial0 = &uart0;
+		spi0 = &spi0;
 	};
 
 	chosen {
@@ -215,6 +216,20 @@
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
 
+	spi0_pins_b: spi0 at 1 {
+		allwinner,pins = "PC0", "PC1", "PC2";
+		allwinner,function = "spi0";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
+
+	spi0_cs0_pins_b: spi0_cs0 at 1 {
+		allwinner,pins = "PC23";
+		allwinner,function = "spi0";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
+
 	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
 		allwinner,pins = "PH4";
 		allwinner,function = "gpio_in";
@@ -257,6 +272,21 @@
 	status = "okay";
 };
 
+&spi0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+	status = "okay";
+
+	flash: w25q128 at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "winbond,w25q128", "jedec,spi-nor", "spi-flash";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+		status = "okay";
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins_a>;
configs/A20-OLinuXino-Lime2_defconfig +11 -0
index 1edc844..da5ca34 100644
@@ -30,3 +30,14 @@ CONFIG_SCSI=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPL_SPI_SUNXI=y
+CONFIG_DM_SPI=y
+CONFIG_SUN4I_SPI=y
+# CONFIG_ENV_IS_IN_FAT is not set
+# CONFIG_ENV_IS_IN_MMC is not set
+CONFIG_ENV_IS_IN_SPI_FLASH=y
drivers/mtd/spi/Makefile +3 -1
index fcda023..d4a5fbd 100644
@@ -10,9 +10,11 @@ obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o
 ifdef CONFIG_SPL_BUILD
 obj-$(CONFIG_SPL_SPI_BOOT)	+= fsl_espi_spl.o
 obj-$(CONFIG_SPL_SPI_SUNXI)	+= sunxi_spi_spl.o
+else
+obj-$(CONFIG_SPI_FLASH)	+= sf_probe.o
 endif
 
-obj-$(CONFIG_SPI_FLASH) += sf_probe.o spi_flash.o spi_flash_ids.o sf.o
+obj-$(CONFIG_SPI_FLASH) += spi_flash.o spi_flash_ids.o sf.o
 obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o
 obj-$(CONFIG_SPI_FLASH_MTD) += sf_mtd.o
 obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o
include/configs/sunxi-common.h +2 -0
index 9b3944a..64fd3f9 100644
@@ -165,6 +165,8 @@
 #define CONFIG_SYS_MMC_ENV_DEV		0
 #endif
 #define CONFIG_SYS_MMC_MAX_DEVICE	4
+#elif defined(CONFIG_ENV_IS_IN_SPI_FLASH)
+#define CONFIG_ENV_SECT_SIZE		(128 << 10)
 #elif defined(CONFIG_ENV_IS_NOWHERE)
 #define CONFIG_ENV_SIZE			(128 << 10)
 #endif
Signature · 1 line
2.7.4
#2 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 7 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

Quoted 6 lines

The testing log is:

U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200)
DRAM: 1024 MiB

  CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
  Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Quoted 23 lines

U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200) Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

  I2C:   ready
  DRAM:  1 GiB
  MMC:   SUNXI SD/MMC: 0
  Loading Environment from SPI Flash... SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB
  OK
  In:    serial
  Out:   serial
  Err:   serial
  Allwinner mUSB OTG (Peripheral)
  SCSI:  SATA link 0 timeout.
  AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
  flags: ncq stag pm led clo only pmp pio slum part ccc apst
  Net:   No ethernet found.
  starting USB...
  USB0:   USB EHCI 1.00
  USB1:   USB OHCI 1.0
  USB2:   USB EHCI 1.00
  USB3:   USB OHCI 1.0
Quoted 8 lines

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB

How did this resolved w/o sspi?

Quoted 94 lines

# Erase
=> sf erase 0x1000 0x100
SF: 256 bytes @ 0x1000 Erased: ERROR
=> sf erase 0x1000 0x1000
SF: 4096 bytes @ 0x1000 Erased: OK

# Test
=> sf test 0 100000
SPI flash test:
0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
Test passed
0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

# Try write/read
=> sf erase 0x1000 0x1000
SF: 4096 bytes @ 0x1000 Erased: OK

=> md.b 0x50000000 0x100

  50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53    .M.h.Hi..x..3f.S
  50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc    .S.y.3y.........
  50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb    ...S..f......s..
  50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf    .K.......S.}.8o.
  50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb    ...^.......v....
  50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7    .._.............
  50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7    .n._.zb..f.m..G.
  50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db    ................
  50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3    ......./........
  50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee    <../.^o../+.?...
  500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77    o^..;Q... at N....w
  500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4    ..}.TJh.}.S.....
  500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f    s.<.........=...
  500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf    .I.......z...z{.
  500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8    ...?............
  500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f    ....!.Z.z}..1.?o

=> sf write 0x50000000 0x1000 0x100
device 0 offset 0x1000, size 0x100
SF: 256 bytes @ 0x1000 Written: OK
=> sf read 0x51000000 0x1000 0x100
device 0 offset 0x1000, size 0x100
SF: 256 bytes @ 0x1000 Read: OK

=> cmp.b 0x50000000 0x51000000 0x100
Total of 256 byte(s) were the same

---
 arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30 ++++++++++++++++++++++++++++++
 configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
 drivers/mtd/spi/Makefile                   |  4 +++-
 include/configs/sunxi-common.h             |  2 ++
 4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
        aliases {
                serial0 = &uart0;
+               spi0 = &spi0;
        };
 
        chosen {
@@ -215,6 +216,20 @@
                allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
        };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
        usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                allwinner,pins = "PH4";
                allwinner,function = "gpio_in";

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 9 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
@@ -257,6 +272,21 @@
        status = "okay";
 };
 
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

I think as per binding docs

[label:] node-name[@unit-address]
vendor: subsys-nane[@0]
w25q128: spi-nor at 0 {

Quoted 36 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +9 -0
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "winbond,w25q128", "jedec,spi-nor", "spi-flash";
+               reg = <0>;
+               spi-max-frequency = <20000000>;
+               status = "okay";
+       };
+};
+
 &uart0 {
        pinctrl-names = "default";
        pinctrl-0 = <&uart0_pins_a>;
configs/A20-OLinuXino-Lime2_defconfig +11 -0
index 1edc844..da5ca34 100644
@@ -30,3 +30,14 @@ CONFIG_SCSI=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPL_SPI_SUNXI=y
+CONFIG_DM_SPI=y
+CONFIG_SUN4I_SPI=y
+# CONFIG_ENV_IS_IN_FAT is not set
+# CONFIG_ENV_IS_IN_MMC is not set
+CONFIG_ENV_IS_IN_SPI_FLASH=y
drivers/mtd/spi/Makefile +0 -0
index fcda023..d4a5fbd 100644

drivers/mtd/spi/Makefile obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o · line 15

Quoted 6 lines
drivers/mtd/spi/Makefile +2 -0
@@ -10,9 +10,11 @@ obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o
 ifdef CONFIG_SPL_BUILD
 obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
 obj-$(CONFIG_SPL_SPI_SUNXI)    += sunxi_spi_spl.o
+else
+obj-$(CONFIG_SPI_FLASH)        += sf_probe.o
 endif

This will break SPL build with sf_probe.c and even we can unnecessary build other SPI_FLASH files.

#3 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 8 lines · Jagan Teki
Quoted 7 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

Quoted 7 lines
Quoted 6 lines

The testing log is:

   U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200)
   DRAM: 1024 MiB
   CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
   Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting from SPI:

  U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
  DRAM: 1024 MiB

   CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
   Trying to boot from sunxi SPI

  U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
Allwinner Technology

  CPU:   Allwinner A20 (SUN7I)
  Model: Olimex A20-OLinuXino-LIME2
  I2C:   ready
  DRAM:  1 GiB
  MMC:   SUNXI SD/MMC: 0
  Loading Environment from SPI Flash... SF: Detected w25q128bv with
page size 256 Bytes, erase size 4 KiB, total 16 MiB
  OK
  In:    serial
  Out:   serial
  Err:   serial
  Allwinner mUSB OTG (Peripheral)
  SCSI:  SATA link 0 timeout.
  AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
  flags: ncq stag pm led clo only pmp pio slum part ccc apst Net:   No ethernet found.
  starting USB...
  USB0:   USB EHCI 1.00
  USB1:   USB OHCI 1.0
  USB2:   USB EHCI 1.00
  USB3:   USB OHCI 1.0
  scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found Hit any key to stop autoboot:

Quoted 28 lines
Quoted 28 lines

U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200) Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

   I2C:   ready
   DRAM:  1 GiB
   MMC:   SUNXI SD/MMC: 0
   Loading Environment from SPI Flash... SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB
   OK
   In:    serial
   Out:   serial
   Err:   serial
   Allwinner mUSB OTG (Peripheral)
   SCSI:  SATA link 0 timeout.
   AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
   flags: ncq stag pm led clo only pmp pio slum part ccc apst
   Net:   No ethernet found.
   starting USB...
   USB0:   USB EHCI 1.00
   USB1:   USB OHCI 1.0
   USB2:   USB EHCI 1.00
   USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0

Quoted 4 lines
Quoted 3 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB, total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 97 lines
Quoted 97 lines
   # Erase
   => sf erase 0x1000 0x100
   SF: 256 bytes @ 0x1000 Erased: ERROR
   => sf erase 0x1000 0x1000
   SF: 4096 bytes @ 0x1000 Erased: OK

   # Test
   => sf test 0 100000
   SPI flash test:
   0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
   1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
   2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
   3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
   Test passed
   0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
   1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
   2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
   3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

   # Try write/read
   => sf erase 0x1000 0x1000
   SF: 4096 bytes @ 0x1000 Erased: OK

   => md.b 0x50000000 0x100
   50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53    .M.h.Hi..x..3f.S
   50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc    .S.y.3y.........
   50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb    ...S..f......s..
   50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf    .K.......S.}.8o.
   50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb    ...^.......v....
   50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7    .._.............
   50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7    .n._.zb..f.m..G.
   50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db    ................
   50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3    ......./........
   50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee    <../.^o../+.?...
   500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77    o^..;Q... at N....w
   500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4    ..}.TJh.}.S.....
   500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f    s.<.........=...
   500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf    .I.......z...z{.
   500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8    ...?............
   500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f    ....!.Z.z}..1.?o

   => sf write 0x50000000 0x1000 0x100
   device 0 offset 0x1000, size 0x100
   SF: 256 bytes @ 0x1000 Written: OK
   => sf read 0x51000000 0x1000 0x100
   device 0 offset 0x1000, size 0x100
   SF: 256 bytes @ 0x1000 Read: OK

   => cmp.b 0x50000000 0x51000000 0x100
   Total of 256 byte(s) were the same
---
  arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30 ++++++++++++++++++++++++++++++
  configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
  drivers/mtd/spi/Makefile                   |  4 +++-
  include/configs/sunxi-common.h             |  2 ++
  4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
         aliases {
                 serial0 = &uart0;
+               spi0 = &spi0;
         };
 
         chosen {
@@ -215,6 +216,20 @@
                 allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
         };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
         usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                 allwinner,pins = "PH4";
                 allwinner,function = "gpio_in";
@@ -257,6 +272,21 @@
         status = "okay";
  };
 
Quoted 7 lines

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 6 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

No, this isn't in the linux dts.

Quoted 43 lines

I think as per binding docs

[label:] node-name[@unit-address]
vendor: subsys-nane[@0]
w25q128: spi-nor at 0 {

Quoted 36 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +9 -0
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "winbond,w25q128", "jedec,spi-nor", "spi-flash";
+               reg = <0>;
+               spi-max-frequency = <20000000>;
+               status = "okay";
+       };
+};
+
  &uart0 {
         pinctrl-names = "default";
         pinctrl-0 = <&uart0_pins_a>;
configs/A20-OLinuXino-Lime2_defconfig +11 -0
index 1edc844..da5ca34 100644
@@ -30,3 +30,14 @@ CONFIG_SCSI=y
  CONFIG_USB_EHCI_HCD=y
  CONFIG_USB_MUSB_GADGET=y
  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPL_SPI_SUNXI=y
+CONFIG_DM_SPI=y
+CONFIG_SUN4I_SPI=y
+# CONFIG_ENV_IS_IN_FAT is not set
+# CONFIG_ENV_IS_IN_MMC is not set
+CONFIG_ENV_IS_IN_SPI_FLASH=y
drivers/mtd/spi/Makefile +0 -0
index fcda023..d4a5fbd 100644
@@ -10,9 +10,11 @@ obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o
Quoted 8 lines

drivers/mtd/spi/Makefile obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o · line 15

Quoted 6 lines
drivers/mtd/spi/Makefile +2 -0
  ifdef CONFIG_SPL_BUILD
  obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
  obj-$(CONFIG_SPL_SPI_SUNXI)    += sunxi_spi_spl.o
+else
+obj-$(CONFIG_SPI_FLASH)        += sf_probe.o
  endif

This will break SPL build with sf_probe.c and even we can unnecessary build other SPI_FLASH files.

Yes, but if both DM and legacy drivers are enabled u-boot won't build.
From what I can understand,
sf-uclass is some kind of wrapper of sf_probe. Maybe sf_probe needs some rework, because it uses
functions not available during spl build. Thats why I exclude it during spl, because after all this is
test case, not actual patch.

Regards,
Stefan Mavrodiev

#4 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 226 lines · Stefan Mavrodiev
Quoted 13 lines · Jagan Teki
Quoted 10 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

The testing log is:

Quoted 7 lines
Quoted 5 lines
   U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07
+0200)
   DRAM: 1024 MiB
   CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
   Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting from SPI:

U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
DRAM: 1024 MiB

  CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
  Trying to boot from sunxi SPI

U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200) Allwinner
Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

  I2C:   ready
  DRAM:  1 GiB
  MMC:   SUNXI SD/MMC: 0
  Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
  OK
  In:    serial
  Out:   serial
  Err:   serial
  Allwinner mUSB OTG (Peripheral)
  SCSI:  SATA link 0 timeout.
  AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
  flags: ncq stag pm led clo only pmp pio slum part ccc apst
  Net:   No ethernet found.
  starting USB...
  USB0:   USB EHCI 1.00
  USB1:   USB OHCI 1.0
  USB2:   USB EHCI 1.00
  USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:

Quoted 31 lines
Quoted 31 lines

   U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200)

Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

   I2C:   ready
   DRAM:  1 GiB
   MMC:   SUNXI SD/MMC: 0
   Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
   OK
   In:    serial
   Out:   serial
   Err:   serial
   Allwinner mUSB OTG (Peripheral)
   SCSI:  SATA link 0 timeout.
   AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
   flags: ncq stag pm led clo only pmp pio slum part ccc apst
   Net:   No ethernet found.
   starting USB...
   USB0:   USB EHCI 1.00
   USB1:   USB OHCI 1.0
   USB2:   USB EHCI 1.00
   USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0

Quoted 6 lines
Quoted 4 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB,
total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 116 lines
Quoted 116 lines

   # Erase
   => sf erase 0x1000 0x100
   SF: 256 bytes @ 0x1000 Erased: ERROR
   => sf erase 0x1000 0x1000
   SF: 4096 bytes @ 0x1000 Erased: OK

   # Test
   => sf test 0 100000
   SPI flash test:
   0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
   1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
   2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
   3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
   Test passed
   0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
   1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
   2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
   3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

   # Try write/read
   => sf erase 0x1000 0x1000
   SF: 4096 bytes @ 0x1000 Erased: OK

   => md.b 0x50000000 0x100
   50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53

.M.h.Hi..x..3f.S
50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc
.S.y.3y.........
50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb
...S..f......s..
50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf
.K.......S.}.8o.
50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb
...^.......v....
50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7
.._.............
50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7
.n._.zb..f.m..G.
50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db
................
50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3
......./........
50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee
<../.^o../+.?...
500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77
o^..;Q... at N....w
500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4
..}.TJh.}.S.....
500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f
s.<.........=...
500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf
.I.......z...z{.
500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8
...?............
500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f
....!.Z.z}..1.?o

   => sf write 0x50000000 0x1000 0x100
   device 0 offset 0x1000, size 0x100
   SF: 256 bytes @ 0x1000 Written: OK
   => sf read 0x51000000 0x1000 0x100
   device 0 offset 0x1000, size 0x100
   SF: 256 bytes @ 0x1000 Read: OK

   => cmp.b 0x50000000 0x51000000 0x100
   Total of 256 byte(s) were the same
---
  arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30
++++++++++++++++++++++++++++++
  configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
  drivers/mtd/spi/Makefile                   |  4 +++-
  include/configs/sunxi-common.h             |  2 ++
  4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
         aliases {
                 serial0 = &uart0;
+               spi0 = &spi0;
         };
 
         chosen {
@@ -215,6 +216,20 @@
                 allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
         };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
         usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                 allwinner,pins = "PH4";
                 allwinner,function = "gpio_in";
@@ -257,6 +272,21 @@
         status = "okay";
  };
 
Quoted 8 lines

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 6 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

Quoted 56 lines
Quoted 47 lines

I think as per binding docs

[label:] node-name[@unit-address]
vendor: subsys-nane[@0]
w25q128: spi-nor at 0 {

Quoted 39 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +9 -0
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "winbond,w25q128", "jedec,spi-nor",
 "spi-flash";
+               reg = <0>;
+               spi-max-frequency = <20000000>;
+               status = "okay";
+       };
+};
+
  &uart0 {
         pinctrl-names = "default";
         pinctrl-0 = <&uart0_pins_a>;
configs/A20-OLinuXino-Lime2_defconfig +11 -0
index 1edc844..da5ca34 100644
@@ -30,3 +30,14 @@ CONFIG_SCSI=y
  CONFIG_USB_EHCI_HCD=y
  CONFIG_USB_MUSB_GADGET=y
  CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPL_SPI_SUNXI=y
+CONFIG_DM_SPI=y
+CONFIG_SUN4I_SPI=y
+# CONFIG_ENV_IS_IN_FAT is not set
+# CONFIG_ENV_IS_IN_MMC is not set
+CONFIG_ENV_IS_IN_SPI_FLASH=y
drivers/mtd/spi/Makefile +0 -0
index fcda023..d4a5fbd 100644
@@ -10,9 +10,11 @@ obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o
  ifdef CONFIG_SPL_BUILD
Quoted 8 lines

drivers/mtd/spi/Makefile obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o · line 15

Quoted 5 lines
drivers/mtd/spi/Makefile +2 -0
  obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
  obj-$(CONFIG_SPL_SPI_SUNXI)    += sunxi_spi_spl.o
+else
+obj-$(CONFIG_SPI_FLASH)        += sf_probe.o
  endif

This will break SPL build with sf_probe.c and even we can unnecessary build other SPI_FLASH files.

Quoted 7 lines

Yes, but if both DM and legacy drivers are enabled u-boot won't build. From what I can understand,
sf-uclass is some kind of wrapper of sf_probe. Maybe sf_probe needs some rework, because it uses
functions not available during spl build. Thats why I exclude it during spl, because after all this is
test case, not actual patch.

That isn't true exactly, sunxi_spi_spl.c need drivers/mtd during SPL and If SPI_FLASH is built because if defined. Technically sunxi_spi_spl doesn't use either SPI or SPL_FLASH subsystem. So I've moved this into arch area, try this [1]

[1] https://patchwork.ozlabs.org/patch/869946/

#5 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 218 lines · Jagan Teki
Quoted 216 lines · Stefan Mavrodiev
Quoted 9 lines · Jagan Teki
Quoted 7 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

Quoted 8 lines
Quoted 7 lines

The testing log is:

    U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07
+0200)
    DRAM: 1024 MiB
    CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
    Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting from SPI:

   U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
   DRAM: 1024 MiB
   CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
   Trying to boot from sunxi SPI


   U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200) Allwinner

Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

   I2C:   ready
   DRAM:  1 GiB
   MMC:   SUNXI SD/MMC: 0
   Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
   OK
   In:    serial
   Out:   serial
   Err:   serial
   Allwinner mUSB OTG (Peripheral)
   SCSI:  SATA link 0 timeout.
   AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
   flags: ncq stag pm led clo only pmp pio slum part ccc apst
   Net:   No ethernet found.
   starting USB...
   USB0:   USB EHCI 1.00
   USB1:   USB OHCI 1.0
   USB2:   USB EHCI 1.00
   USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:

Quoted 30 lines
Quoted 30 lines
    U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07 +0200)

Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0

Quoted 5 lines
Quoted 4 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB,
total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 122 lines
Quoted 112 lines
    # Erase
    => sf erase 0x1000 0x100
    SF: 256 bytes @ 0x1000 Erased: ERROR
    => sf erase 0x1000 0x1000
    SF: 4096 bytes @ 0x1000 Erased: OK

    # Test
    => sf test 0 100000
    SPI flash test:
    0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
    1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
    2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
    3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
    Test passed
    0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
    1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
    2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
    3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

    # Try write/read
    => sf erase 0x1000 0x1000
    SF: 4096 bytes @ 0x1000 Erased: OK

    => md.b 0x50000000 0x100
    50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53
.M.h.Hi..x..3f.S
    50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc
.S.y.3y.........
    50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb
...S..f......s..
    50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf
.K.......S.}.8o.
    50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb
...^.......v....
    50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7
.._.............
    50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7
.n._.zb..f.m..G.
    50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db
................
    50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3
......./........
    50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee
<../.^o../+.?...
    500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77
o^..;Q... at N....w
    500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4
..}.TJh.}.S.....
    500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f
s.<.........=...
    500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf
.I.......z...z{.
    500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8
...?............
    500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f

....!.Z.z}..1.?o

    => sf write 0x50000000 0x1000 0x100
    device 0 offset 0x1000, size 0x100
    SF: 256 bytes @ 0x1000 Written: OK
    => sf read 0x51000000 0x1000 0x100
    device 0 offset 0x1000, size 0x100
    SF: 256 bytes @ 0x1000 Read: OK

    => cmp.b 0x50000000 0x51000000 0x100
    Total of 256 byte(s) were the same
---
   arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30
++++++++++++++++++++++++++++++
   configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
   drivers/mtd/spi/Makefile                   |  4 +++-
   include/configs/sunxi-common.h             |  2 ++
   4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
          aliases {
                  serial0 = &uart0;
+               spi0 = &spi0;
          };
 
          chosen {
@@ -215,6 +216,20 @@
                  allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
          };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
          usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                  allwinner,pins = "PH4";
                  allwinner,function = "gpio_in";

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 9 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
@@ -257,6 +272,21 @@
          status = "okay";
   };
 
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 2 lines
Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Quoted 61 lines
Quoted 54 lines
Quoted 46 lines

I think as per binding docs

[label:] node-name[@unit-address]
vendor: subsys-nane[@0]
w25q128: spi-nor at 0 {

Quoted 38 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +9 -0
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "winbond,w25q128", "jedec,spi-nor",
 "spi-flash";
+               reg = <0>;
+               spi-max-frequency = <20000000>;
+               status = "okay";
+       };
+};
+
   &uart0 {
          pinctrl-names = "default";
          pinctrl-0 = <&uart0_pins_a>;
configs/A20-OLinuXino-Lime2_defconfig +11 -0
index 1edc844..da5ca34 100644
@@ -30,3 +30,14 @@ CONFIG_SCSI=y
   CONFIG_USB_EHCI_HCD=y
   CONFIG_USB_MUSB_GADGET=y
   CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPL_SPI_SUNXI=y
+CONFIG_DM_SPI=y
+CONFIG_SUN4I_SPI=y
+# CONFIG_ENV_IS_IN_FAT is not set
+# CONFIG_ENV_IS_IN_MMC is not set
+CONFIG_ENV_IS_IN_SPI_FLASH=y
drivers/mtd/spi/Makefile +0 -0
index fcda023..d4a5fbd 100644
@@ -10,9 +10,11 @@ obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o
Quoted 8 lines

drivers/mtd/spi/Makefile obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o · line 15

Quoted 6 lines
drivers/mtd/spi/Makefile +2 -0
   ifdef CONFIG_SPL_BUILD
   obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
   obj-$(CONFIG_SPL_SPI_SUNXI)    += sunxi_spi_spl.o
+else
+obj-$(CONFIG_SPI_FLASH)        += sf_probe.o
   endif

This will break SPL build with sf_probe.c and even we can unnecessary build other SPI_FLASH files.

Quoted 7 lines

Yes, but if both DM and legacy drivers are enabled u-boot won't build. From what I can understand,
sf-uclass is some kind of wrapper of sf_probe. Maybe sf_probe needs some rework, because it uses
functions not available during spl build. Thats why I exclude it during spl, because after all this is
test case, not actual patch.

Quoted 6 lines

That isn't true exactly, sunxi_spi_spl.c need drivers/mtd during SPL and If SPI_FLASH is built because if defined. Technically sunxi_spi_spl doesn't use either SPI or SPL_FLASH subsystem. So I've moved this into arch area, try this [1]

[1] https://patchwork.ozlabs.org/patch/869946/

I'll try it.

[1] https://patchwork.ozlabs.org/patch/846031/

#6 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 236 lines · Stefan Mavrodiev
Quoted 235 lines · Jagan Teki
Quoted 232 lines · Stefan Mavrodiev
Quoted 13 lines · Jagan Teki
Quoted 10 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

The testing log is:

Quoted 7 lines
Quoted 5 lines
    U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07
+0200)
    DRAM: 1024 MiB
    CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
    Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting
from SPI:

   U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
   DRAM: 1024 MiB
   CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
   Trying to boot from sunxi SPI


   U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)

Allwinner
Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2

   I2C:   ready
   DRAM:  1 GiB
   MMC:   SUNXI SD/MMC: 0
   Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
   OK
   In:    serial
   Out:   serial
   Err:   serial
   Allwinner mUSB OTG (Peripheral)
   SCSI:  SATA link 0 timeout.
   AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
   flags: ncq stag pm led clo only pmp pio slum part ccc apst
   Net:   No ethernet found.
   starting USB...
   USB0:   USB EHCI 1.00
   USB1:   USB OHCI 1.0
   USB2:   USB EHCI 1.00
   USB3:   USB OHCI 1.0

scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:

Quoted 34 lines
Quoted 34 lines

    U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07

+0200)
Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv with
page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s)
found
Hit any key to stop autoboot: 0

Quoted 6 lines
Quoted 4 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB,
total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 124 lines
Quoted 113 lines

    # Erase
    => sf erase 0x1000 0x100
    SF: 256 bytes @ 0x1000 Erased: ERROR
    => sf erase 0x1000 0x1000
    SF: 4096 bytes @ 0x1000 Erased: OK

    # Test
    => sf test 0 100000
    SPI flash test:
    0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
    1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
    2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
    3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
    Test passed
    0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
    1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
    2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
    3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

    # Try write/read
    => sf erase 0x1000 0x1000
    SF: 4096 bytes @ 0x1000 Erased: OK

    => md.b 0x50000000 0x100
    50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53
.M.h.Hi..x..3f.S
    50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc
.S.y.3y.........
    50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb
...S..f......s..
    50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf
.K.......S.}.8o.
    50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb
...^.......v....
    50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7
.._.............
    50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7
.n._.zb..f.m..G.
    50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db
................
    50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3
......./........
    50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee
<../.^o../+.?...
    500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77
o^..;Q... at N....w
    500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4
..}.TJh.}.S.....
    500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f
s.<.........=...
    500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf
.I.......z...z{.
    500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8
...?............
    500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f

....!.Z.z}..1.?o

    => sf write 0x50000000 0x1000 0x100
    device 0 offset 0x1000, size 0x100
    SF: 256 bytes @ 0x1000 Written: OK
    => sf read 0x51000000 0x1000 0x100
    device 0 offset 0x1000, size 0x100
    SF: 256 bytes @ 0x1000 Read: OK

    => cmp.b 0x50000000 0x51000000 0x100
    Total of 256 byte(s) were the same
---
   arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30
++++++++++++++++++++++++++++++
   configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
   drivers/mtd/spi/Makefile                   |  4 +++-
   include/configs/sunxi-common.h             |  2 ++
   4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
          aliases {
                  serial0 = &uart0;
+               spi0 = &spi0;
          };
 
          chosen {
@@ -215,6 +216,20 @@
                  allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
          };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
          usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                  allwinner,pins = "PH4";
                  allwinner,function = "gpio_in";

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 9 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
@@ -257,6 +272,21 @@
          status = "okay";
   };
 
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

#7 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 226 lines · Jagan Teki
Quoted 224 lines · Stefan Mavrodiev
Quoted 223 lines · Jagan Teki
Quoted 221 lines · Stefan Mavrodiev
Quoted 9 lines · Jagan Teki
Quoted 7 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

Quoted 8 lines
Quoted 7 lines

The testing log is:

     U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07
+0200)
     DRAM: 1024 MiB
     CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
     Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting
from SPI:

    U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)
    DRAM: 1024 MiB
    CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
    Trying to boot from sunxi SPI


    U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)

Allwinner
Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv with page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:

Quoted 33 lines
Quoted 33 lines
     U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07

+0200)
Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv with
page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s)
found
Hit any key to stop autoboot: 0

Quoted 5 lines
Quoted 4 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4 KiB,
total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 122 lines
Quoted 112 lines
     # Erase
     => sf erase 0x1000 0x100
     SF: 256 bytes @ 0x1000 Erased: ERROR
     => sf erase 0x1000 0x1000
     SF: 4096 bytes @ 0x1000 Erased: OK

     # Test
     => sf test 0 100000
     SPI flash test:
     0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
     1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
     2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
     3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
     Test passed
     0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
     1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
     2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
     3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

     # Try write/read
     => sf erase 0x1000 0x1000
     SF: 4096 bytes @ 0x1000 Erased: OK

     => md.b 0x50000000 0x100
     50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53
.M.h.Hi..x..3f.S
     50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc
.S.y.3y.........
     50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb
...S..f......s..
     50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf
.K.......S.}.8o.
     50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb
...^.......v....
     50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7
.._.............
     50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7
.n._.zb..f.m..G.
     50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db
................
     50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3
......./........
     50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee
<../.^o../+.?...
     500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77
o^..;Q... at N....w
     500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4
..}.TJh.}.S.....
     500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f
s.<.........=...
     500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf
.I.......z...z{.
     500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8
...?............
     500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f

....!.Z.z}..1.?o

     => sf write 0x50000000 0x1000 0x100
     device 0 offset 0x1000, size 0x100
     SF: 256 bytes @ 0x1000 Written: OK
     => sf read 0x51000000 0x1000 0x100
     device 0 offset 0x1000, size 0x100
     SF: 256 bytes @ 0x1000 Read: OK

     => cmp.b 0x50000000 0x51000000 0x100
     Total of 256 byte(s) were the same
---
    arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30
++++++++++++++++++++++++++++++
    configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
    drivers/mtd/spi/Makefile                   |  4 +++-
    include/configs/sunxi-common.h             |  2 ++
    4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
           aliases {
                   serial0 = &uart0;
+               spi0 = &spi0;
           };
 
           chosen {
@@ -215,6 +216,20 @@
                   allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
           };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
           usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                   allwinner,pins = "PH4";
                   allwinner,function = "gpio_in";

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 9 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
@@ -257,6 +272,21 @@
           status = "okay";
    };
 
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

OK, I'll do this.

In the next revision, how to implement your patch [1]? As part of the series or
mentioned somehow?

[1]https://patchwork.ozlabs.org/patch/869946/

#8 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 262 lines · Stefan Mavrodiev
Quoted 251 lines · Jagan Teki
Quoted 248 lines · Stefan Mavrodiev
Quoted 245 lines · Jagan Teki
Quoted 239 lines · Stefan Mavrodiev
Quoted 13 lines · Jagan Teki
Quoted 10 lines · Stefan Mavrodiev

Driver testing is done with A20-OLinuXino-Lime2. Testing requirements are:
- Exposing spi0 alternative pins in the dts file
- Add alias node, enabling driver probing
- Add flash sub-node of spi
- Enable spi flash related options in the defconfig file

The testing log is:

Quoted 8 lines
Quoted 6 lines
     U-Boot SPL 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 -
14:40:07
+0200)
     DRAM: 1024 MiB
     CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
     Trying to boot from FEL

Why FEL? can't it boot from SPI-FLASH?

Because I previously erased the flash during testing. Here is same, booting
from SPI:

    U-Boot SPL 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07
+0200)
    DRAM: 1024 MiB
    CPU: 912000000Hz, AXI/AHB/APB: 3/2/2
    Trying to boot from sunxi SPI


    U-Boot 2018.03-rc1-00075-g61ce225 (Feb 07 2018 - 08:21:07 +0200)

Allwinner
Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv with
page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s)
found
Hit any key to stop autoboot:

Quoted 35 lines
Quoted 35 lines

     U-Boot 2018.03-rc1-00075-g35a689a-dirty (Feb 06 2018 - 14:40:07

+0200)
Allwinner Technology

CPU: Allwinner A20 (SUN7I)
Model: Olimex A20-OLinuXino-LIME2
I2C: ready
DRAM: 1 GiB
MMC: SUNXI SD/MMC: 0
Loading Environment from SPI Flash... SF: Detected w25q128bv
with
page
size 256 Bytes, erase size 4 KiB, total 16 MiB
OK
In: serial
Out: serial
Err: serial
Allwinner mUSB OTG (Peripheral)
SCSI: SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net: No ethernet found.
starting USB...
USB0: USB EHCI 1.00
USB1: USB OHCI 1.0
USB2: USB EHCI 1.00
USB3: USB OHCI 1.0
scanning bus 0 for devices... 1 USB Device(s) found scanning bus 2 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s)
found
Hit any key to stop autoboot: 0

Quoted 7 lines
Quoted 5 lines

# Probe device
=> sf probe
SF: Detected w25q128bv with page size 256 Bytes, erase size 4
KiB,
total 16 MiB

How did this resolved w/o sspi?

I enabled both CONFIG_SPI_FLASH and CONFIG_DM_SPI_FLASH. The driver-model
search for
"spi-flash" compatible string, probe it and bind it to the spi driver.

Quoted 116 lines
Quoted 116 lines

     # Erase
     => sf erase 0x1000 0x100
     SF: 256 bytes @ 0x1000 Erased: ERROR
     => sf erase 0x1000 0x1000
     SF: 4096 bytes @ 0x1000 Erased: OK

     # Test
     => sf test 0 100000
     SPI flash test:
     0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
     1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
     2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
     3 read: 8872 ticks, 115 KiB/s 0.920 Mbps
     Test passed
     0 erase: 12104 ticks, 84 KiB/s 0.672 Mbps
     1 check: 8881 ticks, 115 KiB/s 0.920 Mbps
     2 write: 10824 ticks, 94 KiB/s 0.752 Mbps
     3 read: 8872 ticks, 115 KiB/s 0.920 Mbps

     # Try write/read
     => sf erase 0x1000 0x1000
     SF: 4096 bytes @ 0x1000 Erased: OK

     => md.b 0x50000000 0x100
     50000000: a9 4d b7 68 d2 48 69 c3 09 78 fa d3 33 66 e9 53
.M.h.Hi..x..3f.S
     50000010: b0 53 af 79 ad 33 79 b1 f1 e3 1d 09 2e ba dd dc
.S.y.3y.........
     50000020: 8c eb eb 53 f4 ef 66 89 b5 e9 f6 fb af 73 7f cb
...S..f......s..
     50000030: b6 4b bf de c3 fd de bb 9a 53 ad 7d ef 38 6f bf
.K.......S.}.8o.
     50000040: fd fb e7 5e e9 db fc 0c fc f7 be 76 ad b9 fd eb
...^.......v....
     50000050: f3 ed 5f b5 bb bd ba 8f ff df 1f bf f3 ff fb d7
.._.............
     50000060: b7 6e 9e 5f af 7a 62 ed 7f 66 1b 6d fd fb 47 f7
.n._.zb..f.m..G.
     50000070: b7 fa f4 db d5 b6 d5 ff 81 e6 f5 d9 8f ef ff db
................
     50000080: b7 dd bd fb f3 1d 9d 2f f6 db c8 7f fb cf b9 f3
......./........
     50000090: 3c ee da 2f b7 5e 6f bc f1 2f 2b cf 3f f2 fb ee
<../.^o../+.?...
     500000a0: 6f 5e 99 c3 3b 51 bd d4 be 40 4e db ab ed f9 77
o^..;Q... at N....w
     500000b0: 9f f6 7d ed 54 4a 68 f8 7d ee 53 9b ff ae ef e4
..}.TJh.}.S.....
     500000c0: 73 ff 3c c7 f7 df f6 be bf 0f 97 96 3d 9b 9e 9f
s.<.........=...
     500000d0: e4 49 ca ff be fa ff df f7 7a cf ab 7f 7a 7b cf
.I.......z...z{.
     500000e0: bb c7 9f 3f c1 99 f2 f2 bf ee cf fb d5 b9 e2 e8
...?............
     500000f0: ec e8 b2 bd 21 1f 5a ef 7a 7d 9d ad 31 89 3f 6f

....!.Z.z}..1.?o

     => sf write 0x50000000 0x1000 0x100
     device 0 offset 0x1000, size 0x100
     SF: 256 bytes @ 0x1000 Written: OK
     => sf read 0x51000000 0x1000 0x100
     device 0 offset 0x1000, size 0x100
     SF: 256 bytes @ 0x1000 Read: OK

     => cmp.b 0x50000000 0x51000000 0x100
     Total of 256 byte(s) were the same
---
    arch/arm/dts/sun7i-a20-olinuxino-lime2.dts | 30
++++++++++++++++++++++++++++++
    configs/A20-OLinuXino-Lime2_defconfig      | 11 +++++++++++
    drivers/mtd/spi/Makefile                   |  4 +++-
    include/configs/sunxi-common.h             |  2 ++
    4 files changed, 46 insertions(+), 1 deletion(-)
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +15 -0
index d5c796c..a6ee87c 100644
@@ -54,6 +54,7 @@
 
           aliases {
                   serial0 = &uart0;
+               spi0 = &spi0;
           };
 
           chosen {
@@ -215,6 +216,20 @@
                   allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
           };
 
+       spi0_pins_b: spi0 at 1 {
+               allwinner,pins = "PC0", "PC1", "PC2";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
+       spi0_cs0_pins_b: spi0_cs0 at 1 {
+               allwinner,pins = "PC23";
+               allwinner,function = "spi0";
+               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+               allw inner,pull = <SUN4I_PINCTRL_NO_PULL>;
+       };
+
           usb0_id_detect_pin: usb0_id_detect_pin at 0 {
                   allwinner,pins = "PH4";
                   allwinner,function = "gpio_in";
@@ -257,6 +272,21 @@
           status = "okay";
    };
 
Quoted 8 lines

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 6 lines
arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +6 -0
+&spi0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

Quoted 8 lines
Quoted 4 lines

We've already commented this issue. In the v2 [1], I've explained that this
won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

Quoted 7 lines

OK, I'll do this.

In the next revision, how to implement your patch [1]? As part of the series or
mentioned somehow?

[1]https://patchwork.ozlabs.org/patch/869946/

Add your patches on top of this.

#9 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

In reply to Jagan Teki
Quoted 13 lines · Jagan Teki
Quoted 13 lines
Quoted 12 lines
Quoted 10 lines
Quoted 8 lines

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts line 280

Quoted 6 lines

+&spi0 {

arch/arm/dts/sun7i-a20-olinuxino-lime2.dts +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

Quoted 7 lines
Quoted 3 lines

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180207/96e2be54/attachment.sig>
#10 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 16 lines · Maxime Ripard
Quoted 7 lines · Jagan Teki
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 6 lines

+&spi0 {

(quoted diff) +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

Quoted 7 lines

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Maxime

Sorry, but I'm really confused. In the first patch Jagan said to make separate patch
"just to test" the driver. Then I've made patch "just to test", and it's turn out it wasn't not OK,
because it should be compatible with linux, u-boot and etc. What's the point since it's just for testing...?

Sorry again, but can someone explain to me, that to do? I'm not trying to pick on you guys. Just want to do the right thing.

Best regards,
Stefan Mavrodiev

#11 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 41 lines · Stefan Mavrodiev
Quoted 26 lines · Maxime Ripard
Quoted 20 lines · Jagan Teki
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines

Review

Quoted 7 lines

+&spi0 {

(quoted diff) +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

No, this isn't in the linux dts.

Quoted 7 lines
Quoted 1 line

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this
won't go mainline, since it's optional feature. Rather it will be managed
with overlays.

Quoted 3 lines

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

Quoted 7 lines

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Maxime

Sorry, but I'm really confused. In the first patch Jagan said to make separate patch
"just to test" the driver. Then I've made patch "just to test", and it's turn out it wasn't not OK,
because it should be compatible with linux, u-boot and etc. What's the point since it's just for testing...?

Quoted 2 lines

Sorry again, but can someone explain to me, that to do? I'm not trying to pick on you guys. Just want to do the right thing.

I think we're in out-of-sync for some reason.

Here is my suggestion:
Since it is "optional feature however similar boards of this type could not have it"?

How about separate defconfig file? A20-OLinuXino-Lime2-spinor_defconfig and have same dts file with

/* Disable SPI NOR by default: it optional on A20-OLinuXino-Lime2 boards */ status = "disabled";

But the dts should accept by Linux as well.

#12 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

Quoted 43 lines · Jagan Teki
Quoted 33 lines · Stefan Mavrodiev
Quoted 18 lines · Maxime Ripard
Quoted 9 lines · Jagan Teki
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 7 lines

Review

Quoted 6 lines

+&spi0 {

(quoted diff) +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

Quoted 8 lines
Quoted 5 lines

We've already commented this issue. In the v2 [1], I've explained that this
won't go mainline, since it's optional feature. Rather it will be managed
with overlays.

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

Quoted 7 lines

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Maxime

Sorry, but I'm really confused. In the first patch Jagan said to make separate patch
"just to test" the driver. Then I've made patch "just to test", and it's turn out it wasn't not OK,
because it should be compatible with linux, u-boot and etc. What's the point since it's just for testing...?

Quoted 2 lines

Sorry again, but can someone explain to me, that to do? I'm not trying to pick on you guys. Just want to do the right thing.

I think we're in out-of-sync for some reason.

Here is my suggestion:
Since it is "optional feature however similar boards of this type could not have it"?

Quoted 7 lines

How about separate defconfig file? A20-OLinuXino-Lime2-spinor_defconfig and have same dts file with

/* Disable SPI NOR by default: it optional on A20-OLinuXino-Lime2 boards */ status = "disabled";

But the dts should accept by Linux as well.

Already tried this [1] and got rejected.

[1] https://patchwork.kernel.org/patch/10076721/

#13 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

In reply to Jagan Teki
Quoted 48 lines · Jagan Teki
Quoted 32 lines · Stefan Mavrodiev
Quoted 22 lines · Maxime Ripard
Quoted 20 lines · Jagan Teki
Quoted 19 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

+&spi0 {

(quoted diff) +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Was it sync from Linux?

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this
won't go mainline, since it's optional feature. Rather it will be managed
with overlays.

Quoted 8 lines
Quoted 3 lines

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Quoted 8 lines

Sorry, but I'm really confused. In the first patch Jagan said to make separate patch "just to test" the driver. Then I've made patch "just to test", and it's turn out it wasn't not OK, because it should be compatible with linux, u-boot and etc. What's the point since it's just for testing...?

Sorry again, but can someone explain to me, that to do? I'm not trying to pick on you guys. Just want to do the right thing.

I think we're in out-of-sync for some reason.

Here is my suggestion: Since it is "optional feature however similar boards of this type could not have it"?

Quoted 7 lines

How about separate defconfig file? A20-OLinuXino-Lime2-spinor_defconfig and have same dts file with

/* Disable SPI NOR by default: it optional on A20-OLinuXino-Lime2 boards */ status = "disabled";

But the dts should accept by Linux as well.

We won't merge it in Linux. And I still don't really get why you want it to be enabled by default in U-Boot either. That patch has been introduced by Stefan as a patch not intended to be merged but just showing how his driver was useful.

Can't we just merge the SPI driver and be done with it?

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180208/31b26e29/attachment.sig>
#14 lore raw

PATCH v4 2/2 Enable test case with A20-OLinuXino-Lime2

In reply to Stefan Mavrodiev

Hi,

Quoted 23 lines · Stefan Mavrodiev
Quoted 13 lines · Maxime Ripard
Quoted 12 lines · Jagan Teki
Quoted 12 lines
Quoted 9 lines
Quoted 8 lines
Quoted 7 lines

Review

Quoted 6 lines

+&spi0 {

(quoted diff) +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
+       status = "okay";
+
+       flash: w25q128 at 0 {

Was it sync from Linux?

No, this isn't in the linux dts.

But we have to, please send it to Linux first.

We've already commented this issue. In the v2 [1], I've explained that this won't go mainline, since it's optional feature. Rather it will be managed with overlays.

Quoted 8 lines
Quoted 3 lines

Thought this was already in ML, and ready to merge. So this never go to Linux tree since it's optional? then add u-boot.dtsi for this atleast since we always sync dts from Linux.

This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig.

Quoted 5 lines

Sorry, but I'm really confused. In the first patch Jagan said to make separate patch "just to test" the driver. Then I've made patch "just to test", and it's turn out it wasn't not OK, because it should be compatible with linux, u-boot and etc. What's the point since it's just for testing...?

Sorry if we're not on the same page, that patch definitely looks good as a demonstration on how it could be used. Thanks for doing it, it makes things clearer :)

Quoted 2 lines

Sorry again, but can someone explain to me, that to do? I'm not trying to pick on you guys. Just want to do the right thing.

I guess we need to sync with Jagan on this.

Let's do it in the rest of the discussion.

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180208/623f18b0/attachment.sig>