Skip to contentSkip to conversation

cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option

PATCH New Arnd Bergmann 3 participants 4 messages Jun 5, 2013 – Jun 7, 2013

Subsystems (5)
Arm (32-bit) Arm sub-architectures Tegra architecture support OMAP2+ support +1 more subsystems
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option

There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be hidden inside of "if CPU_IDLE", since it is a silent option. Moving it outside lets platforms select this symbol unconditionally, which avoid a warning from the ARM omap2plus_defconfig build:

warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects
ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct dependencies (CPU_IDLE)

Signed-off-by Arnd Bergmann <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc linux-pm at vger.kernel.org
drivers/cpuidle/Kconfig +3 -3
index f4511e6..2caddb0 100644
@@ -29,9 +29,6 @@ config CPU_IDLE_GOV_MENU
 	bool "Menu governor (for tickless system)"
 	default y
 
-config ARCH_NEEDS_CPU_IDLE_COUPLED
-	def_bool n
-
 config CPU_IDLE_CALXEDA
 	bool "CPU Idle Driver for Calxeda processors"
 	depends on ARCH_HIGHBANK

@@ -39,3 +36,6 @@ config CPU_IDLE_CALXEDA
 	help
 	  Select this to enable cpuidle on Calxeda processors.
 endif
+
+config ARCH_NEEDS_CPU_IDLE_COUPLED
+	def_bool n
#1 lore raw

PATCH 1/1 cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option

Quoted 8 lines · Arnd Bergmann

There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be hidden inside of "if CPU_IDLE", since it is a silent option. Moving it outside lets platforms select this symbol unconditionally, which avoid a warning from the ARM omap2plus_defconfig build:

warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects
ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct dependencies (CPU_IDLE)

IMHO, this option depends on CPU_IDLE and thus must be kept inside the CPU_IDLE menuconfig.

The warning raised here is because this option is selected by the arch Kconfig without checking if CPU_IDLE is set or not.

I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way:

arch/arm/mach-omap2/Kconfig +1 -1
index f49cd51..831e89e 100644
@@ -83,7 +83,7 @@ config ARCH_OMAP4
        depends on ARCH_OMAP2PLUS
        depends on ARCH_MULTI_V7
        select ARCH_HAS_OPP
-       select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+       select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
        select ARM_CPU_SUSPEND if PM
        select ARM_ERRATA_720789
        select ARM_GIC
arch/arm/mach-tegra/Kconfig +1 -1
index 84d72fc..04c6221 100644
@@ -23,7 +23,7 @@ menu "NVIDIA Tegra options"
 
 config ARCH_TEGRA_2x_SOC
        bool "Enable support for Tegra20 family"
-       select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+       select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
        select ARM_ERRATA_720789
        select ARM_ERRATA_754327 if SMP
        select ARM_ERRATA_764369 if SMP
drivers/cpuidle/Kconfig +0 -0

[ ... ]

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#2 lore raw

PATCH 1/1 cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option

Quoted 10 lines · Daniel Lezcano
Quoted 8 lines · Arnd Bergmann

There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be hidden inside of "if CPU_IDLE", since it is a silent option. Moving it outside lets platforms select this symbol unconditionally, which avoid a warning from the ARM omap2plus_defconfig build:

warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects
ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct dependencies (CPU_IDLE)

Quoted 7 lines

IMHO, this option depends on CPU_IDLE and thus must be kept inside the CPU_IDLE menuconfig.

The warning raised here is because this option is selected by the arch Kconfig without checking if CPU_IDLE is set or not.

I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way:

I prefer this one.

Thanks,
Rafael

Quoted 31 lines
arch/arm/mach-omap2/Kconfig +1 -1
index f49cd51..831e89e 100644
@@ -83,7 +83,7 @@ config ARCH_OMAP4
        depends on ARCH_OMAP2PLUS
        depends on ARCH_MULTI_V7
        select ARCH_HAS_OPP
-       select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+       select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
        select ARM_CPU_SUSPEND if PM
        select ARM_ERRATA_720789
        select ARM_GIC
arch/arm/mach-tegra/Kconfig +1 -1
index 84d72fc..04c6221 100644
@@ -23,7 +23,7 @@ menu "NVIDIA Tegra options"
 
 config ARCH_TEGRA_2x_SOC
        bool "Enable support for Tegra20 family"
-       select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+       select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
        select ARM_ERRATA_720789
        select ARM_ERRATA_754327 if SMP
        select ARM_ERRATA_764369 if SMP
drivers/cpuidle/Kconfig +0 -0
 
[ ... ]
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
author
#3 lore raw

PATCH 1/1 cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option

In reply to Daniel Lezcano
Quoted 8 lines · On Wednesday 05 June 2013 14:50:44 Daniel Lezcano wrote:

IMHO, this option depends on CPU_IDLE and thus must be kept inside the CPU_IDLE menuconfig.

The warning raised here is because this option is selected by the arch Kconfig without checking if CPU_IDLE is set or not.

I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way:

Fine with me as well.

Arnd