Skip to contentSkip to conversation

ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c

PATCH In review Oleg Nesterov 3 participants 4 messages Apr 28, 2009 – Apr 29, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c

->real_parent is the parent. ->parent may be the tracer.

fs/binfmt_elf_fdpic.c renamed from fs/binfmt_elf_fdpic.c~FDPIC +2 -2
@@ -1388,7 +1388,7 @@ static void fill_prstatus(struct elf_prs
 	prstatus->pr_sigpend = p->pending.signal.sig[0];
 	prstatus->pr_sighold = p->blocked.sig[0];
 	prstatus->pr_pid = task_pid_vnr(p);
-	prstatus->pr_ppid = task_pid_vnr(p->parent);
+	prstatus->pr_ppid = task_pid_vnr(p->real_parent);
 	prstatus->pr_pgrp = task_pgrp_vnr(p);
 	prstatus->pr_sid = task_session_vnr(p);
 	if (thread_group_leader(p)) {
@@ -1433,7 +1433,7 @@ static int fill_psinfo(struct elf_prpsin
 	psinfo->pr_psargs[len] = 0;
 
 	psinfo->pr_pid = task_pid_vnr(p);
-	psinfo->pr_ppid = task_pid_vnr(p->parent);
+	psinfo->pr_ppid = task_pid_vnr(p->real_parent);
 	psinfo->pr_pgrp = task_pgrp_vnr(p);
 	psinfo->pr_sid = task_session_vnr(p);
 
#1 lore raw

fs/binfmt_elf_fdpic.c static void fill_prstatus(struct elf_prs · line 1392

Quoted 4 lines · Oleg Nesterov
fs/binfmt_elf_fdpic.c renamed from fs/binfmt_elf_fdpic.c~FDPIC +1 -1
-	prstatus->pr_ppid = task_pid_vnr(p->parent);
+	prstatus->pr_ppid = task_pid_vnr(p->real_parent);
 	prstatus->pr_pgrp = task_pgrp_vnr(p);

Hmm. Just noticed. What protects ->parent or ->real_parent ?

Looks like we need rcu_lock() around... The same in fs/binfmt_elf.c. Will send another trivial patch (on top of this) tomorrow.

Oleg.