tty: serial: bcm63xx: use more precise Kconfig symbol
Subsystems (2)
PATCH v3 1/1 tty: serial: bcm63xx: use more precise Kconfig symbol
From: Rafał Miłecki <[email protected]>
Patches lowering SERIAL_BCM63XX dependencies led to a discussion and documentation change regarding "depends" usage. Adjust Kconfig entry to match current guidelines. Make this symbol available for relevant architectures only.
Cc: Geert Uytterhoeven <[email protected]>
Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")
---
V2: Use precise "depends" (exact platforms)
V3: Don't default y for COMPILE_TEST
--- drivers/tty/serial/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
@@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on COMMON_CLK + depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST + default ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC help This enables the driver for the onchip UART core found on the following chipsets:
Signature · 1 line
2.34.1
Hi Rafał,
Quoted 7 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Patches lowering
SERIAL_BCM63XXdependencies led to a discussion and documentation change regarding "depends" usage. AdjustKconfigentry to match current guidelines. Make this symbol available for relevant architectures only.
Quoted 7 lines
Cc: Geert Uytterhoeven <[email protected]>
Ref:f35a07f92616("tty: serial: bcm63xx: lower driver dependencies")
Ref:18084e435ff6("Documentation/kbuild: Document platform dependency practises")Signed-off-by Rafał Miłecki <[email protected]>---
V2: Use precise "depends" (exact platforms)
V3: Don't default y forCOMPILE_TEST
Thanks for the update!
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1104
Quoted 9 lines
drivers/tty/serial/Kconfig +2
-1@@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE config SERIAL_BCM63XX tristate "Broadcom BCM63xx/BCM33xx UART support" select SERIAL_CORE - depends on COMMON_CLK + depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST + default ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC
I'm still not convinced about the default, as it wasn't there before, hence all existing config files must already have it.
But if the BCM people think it's good to have, I'll shut up ;-)
drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1107
Quoted 3 lines
drivers/tty/serial/Kconfig +0
-0help This enables the driver for the onchip UART core found on the following chipsets:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 11 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Patches lowering
SERIAL_BCM63XXdependencies led to a discussion and documentation change regarding "depends" usage. AdjustKconfigentry to match current guidelines. Make this symbol available for relevant architectures only.Cc: Geert Uytterhoeven <[email protected]>
Ref:f35a07f92616("tty: serial: bcm63xx: lower driver dependencies")
Ref:18084e435ff6("Documentation/kbuild: Document platform dependency practises")Signed-off-by Rafał Miłecki <[email protected]>
Signature · 1 line
Florian