Skip to contentSkip to conversation

Add support for Generic PHY in macb

PATCH New Michael Trimarchi 2 participants 2 messages Feb 22, 2008 – Feb 26, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support for Generic PHY in macb

Hi,
----- Messaggio originale -----

Quoted 12 lines

Da: Haavard Skinnemoen <[email protected]>
A: Michael Trimarchi <[email protected]>
Cc: Michael Schwingen <[email protected]>; u-boot-users at lists.sourceforge.net
Inviato: Venerd? 22 febbraio 2008, 17:08:56
Oggetto: Re: [U-Boot-Users] [PATCH] Add support for Generic PHY in macb

Quoted 3 lines · On Fri, 22 Feb 2008 16:02:13 +0000 (GMT) Michael Trimarchi wrote:
Quoted 3 lines

In any case, the dm9161a PHY in question does implement MDIO, so it really should work without any modifications.

Quoted 9 lines
Quoted 1 line

Maybe we can add the for cycle like in linux to check the phy addr?

Yes, we could do that. But it comes with its own share of problems -- some boards have a too weak pull-up (or none at all) on the MDIO line, so the probing code sometimes thinks it has found a whole bunch of PHYs...

Haavard

But the u-boot user may to choice to use the automatic detection, based on phy_id mask and stop the search on the first one, or somenthing like this.

Michael

      ___________________________________ 

L'email della prossima generazione? Puoi averla con la nuova Yahoo! Mail: http://it.docs.yahoo.com/nowyoucan.html

#1 lore raw

PATCH 1/1 Add support for Generic PHY in macb

Quoted 24 lines · Michael Trimarchi

Hi,
----- Messaggio originale -----

Quoted 21 lines

Da: Haavard Skinnemoen <[email protected]>
A: Michael Trimarchi <[email protected]>
Cc: Michael Schwingen <[email protected]>; u-boot-users at lists.sourceforge.net
Inviato: Venerd? 22 febbraio 2008, 17:08:56
Oggetto: Re: [U-Boot-Users] [PATCH] Add support for Generic PHY in macb

Quoted 6 lines · On Fri, 22 Feb 2008 16:02:13 +0000 (GMT) Michael Trimarchi wrote:
Quoted 4 lines

In any case, the dm9161a PHY in question does implement MDIO, so it really should work without any modifications.

Maybe we can add the for cycle like in linux to check the phy addr?

Yes, we could do that. But it comes with its own share of problems -- some boards have a too weak pull-up (or none at all) on the MDIO line, so the probing code sometimes thinks it has found a whole bunch of PHYs...

Quoted 8 lines
Quoted 3 lines

Haavard

But the u-boot user may to choice to use the automatic detection, based on phy_id mask and stop the search on the first one, or somenthing like this.

Michael

I don't follow why you'd want to do this. As Andy, Haavard and others have pointed out, you can't probe for PHY addresses because quite often multiple ports will share an MDIO bus, and also it's unreliable at best. Anybody who writes U-boot code needs to know the details of his or her board, and PHY addresses are always fixed in hardware. There may be some reason to make them dynamic, but I can't imagine why.

regards,
Ben