Skip to contentSkip to conversation

dmaengine: idxd: Fix crc_val field for completion record

PATCH In review Fenghua Yu 3 participants 3 messages Nov 11, 2022 – Nov 13, 2022

Subsystems (2)
lore
Share & tools
lore

Fenghua Yu

author
#0 lore raw

PATCH 1/1 dmaengine: idxd: Fix crc_val field for completion record

The crc_val in the completion record should be 64 bits and not 32 bits.

Fixes 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
---
 include/uapi/linux/idxd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/idxd.h +1 -1
index 61ee43823622..09947ae61663 100644
@@ -329,7 +329,7 @@ struct dsa_completion_record {
 		};
 
 		uint32_t	delta_rec_size;
-		uint32_t	crc_val;
+		uint64_t	crc_val;
 
 		/* DIF check & strip */
 		struct {
Signature · 1 line
2.32.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Fenghua Yu

The crc_val in the completion record should be 64 bits and not 32 bits.

Fixes 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
Quoted 17 lines
---
  include/uapi/linux/idxd.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/idxd.h +1 -1
index 61ee43823622..09947ae61663 100644
@@ -329,7 +329,7 @@ struct dsa_completion_record {
  		};
 
  		uint32_t	delta_rec_size;
-		uint32_t	crc_val;
+		uint64_t	crc_val;
 
  		/* DIF check & strip */
  		struct {
maintainer
#2 lore raw
In reply to Fenghua Yu
Quoted 4 lines · Fenghua Yu

The crc_val in the completion record should be 64 bits and not 32 bits.

Fixes 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")

Please no empty line after the fixes tag!

Applied after removing the empty line, thanks

Quoted 21 lines
---
 include/uapi/linux/idxd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/idxd.h +1 -1
index 61ee43823622..09947ae61663 100644
@@ -329,7 +329,7 @@ struct dsa_completion_record {
 		};
 
 		uint32_t	delta_rec_size;
-		uint32_t	crc_val;
+		uint64_t	crc_val;
 
 		/* DIF check & strip */
 		struct {
Signature · 1 line
2.32.0
Signature · 1 line
~Vinod