Skip to contentSkip to conversation

drm/i915: don't call free_mmap_offset when purging

PATCH Superseded Matthew Auld 3 participants 12 messages Jan 5, 2022

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 drm/i915: don't call free_mmap_offset when purging

The TTM backend is in theory the only user here(also purge should only be called once we have dropped the pages), where it is setup at object creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset to determine the page offset within the pages array.

This also blows up in the dontneed-before-mmap test, since the expectation is that the vma_node will live on, until the object is destroyed:

<2> [749.062902] kernel BUG at drivers/gpu/drm/i915/gem/i915_gem_ttm.c:943!
<4> [749.062923] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
<4> [749.062928] CPU: 0 PID: 1643 Comm: gem_madvise Tainted: G U W 5.16.0-rc8-CI-CI_DRM_11046+ #1
<4> [749.062933] Hardware name: Gigabyte Technology Co., Ltd. GB-Z390 Garuda/GB-Z390 Garuda-CF, BIOS IG1c 11/19/2019
<4> [749.062937] RIP: 0010:i915_ttm_mmap_offset.cold.35+0x5b/0x5d [i915]
<4> [749.063044] Code: 00 48 c7 c2 a0 23 4e a0 48 c7 c7 26 df 4a a0 e8 95 1d d0 e0 bf 01 00 00 00 e8 8b ec cf e0 31 f6 bf 09 00 00 00 e8 5f 30 c0 e0 <0f> 0b 48 c7 c1 24 4b 56 a0 ba 5b 03 00 00 48 c7 c6 c0 23 4e a0 48 <4> [749.063052] RSP: 0018:ffffc90002ab7d38 EFLAGS: 00010246
<4> [749.063056] RAX: 0000000000000240 RBX: ffff88811f2e61c0 RCX: 0000000000000006
<4> [749.063060] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000009
<4> [749.063063] RBP: ffffc90002ab7e58 R08: 0000000000000001 R09: 0000000000000001
<4> [749.063067] R10: 000000000123d0f8 R11: ffffc90002ab7b20 R12: ffff888112a1a000
<4> [749.063071] R13: 0000000000000004 R14: ffff88811f2e61c0 R15: ffff888112a1a000
<4> [749.063074] FS: 00007f6e5fcad500(0000) GS:ffff8884ad600000(0000) knlGS:0000000000000000
<4> [749.063078] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [749.063081] CR2: 00007efd264e39f0 CR3: 0000000115fd6005 CR4: 00000000003706f0
<4> [749.063085] Call Trace:

<4> [749.063087]  <TASK>
<4> [749.063089]  __assign_mmap_offset+0x41/0x300 [i915]
<4> [749.063171]  __assign_mmap_offset_handle+0x159/0x270 [i915]
<4> [749.063248]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915]
<4> [749.063325]  drm_ioctl_kernel+0xae/0x140
<4> [749.063330]  drm_ioctl+0x201/0x3d0
<4> [749.063333]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915]
<4> [749.063409]  ? do_user_addr_fault+0x200/0x670
<4> [749.063415]  __x64_sys_ioctl+0x6d/0xa0
<4> [749.063419]  do_syscall_64+0x3a/0xb0
<4> [749.063423]  entry_SYSCALL_64_after_hwframe+0x44/0xae

<4> [749.063428] RIP: 0033:0x7f6e5f100317

Testcase: igt@gem_madvise@dontneed-before-mmap

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -1
index 89b70f5cde7a..9f429ed6e78a 100644
@@ -161,7 +161,6 @@ int i915_gem_object_pin_pages_unlocked(struct drm_i915_gem_object *obj)
 /* Immediately discard the backing storage */
 int i915_gem_object_truncate(struct drm_i915_gem_object *obj)
 {
-	drm_gem_free_mmap_offset(&obj->base);
 	if (obj->ops->truncate)
 		return obj->ops->truncate(obj);
 
Signature · 1 line
2.31.1
#1 lore raw

PATCH 2/4 drm/i915/ttm: only fault WILLNEED objects

Don't attempt to fault and re-populate purged objects. By some fluke this passes the dontneed-after-mmap IGT, but for the wrong reasons.

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +5 -0
index 923cc7ad8d70..8d61d4538a64 100644
@@ -883,6 +883,11 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
 	if (ret)
 		return ret;
 
+	if (obj->mm.madv != I915_MADV_WILLNEED) {
+		dma_resv_unlock(bo->base.resv);
+		return VM_FAULT_SIGBUS;
+	}
+
 	if (drm_dev_enter(dev, &idx)) {
 		ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
 					       TTM_BO_VM_NUM_PREFAULT);
Signature · 1 line
2.31.1
Reviewed-by on v1 2/4
#2 lore raw

Re: [PATCH 2/4] drm/i915/ttm: only fault WILLNEED objects

Quoted 6 lines · Matthew Auld

Don't attempt to fault and re-populate purged objects. By some fluke this passes the dontneed-after-mmap IGT, but for the wrong reasons.

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>
Quoted 24 lines

---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++++

 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
index 923cc7ad8d70..8d61d4538a64 100644
@@ -883,6 +883,11 @@ static vm_fault_t vm_fault_ttm(struct vm_fault
 *vmf)
         if (ret)
                 return ret;


+       if (obj->mm.madv != I915_MADV_WILLNEED) {
+               dma_resv_unlock(bo->base.resv);
+               return VM_FAULT_SIGBUS;
+       }
+
        if (drm_dev_enter(dev, &idx)) {
                ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma-

Quoted 1 line

vm_page_prot,


TTM_BO_VM_NUM_PREFAULT);

#3 lore raw

PATCH 3/4 drm/i915/ttm: ensure we unmap when purging

In reply to Matthew Auld

Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object.

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +2 -0
index 8d61d4538a64..f148e7e48f86 100644
@@ -399,6 +399,8 @@ int i915_ttm_purge(struct drm_i915_gem_object *obj)
 	if (obj->mm.madv == __I915_MADV_PURGED)
 		return 0;
 
+	ttm_bo_unmap_virtual(bo);
+
 	ret = ttm_bo_validate(bo, &place, &ctx);
 	if (ret)
 		return ret;
Signature · 1 line
2.31.1
#4 lore raw

Re: [PATCH 3/4] drm/i915/ttm: ensure we unmap when purging

Quoted 20 lines · Matthew Auld

Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object.

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>

---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 ++

 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -0
index 8d61d4538a64..f148e7e48f86 100644
@@ -399,6 +399,8 @@ int i915_ttm_purge(struct drm_i915_gem_object
 *obj)
         if (obj->mm.madv == __I915_MADV_PURGED)
                 return 0;
Quoted 6 lines


+       ttm_bo_unmap_virtual(bo);
+
        ret = ttm_bo_validate(bo, &place, &ctx);
        if (ret)
                return ret;

The swap notifier and the move code both call i915_ttm_move_notify() to achieve this before calling i915_ttm_purge. This ensures both cpu- and gpu ptes are torn down, and also when we extend to dynamic dma-buf exporting, makes sure dma-buf importers unbind.

So I suggest we make a i915_ttm_truncate wrapper function that calls i915_ttm_move_notify() and then ttm_bo_purge(), and use that as the truncate callback as well as from those places we call i915_ttm_purge without a prior call to i915_ttm_move_notify(), which seems to be the ones you've identified in patch 3 and 4,

/Thomas

#5 lore raw

PATCH 4/4 drm/i915/ttm: ensure we unmap when shrinking

In reply to Matthew Auld

Assuming we don't purge the pages, but instead swap them out then we need to ensure we also unmap the object.

Fixes 7ae034590cea ("drm/i915/ttm: add tt shmem backend")
Cc Thomas Hellström <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +2 -0
index f148e7e48f86..adbbd57bb9bf 100644
@@ -462,6 +462,8 @@ static int i915_ttm_shrinker_release_pages(struct drm_i915_gem_object *obj,
 	if (bo->ttm->page_flags & TTM_TT_FLAG_SWAPPED)
 		return 0;
 
+	ttm_bo_unmap_virtual(bo);
+
 	bo->ttm->page_flags |= TTM_TT_FLAG_SWAPPED;
 	ret = ttm_bo_validate(bo, &place, &ctx);
 	if (ret) {
Signature · 1 line
2.31.1
#6 lore raw
In reply to Matthew Auld
Quoted 71 lines · Matthew Auld

The TTM backend is in theory the only user here(also purge should only
be called once we have dropped the pages), where it is setup at object
creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset to determine the page offset within the pages
array.

This also blows up in the dontneed-before-mmap test, since the expectation is that the vma_node will live on, until the object is destroyed:

<2> [749.062902] kernel BUG at drivers/gpu/drm/i915/gem/i915_gem_ttm.c:943!
<4> [749.062923] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI <4> [749.062928] CPU: 0 PID: 1643 Comm: gem_madvise Tainted: G     U W         5.16.0-rc8-CI-CI_DRM_11046+ #1
<4> [749.062933] Hardware name: Gigabyte Technology Co., Ltd. GB-Z390 Garuda/GB-Z390 Garuda-CF, BIOS IG1c 11/19/2019
<4> [749.062937] RIP: 0010:i915_ttm_mmap_offset.cold.35+0x5b/0x5d [i915]
<4> [749.063044] Code: 00 48 c7 c2 a0 23 4e a0 48 c7 c7 26 df 4a a0 e8 95 1d d0 e0 bf 01 00 00 00 e8 8b ec cf e0 31 f6 bf 09 00 00 00 e8 5f 30 c0 e0 <0f> 0b 48 c7 c1 24 4b 56 a0 ba 5b 03 00 00 48 c7 c6 c0 23 4e a0 48
<4> [749.063052] RSP: 0018:ffffc90002ab7d38 EFLAGS: 00010246 <4> [749.063056] RAX: 0000000000000240 RBX: ffff88811f2e61c0 RCX:
0000000000000006
<4> [749.063060] RDX: 0000000000000000 RSI: 0000000000000000 RDI:
0000000000000009
<4> [749.063063] RBP: ffffc90002ab7e58 R08: 0000000000000001 R09:
0000000000000001
<4> [749.063067] R10: 000000000123d0f8 R11: ffffc90002ab7b20 R12:
ffff888112a1a000
<4> [749.063071] R13: 0000000000000004 R14: ffff88811f2e61c0 R15:
ffff888112a1a000
<4> [749.063074] FS:  00007f6e5fcad500(0000) GS:ffff8884ad600000(0000) knlGS:0000000000000000
<4> [749.063078] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [749.063081] CR2: 00007efd264e39f0 CR3: 0000000115fd6005 CR4:
00000000003706f0
<4> [749.063085] Call Trace:
<4> [749.063087]  <TASK>
<4> [749.063089]  __assign_mmap_offset+0x41/0x300 [i915] <4> [749.063171]  __assign_mmap_offset_handle+0x159/0x270 [i915] <4> [749.063248]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063325]  drm_ioctl_kernel+0xae/0x140
<4> [749.063330]  drm_ioctl+0x201/0x3d0
<4> [749.063333]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063409]  ? do_user_addr_fault+0x200/0x670
<4> [749.063415]  __x64_sys_ioctl+0x6d/0xa0
<4> [749.063419]  do_syscall_64+0x3a/0xb0
<4> [749.063423]  entry_SYSCALL_64_after_hwframe+0x44/0xae <4> [749.063428] RIP: 0033:0x7f6e5f100317

Testcase: igt@gem_madvise@dontneed-before-mmap

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>

---
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -0
index 89b70f5cde7a..9f429ed6e78a 100644

drivers/gpu/drm/i915/gem/i915_gem_pages.c int i915_gem_object_pin_pages_unlocked(struct · line 165

Quoted 5 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -1
@@ -161,7 +161,6 @@ int i915_gem_object_pin_pages_unlocked(struct
 drm_i915_gem_object *obj)
  /* Immediately discard the backing storage */
  int i915_gem_object_truncate(struct drm_i915_gem_object *obj)
  {
-       drm_gem_free_mmap_offset(&obj->base);

What happens if a non-ttm shmem system object gets truncated from the shrinker and then tries to use the above mmap offset?

/Thomas

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -0
         if (obj->ops->truncate)
                 return obj->ops->truncate(obj);

#7 lore raw
Quoted 66 lines · Thomas Hellström
Quoted 65 lines · Matthew Auld

The TTM backend is in theory the only user here(also purge should only
be called once we have dropped the pages), where it is setup at object
creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset to determine the page offset within the pages
array.

This also blows up in the dontneed-before-mmap test, since the expectation is that the vma_node will live on, until the object is destroyed:

<2> [749.062902] kernel BUG at drivers/gpu/drm/i915/gem/i915_gem_ttm.c:943!
<4> [749.062923] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI <4> [749.062928] CPU: 0 PID: 1643 Comm: gem_madvise Tainted: G     U W         5.16.0-rc8-CI-CI_DRM_11046+ #1
<4> [749.062933] Hardware name: Gigabyte Technology Co., Ltd. GB-Z390 Garuda/GB-Z390 Garuda-CF, BIOS IG1c 11/19/2019
<4> [749.062937] RIP: 0010:i915_ttm_mmap_offset.cold.35+0x5b/0x5d [i915]
<4> [749.063044] Code: 00 48 c7 c2 a0 23 4e a0 48 c7 c7 26 df 4a a0 e8 95 1d d0 e0 bf 01 00 00 00 e8 8b ec cf e0 31 f6 bf 09 00 00 00 e8 5f 30 c0 e0 <0f> 0b 48 c7 c1 24 4b 56 a0 ba 5b 03 00 00 48 c7 c6 c0 23 4e a0 48
<4> [749.063052] RSP: 0018:ffffc90002ab7d38 EFLAGS: 00010246 <4> [749.063056] RAX: 0000000000000240 RBX: ffff88811f2e61c0 RCX:
0000000000000006
<4> [749.063060] RDX: 0000000000000000 RSI: 0000000000000000 RDI:
0000000000000009
<4> [749.063063] RBP: ffffc90002ab7e58 R08: 0000000000000001 R09:
0000000000000001
<4> [749.063067] R10: 000000000123d0f8 R11: ffffc90002ab7b20 R12:
ffff888112a1a000
<4> [749.063071] R13: 0000000000000004 R14: ffff88811f2e61c0 R15:
ffff888112a1a000
<4> [749.063074] FS:  00007f6e5fcad500(0000) GS:ffff8884ad600000(0000) knlGS:0000000000000000
<4> [749.063078] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [749.063081] CR2: 00007efd264e39f0 CR3: 0000000115fd6005 CR4:
00000000003706f0
<4> [749.063085] Call Trace:
<4> [749.063087]  <TASK>
<4> [749.063089]  __assign_mmap_offset+0x41/0x300 [i915] <4> [749.063171]  __assign_mmap_offset_handle+0x159/0x270 [i915] <4> [749.063248]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063325]  drm_ioctl_kernel+0xae/0x140
<4> [749.063330]  drm_ioctl+0x201/0x3d0
<4> [749.063333]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063409]  ? do_user_addr_fault+0x200/0x670
<4> [749.063415]  __x64_sys_ioctl+0x6d/0xa0
<4> [749.063419]  do_syscall_64+0x3a/0xb0
<4> [749.063423]  entry_SYSCALL_64_after_hwframe+0x44/0xae <4> [749.063428] RIP: 0033:0x7f6e5f100317

Testcase: igt@gem_madvise@dontneed-before-mmap

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Cc Thomas Hellström <[email protected]>
---
  drivers/gpu/drm/i915/gem/i915_gem_pages.c | 1 -
  1 file changed, 1 deletion(-)
Quoted 14 lines

drivers/gpu/drm/i915/gem/i915_gem_pages.c int i915_gem_object_pin_pages_unlocked(struct · line 165

Quoted 11 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -1
index 89b70f5cde7a..9f429ed6e78a 100644
@@ -161,7 +161,6 @@ int i915_gem_object_pin_pages_unlocked(struct
 drm_i915_gem_object *obj)
  /* Immediately discard the backing storage */
  int i915_gem_object_truncate(struct drm_i915_gem_object *obj)
  {
-       drm_gem_free_mmap_offset(&obj->base);

What happens if a non-ttm shmem system object gets truncated from the shrinker and then tries to use the above mmap offset?

AFAIK nothing on integrated is really using this. The mmap_offset ioctl stuff is managing multiple vma nodes itself, per object(one for each cache type/mapping or something), and so doesn't use this. And the shmem mmap ioctl doesn't use the any fake offset stuff, AFAIK.

Quoted 10 lines

/Thomas

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -0
         if (obj->ops->truncate)
                 return obj->ops->truncate(obj);
Reviewed-by
#8 lore raw
Quoted 92 lines · Matthew Auld
Quoted 75 lines · Thomas Hellström
Quoted 74 lines · Matthew Auld

The TTM backend is in theory the only user here(also purge should only
be called once we have dropped the pages), where it is setup at object
creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset to determine the page offset within the
pages
array.

This also blows up in the dontneed-before-mmap test, since the expectation is that the vma_node will live on, until the object is
destroyed:

<2> [749.062902] kernel BUG at drivers/gpu/drm/i915/gem/i915_gem_ttm.c:943!
<4> [749.062923] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI <4> [749.062928] CPU: 0 PID: 1643 Comm: gem_madvise Tainted:
G     U
W         5.16.0-rc8-CI-CI_DRM_11046+ #1
<4> [749.062933] Hardware name: Gigabyte Technology Co., Ltd. GB- Z390
Garuda/GB-Z390 Garuda-CF, BIOS IG1c 11/19/2019
<4> [749.062937] RIP: 0010:i915_ttm_mmap_offset.cold.35+0x5b/0x5d [i915]
<4> [749.063044] Code: 00 48 c7 c2 a0 23 4e a0 48 c7 c7 26 df 4a a0
e8 95 1d d0 e0 bf 01 00 00 00 e8 8b ec cf e0 31 f6 bf 09 00 00 00 e8
5f 30 c0 e0 <0f> 0b 48 c7 c1 24 4b 56 a0 ba 5b 03 00 00 48 c7 c6 c0
23 4e a0 48
<4> [749.063052] RSP: 0018:ffffc90002ab7d38 EFLAGS: 00010246 <4> [749.063056] RAX: 0000000000000240 RBX: ffff88811f2e61c0 RCX:
0000000000000006
<4> [749.063060] RDX: 0000000000000000 RSI: 0000000000000000 RDI:
0000000000000009
<4> [749.063063] RBP: ffffc90002ab7e58 R08: 0000000000000001 R09:
0000000000000001
<4> [749.063067] R10: 000000000123d0f8 R11: ffffc90002ab7b20 R12:
ffff888112a1a000
<4> [749.063071] R13: 0000000000000004 R14: ffff88811f2e61c0 R15:
ffff888112a1a000
<4> [749.063074] FS:  00007f6e5fcad500(0000) GS:ffff8884ad600000(0000) knlGS:0000000000000000
<4> [749.063078] CS:  0010 DS: 0000 ES: 0000 CR0:
0000000080050033
<4> [749.063081] CR2: 00007efd264e39f0 CR3: 0000000115fd6005 CR4:
00000000003706f0
<4> [749.063085] Call Trace:
<4> [749.063087]  <TASK>
<4> [749.063089]  __assign_mmap_offset+0x41/0x300 [i915] <4> [749.063171]  __assign_mmap_offset_handle+0x159/0x270 [i915] <4> [749.063248]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063325]  drm_ioctl_kernel+0xae/0x140
<4> [749.063330]  drm_ioctl+0x201/0x3d0
<4> [749.063333]  ? i915_gem_dumb_mmap_offset+0x70/0x70 [i915] <4> [749.063409]  ? do_user_addr_fault+0x200/0x670
<4> [749.063415]  __x64_sys_ioctl+0x6d/0xa0
<4> [749.063419]  do_syscall_64+0x3a/0xb0
<4> [749.063423]  entry_SYSCALL_64_after_hwframe+0x44/0xae <4> [749.063428] RIP: 0033:0x7f6e5f100317

Testcase: igt@gem_madvise@dontneed-before-mmap

Fixes cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm

bo's.")

Cc Thomas Hellström <[email protected]>

---
  drivers/gpu/drm/i915/gem/i915_gem_pages.c | 1 -

  1 file changed, 1 deletion(-)
Quoted 15 lines

drivers/gpu/drm/i915/gem/i915_gem_pages.c int i915_gem_object_pin_pages_unlocked(struct · line 165

Quoted 11 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -1
index 89b70f5cde7a..9f429ed6e78a 100644
@@ -161,7 +161,6 @@ int i915_gem_object_pin_pages_unlocked(struct
 drm_i915_gem_object *obj)
   /* Immediately discard the backing storage */
   int i915_gem_object_truncate(struct drm_i915_gem_object *obj)
   {
-       drm_gem_free_mmap_offset(&obj->base);

What happens if a non-ttm shmem system object gets truncated from the
shrinker and then tries to use the above mmap offset?

Quoted 6 lines

AFAIK nothing on integrated is really using this. The mmap_offset ioctl
stuff is managing multiple vma nodes itself, per object(one for each cache type/mapping or something), and so doesn't use this. And the shmem
mmap ioctl doesn't use the any fake offset stuff, AFAIK.

OK, then

Quoted 11 lines
Quoted 11 lines

/Thomas

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_pages.c +0 -0
          if (obj->ops->truncate)
                  return obj->ops->truncate(obj);

#9 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: don't call free_mmap_offset when purging

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/4] drm/i915: don't call free_mmap_offset when purging
URL : https://patchwork.freedesktop.org/series/98509/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5198a35603a2 drm/i915: don't call free_mmap_offset when purging
-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#22: 
<4> [749.062928] CPU: 0 PID: 1643 Comm: gem_madvise Tainted: G     U  W         5.16.0-rc8-CI-CI_DRM_11046+ #1

total: 0 errors, 1 warnings, 0 checks, 7 lines checked d478a7195b96 drm/i915/ttm: only fault WILLNEED objects 62769350a16a drm/i915/ttm: ensure we unmap when purging c6d2e5c11332 drm/i915/ttm: ensure we unmap when shrinking

#10 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: don't call free_mmap_offset when purging

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/4] drm/i915: don't call free_mmap_offset when purging
URL : https://patchwork.freedesktop.org/series/98509/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11048 -> Patchwork_21927
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/index.html

Participating hosts (46 -> 37)
------------------------------

Additional (1): fi-icl-u2
Missing (10): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-pnv-d510 bat-rpls-1 fi-bdw-samus bat-jsl-2 bat-jsl-1

Known issues
------------

Here are the changes found in Patchwork_21927 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-hsw-4770/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-kbl-soraka/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][10] ([fdo#109278]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]
- fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([fdo#109285])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#533])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: NOTRUN -> [FAIL][14] ([i915#4547])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][15] ([i915#3301])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][16] ([i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

#### Possible fixes ####

* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [INCOMPLETE][17] ([i915#4547]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/fi-skl-6600u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-skl-6600u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][19] ([i915#3303]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/fi-hsw-4770/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/fi-hsw-4770/igt@i915_selftest@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* Linux: CI_DRM_11048 -> Patchwork_21927

CI-20190529: 20190529
CI_DRM_11048: a5532aab7c6ca334d0469d237a8c3cd4731917dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6323: 9dbaa0d5be7a859cda9b7d54c20ba96a596f43bd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21927: c6d2e5c11332ff3cdf7fefad21997434e5bbb7b9 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c6d2e5c11332 drm/i915/ttm: ensure we unmap when shrinking 62769350a16a drm/i915/ttm: ensure we unmap when purging d478a7195b96 drm/i915/ttm: only fault WILLNEED objects 5198a35603a2 drm/i915: don't call free_mmap_offset when purging

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/index.html

#11 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: don't call free_mmap_offset when purging

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/4] drm/i915: don't call free_mmap_offset when purging
URL : https://patchwork.freedesktop.org/series/98509/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11048_full -> Patchwork_21927_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_21927_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_21927_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (13 -> 13)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_21927_full:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl8/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_whisper@basic-fds-priority-all:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-rkl-5/igt@[email protected]

* igt@gem_exec_whisper@basic-forked-all:
- {shard-rkl}: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-rkl-1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-rkl-5/igt@[email protected]

* igt@gem_mmap_gtt@close-race:
- {shard-dg1}: NOTRUN -> [SKIP][6] +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-dg1-15/igt@[email protected]

* igt@i915_pm_dc@dc5-psr:
- {shard-tglu}: NOTRUN -> [SKIP][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-7/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- {shard-dg1}: [PASS][8] -> [FAIL][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-dg1-19/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-dg1-15/igt@[email protected]

* igt@prime_busy@hang-wait@bcs0:
- {shard-tglu}: NOTRUN -> [DMESG-WARN][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-7/igt@prime_busy@[email protected]

* igt@prime_busy@hang-wait@vcs0:
- {shard-tglu}: NOTRUN -> [INCOMPLETE][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-7/igt@prime_busy@[email protected]

* igt@prime_busy@hang@bcs0:
- {shard-tglu}: [PASS][12] -> [INCOMPLETE][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-2/igt@prime_busy@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-7/igt@prime_busy@[email protected]

* igt@runner@aborted:
- {shard-tglu}: ([FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17]) ([i915#3002] / [i915#3690] / [i915#4312]) -> ([FAIL][18], [FAIL][19], [FAIL][20]) ([i915#3002] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-8/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-5/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-3/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_21927_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][21] ([i915#3002])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl4/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-skl: [PASS][22] -> [TIMEOUT][23] ([i915#3063])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl9/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [PASS][24] -> [TIMEOUT][25] ([i915#3063])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#232]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb5/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][28] -> [SKIP][29] ([i915#4525]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb4/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@gem_exec_endless@dispatch@bcs0:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([i915#3778])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb1/igt@gem_exec_endless@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb5/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][32] -> [FAIL][33] ([i915#2842])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk8/igt@gem_exec_fair@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][34] -> [FAIL][35] ([i915#2842])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-kbl1/igt@gem_exec_fair@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][36] ([i915#2842]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_schedule@submit-early-slice@vcs0:
- shard-tglb: [PASS][37] -> [INCOMPLETE][38] ([i915#3797])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb7/igt@gem_exec_schedule@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb6/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_whisper@basic-queues-forked:
- shard-iclb: [PASS][39] -> [INCOMPLETE][40] ([i915#1895])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb3/igt@[email protected]

* igt@gem_lmem_swapping@heavy-multi:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#4613]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify:
- shard-glk: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#4613])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#4613])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][44] ([i915#2658])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl8/igt@[email protected]

* igt@gem_pxp@display-protected-crc:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#4270])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-apl1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl6/igt@[email protected]

* igt@gen7_exec_parse@basic-allocation:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271]) +10 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl1/igt@[email protected]

* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109289]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][50] -> [DMESG-WARN][51] ([i915#1436] / [i915#716])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl3/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl9/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- shard-iclb: NOTRUN -> [SKIP][52] ([i915#2856])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][53] -> [FAIL][54] ([i915#454])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb3/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][55] ([i915#1886] / [i915#2291])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl8/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@mock@requests:
- shard-skl: [PASS][56] -> [INCOMPLETE][57] ([i915#4919])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl5/igt@i915_selftest@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl2/igt@i915_selftest@[email protected]

* igt@i915_selftest@perf@region:
- shard-tglb: [PASS][58] -> [DMESG-WARN][59] ([i915#2867])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb6/igt@i915_selftest@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb8/igt@i915_selftest@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][60] -> [FAIL][61] ([i915#2521])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl9/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl5/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [PASS][62] -> [DMESG-WARN][63] ([i915#118]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk3/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][64] ([i915#3743]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#3777]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl4/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#110723]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#3886]) +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [i915#3886]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3886])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3886]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl3/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3886])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271]) +124 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl10/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +9 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl4/igt@[email protected]

* igt@kms_chamelium@hdmi-mode-timings:
- shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271] / [fdo#111827])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-gamma:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109278] / [fdo#109279]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271]) +16 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271]) +38 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl3/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][81] -> [FAIL][82] ([i915#2346])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb7/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#533])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl4/igt@[email protected]

* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-skl: [PASS][84] -> [DMESG-WARN][85] ([i915#1982])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl6/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl5/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html

* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [PASS][86] -> [DMESG-WARN][87] ([i915#2411] / [i915#2867])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglb6/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglb8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-dpms:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109274])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][89] -> [FAIL][90] ([i915#79])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl6/igt@kms_flip@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][91] ([i915#180]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: NOTRUN -> [FAIL][92] ([i915#2122])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@wf_vblank-ts-check-interruptible@a-edp1:
- shard-skl: [PASS][93] -> [FAIL][94] ([i915#2122]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl10/igt@kms_flip@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][95] -> [FAIL][96] ([i915#4911])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [PASS][97] -> [SKIP][98] ([i915#3701])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109280]) +7 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][100] -> [DMESG-WARN][101] ([i915#180]) +4 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-kbl1/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl1/igt@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][102] -> [FAIL][103] ([i915#1188])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl10/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][104] ([fdo#108145] / [i915#265]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][106] -> [FAIL][107] ([fdo#108145] / [i915#265])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-skl1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2733])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#658])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-skl6/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109441])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][111] -> [SKIP][112] ([fdo#109441]) +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][113] -> [FAIL][114] ([i915#31])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk6/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk3/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][115] -> [DMESG-WARN][116] ([i915#180] / [i915#295])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-apl4/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl3/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][117] ([fdo#109278]) +8 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb8/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#533])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#533])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl1/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-kbl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl4/igt@[email protected]

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][121] ([i915#658]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb2/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [DMESG-WARN][123] ([i915#180]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-apl6/igt@gem_ctx_isolation@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-apl1/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][125] ([i915#2481] / [i915#3070]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-iclb6/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: [FAIL][127] ([i915#2842]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk3/igt@gem_exec_fair@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][129] ([i915#2842]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-kbl7/igt@gem_exec_fair@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][131] ([i915#2842]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-3/igt@gem_exec_fair@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_schedule@submit-golden-slice@vcs1:
- {shard-tglu}: [INCOMPLETE][133] ([i915#3797]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-7/igt@gem_exec_schedule@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-2/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_suspend@basic@smem:
- {shard-tglu}: [FAIL][135] ([i915#1888]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-2/igt@gem_exec_suspend@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-7/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [DMESG-WARN][137] ([i915#118]) -> [PASS][138] +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk2/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk7/igt@[email protected]

* igt@gem_madvise@dontneed-before-mmap:
- {shard-dg1}: [INCOMPLETE][139] -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-dg1-17/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-dg1-18/igt@[email protected]

* igt@gem_spin_batch@user-each:
- {shard-tglu}: [DMESG-WARN][141] -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-tglu-7/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-tglu-3/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][143] ([i915#1436] / [i915#716]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11048/shard-glk9/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/shard-glk1/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][145] ([i915#1397]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.or

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21927/index.html