Skip to contentSkip to conversation

net: phy: realtek: fix handling of RTL8105e-integrated PHY

PATCH In review Heiner Kallweit 2 participants 2 messages Apr 7, 2020 – Apr 8, 2020

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: realtek: fix handling of RTL8105e-integrated PHY

After the referenced fix it turned out that one particular RTL8168 chip version (RTL8105e) does not work on 5.4 because no dedicated PHY driver exists. Adding this PHY driver was done for fixing a different issue for versions from 5.5 already. I re-send the same change for 5.4 because the commit message differs.

Fixes 2e8c339b4946 ("r8169: fix PHY driver check on platforms w/o module softdeps")

---
Please apply on 5.4 only.

---
 drivers/net/phy/realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/net/phy/realtek.c +9 -0
index c76df51dd..879ca37c8 100644
@@ -456,6 +456,15 @@ static struct phy_driver realtek_drvs[] = {
 		.resume		= genphy_resume,
 		.read_page	= rtl821x_read_page,
 		.write_page	= rtl821x_write_page,
+	}, {
+		PHY_ID_MATCH_MODEL(0x001cc880),
+		.name		= "RTL8208 Fast Ethernet",
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
+		.suspend	= genphy_suspend,
+		.resume		= genphy_resume,
+		.read_page	= rtl821x_read_page,
+		.write_page	= rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc910),
 		.name		= "RTL8211 Gigabit Ethernet",
Signature · 1 line
2.26.0
maintainer
#1 lore raw

From: Heiner Kallweit <[email protected]>
Date: Wed, 8 Apr 2020 00:01:42 +0200

Quoted 10 lines

After the referenced fix it turned out that one particular RTL8168 chip version (RTL8105e) does not work on 5.4 because no dedicated PHY driver exists. Adding this PHY driver was done for fixing a different issue for versions from 5.5 already. I re-send the same change for 5.4 because the commit message differs.

Fixes 2e8c339b4946 ("r8169: fix PHY driver check on platforms w/o module softdeps")

---
Please apply on 5.4 only.

I'll queue this up, thanks.