accel/qaic: mark debugfs stub functions as static inline
Subsystems (3)
PATCH 1/1 accel/qaic: mark debugfs stub functions as static inline
From: Arnd Bergmann <[email protected]>
The alternative stub functions are listed as global, which produces a build failure in some configs:
In file included from drivers/accel/qaic/qaic_drv.c:31:drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]
16 | int qaic_bootlog_register(void) { return 0; }
| ^~~~~~~~~~~~~~~~~~~~~
drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes]
17 | void qaic_bootlog_unregister(void) {}
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes]
18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
| ^~~~~~~~~~~~~~~~~Make them static inline as intended.
--- drivers/accel/qaic/qaic_debugfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/accel/qaic/qaic_debugfs.h +3 -3
@@ -13,8 +13,8 @@ int qaic_bootlog_register(void);void qaic_bootlog_unregister (void );void qaic_debugfs_init (struct qaic_drm_device *qddev);#else -int qaic_bootlog_register (void ) {return 0 ; } -void qaic_bootlog_unregister (void ) {} -void qaic_debugfs_init (struct qaic_drm_device *qddev) {} +static inline int qaic_bootlog_register (void ) {return 0 ; } +static inline void qaic_bootlog_unregister (void ) {} +static inline void qaic_debugfs_init (struct qaic_drm_device *qddev) {}#endif /* CONFIG_DEBUG_FS */ #endif /* __QAIC_DEBUGFS_H__ */
Signature · 1 line
2.39.2
Quoted 16 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The alternative stub functions are listed as global, which produces a build failure in some configs:
In file included from
drivers/accel/qaic/qaic_drv.c:31:drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]16 | int qaic_bootlog_register(void) { return 0; } | ^~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes] 17 | void qaic_bootlog_unregister(void) {} | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes] 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {} | ^~~~~~~~~~~~~~~~~
Quoted 4 lines
Make them static inline as intended.
Fixes 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")Signed-off-by Arnd Bergmann <[email protected]>
Doh. Thank you for addressing this so quickly.
Jeffrey Hugo
AppliedQuoted 16 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The alternative stub functions are listed as global, which produces a build failure in some configs:
In file included from
drivers/accel/qaic/qaic_drv.c:31:drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]16 | int qaic_bootlog_register(void) { return 0; } | ^~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes] 17 | void qaic_bootlog_unregister(void) {} | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes] 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {} | ^~~~~~~~~~~~~~~~~
Quoted 4 lines
Make them static inline as intended.
Fixes 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")Signed-off-by Arnd Bergmann <[email protected]>
Pushed to drm-misc-next
-Jeff