Move runnable examples code from Documentation to samples
Subsystems (5)
cover Move runnable examples code from Documentation to samples
Move runnable examples code from Documentation to samples. I moved just the example code, and left documentation files as is.
blackfin gptimers example code needs a bit of special handling since it is a module. I will address it in a separate patch. 00-Index files need to be updated due to this move which will be done another patch.
Shuah Khan (8):
samples: move accounting example code from Documentation
samples: move auxdisplay example code from Documentation
samples: move laptops example code from Documentation
samples: move mic/mpssd example code from Documentation
samples: move misc-devices/mei example code from Documentation
samples: move pcmcia example code from Documentation
samples: move timers example code from Documentation
samples: move watchdog example code from Documentation
Documentation/Makefile | 3 +- Documentation/accounting/.gitignore | 1 - Documentation/accounting/Makefile | 7 - Documentation/accounting/getdelays.c | 550 ------- Documentation/auxdisplay/.gitignore | 1 - Documentation/auxdisplay/Makefile | 7 - Documentation/auxdisplay/cfag12864b-example.c | 281 ---- Documentation/laptops/.gitignore | 1 - Documentation/laptops/Makefile | 5 - Documentation/laptops/dslm.c | 166 -- Documentation/mic/Makefile | 1 - Documentation/mic/mpssd/.gitignore | 1 - Documentation/mic/mpssd/Makefile | 21 - Documentation/mic/mpssd/micctrl | 173 -- Documentation/mic/mpssd/mpss | 200 --- Documentation/mic/mpssd/mpssd.c | 1826 ---------------------- Documentation/mic/mpssd/mpssd.h | 103 -- Documentation/mic/mpssd/sysfs.c | 102 -- Documentation/misc-devices/Makefile | 1 - Documentation/misc-devices/mei/.gitignore | 1 - Documentation/misc-devices/mei/Makefile | 5 - Documentation/misc-devices/mei/TODO | 2 - Documentation/misc-devices/mei/mei-amt-version.c | 479 ------ Documentation/pcmcia/.gitignore | 1 - Documentation/pcmcia/Makefile | 7 - Documentation/pcmcia/crc32hash.c | 32 - Documentation/timers/.gitignore | 1 - Documentation/timers/Makefile | 5 - Documentation/timers/hpet_example.c | 294 ---- Documentation/watchdog/Makefile | 1 - Documentation/watchdog/src/.gitignore | 1 - Documentation/watchdog/src/Makefile | 5 - Documentation/watchdog/src/watchdog-simple.c | 24 - samples/accounting/.gitignore | 1 + samples/accounting/Makefile | 9 + samples/accounting/getdelays.c | 550 +++++++ samples/auxdisplay/.gitignore | 1 + samples/auxdisplay/Makefile | 9 + samples/auxdisplay/cfag12864b-example.c | 281 ++++ samples/laptops/.gitignore | 1 + samples/laptops/Makefile | 9 + samples/laptops/dslm.c | 166 ++ samples/mei/.gitignore | 1 + samples/mei/Makefile | 9 + samples/mei/TODO | 2 + samples/mei/mei-amt-version.c | 479 ++++++ samples/mic/mpssd/.gitignore | 1 + samples/mic/mpssd/Makefile | 27 + samples/mic/mpssd/micctrl | 173 ++ samples/mic/mpssd/mpss | 200 +++ samples/mic/mpssd/mpssd.c | 1826 ++++++++++++++++++++++ samples/mic/mpssd/mpssd.h | 103 ++ samples/mic/mpssd/sysfs.c | 102 ++ samples/pcmcia/.gitignore | 1 + samples/pcmcia/Makefile | 9 + samples/pcmcia/crc32hash.c | 32 + samples/timers/.gitignore | 1 + samples/timers/Makefile | 15 + samples/timers/hpet_example.c | 294 ++++ samples/watchdog/.gitignore | 1 + samples/watchdog/Makefile | 8 + samples/watchdog/watchdog-simple.c | 24 + 62 files changed, 4336 insertions(+), 4307 deletions(-) delete mode 100644 Documentation/accounting/.gitignore delete mode 100644 Documentation/accounting/Makefile delete mode 100644 Documentation/accounting/getdelays.c delete mode 100644 Documentation/auxdisplay/.gitignore delete mode 100644 Documentation/auxdisplay/Makefile delete mode 100644 Documentation/auxdisplay/cfag12864b-example.c delete mode 100644 Documentation/laptops/.gitignore delete mode 100644 Documentation/laptops/Makefile delete mode 100644 Documentation/laptops/dslm.c delete mode 100644 Documentation/mic/Makefile delete mode 100644 Documentation/mic/mpssd/.gitignore delete mode 100644 Documentation/mic/mpssd/Makefile delete mode 100755 Documentation/mic/mpssd/micctrl delete mode 100755 Documentation/mic/mpssd/mpss delete mode 100644 Documentation/mic/mpssd/mpssd.c delete mode 100644 Documentation/mic/mpssd/mpssd.h delete mode 100644 Documentation/mic/mpssd/sysfs.c delete mode 100644 Documentation/misc-devices/Makefile delete mode 100644 Documentation/misc-devices/mei/.gitignore delete mode 100644 Documentation/misc-devices/mei/Makefile delete mode 100644 Documentation/misc-devices/mei/TODO delete mode 100644 Documentation/misc-devices/mei/mei-amt-version.c delete mode 100644 Documentation/pcmcia/.gitignore delete mode 100644 Documentation/pcmcia/Makefile delete mode 100644 Documentation/pcmcia/crc32hash.c delete mode 100644 Documentation/timers/.gitignore delete mode 100644 Documentation/timers/Makefile delete mode 100644 Documentation/timers/hpet_example.c delete mode 100644 Documentation/watchdog/Makefile delete mode 100644 Documentation/watchdog/src/.gitignore delete mode 100644 Documentation/watchdog/src/Makefile delete mode 100644 Documentation/watchdog/src/watchdog-simple.c create mode 100644 samples/accounting/.gitignore create mode 100644 samples/accounting/Makefile create mode 100644 samples/accounting/getdelays.c create mode 100644 samples/auxdisplay/.gitignore create mode 100644 samples/auxdisplay/Makefile create mode 100644 samples/auxdisplay/cfag12864b-example.c create mode 100644 samples/laptops/.gitignore create mode 100644 samples/laptops/Makefile create mode 100644 samples/laptops/dslm.c create mode 100644 samples/mei/.gitignore create mode 100644 samples/mei/Makefile create mode 100644 samples/mei/TODO create mode 100644 samples/mei/mei-amt-version.c create mode 100644 samples/mic/mpssd/.gitignore create mode 100644 samples/mic/mpssd/Makefile create mode 100755 samples/mic/mpssd/micctrl create mode 100755 samples/mic/mpssd/mpss create mode 100644 samples/mic/mpssd/mpssd.c create mode 100644 samples/mic/mpssd/mpssd.h create mode 100644 samples/mic/mpssd/sysfs.c create mode 100644 samples/pcmcia/.gitignore create mode 100644 samples/pcmcia/Makefile create mode 100644 samples/pcmcia/crc32hash.c create mode 100644 samples/timers/.gitignore create mode 100644 samples/timers/Makefile create mode 100644 samples/timers/hpet_example.c create mode 100644 samples/watchdog/.gitignore create mode 100644 samples/watchdog/Makefile create mode 100644 samples/watchdog/watchdog-simple.c
Signature · 1 line
2.7.4
PATCH 1/8 samples: move accounting example code from Documentation
Move accounting examples to samples and remove it from Documentation Makefile. Create a new Makefile to build accounting. It can be built from top level directory or from accounting directory:
Run make -C samples/accounting or cd samples/accounting; make
--- Documentation/Makefile | 2 +- Documentation/accounting/.gitignore | 1 - Documentation/accounting/Makefile | 7 - Documentation/accounting/getdelays.c | 550 ----------------------------------- samples/accounting/.gitignore | 1 + samples/accounting/Makefile | 9 + samples/accounting/getdelays.c | 550 +++++++++++++++++++++++++++++++++++ 7 files changed, 561 insertions(+), 559 deletions(-) delete mode 100644 Documentation/accounting/.gitignore delete mode 100644 Documentation/accounting/Makefile delete mode 100644 Documentation/accounting/getdelays.c create mode 100644 samples/accounting/.gitignore create mode 100644 samples/accounting/Makefile create mode 100644 samples/accounting/getdelays.c
Documentation/Makefile +1 -1
@@ -1,2 +1,2 @@ -subdir-y := accounting auxdisplay blackfin \ +subdir-y := auxdisplay blackfin \ laptops mic misc-devices pcmcia timers watchdog
Documentation/accounting/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -getdelays
Documentation/accounting/Makefile deleted +0 -7
@@ -1,7 +0,0 @@ -# List of programs to build -hostprogs-y := getdelays - -# Tell kbuild to always build the programs -always := $(hostprogs-y) - -HOSTCFLAGS_getdelays.o += -I$(objtree)/usr/include
Documentation/accounting/getdelays.c deleted +0 -550
550 lines not on this page · raw message
samples/accounting/.gitignore new file +1 -0
@@ -0,0 +1 @@ +getdelays
samples/accounting/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +CC := $(CROSS_COMPILE)gcc +CFLAGS := -I../../usr/include + +PROGS := getdelays + +all: $(PROGS) + +clean: + rm -fr $(PROGS)
samples/accounting/getdelays.c new file +550 -0
550 lines not on this page · raw message
Signature · 1 line
2.7.4
Jonathan Corbet
maintainerRe: [PATCH 1/8] samples: move accounting example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:32 -0600 Shuah Khan <[email protected]> wrote:
Move accounting examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build accounting. It can be built from top level directory or from accounting directory:
So I like the basic idea of these patches; it's the direction we've been trying to push things for a little bit. I have a couple of specific comments for this one that may well apply to the others as well.
1) Is samples the right destination for these utilities? Some of them might well be better placed under tools/ instead. I'm not sure we've ever formally stated the purpose of those two subtrees; I see samples/ as demonstrations of how to use something, while tools/ are utilities you might actually want to use for some purpose. Something like getdelays might well fall into the latter group. But maybe others disagree?
2) Tools like getdelays are referenced in the documents that have been left behind; see accounting/delay-accounting.txt, for example. Those documents should be updated so that readers know where to find the referenced programs, wherever they end up. Converting them to Sphinx while you're at it is an extra-credit exercise :)
Thanks,
jon
Re: [PATCH 1/8] samples: move accounting example code from Documentation
Quoted 11 lines · Jonathan Corbet
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:32 -0600 Shuah Khan <[email protected]> wrote:
Move accounting examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build accounting. It can be built from top level directory or from accounting directory:So I like the basic idea of these patches; it's the direction we've been trying to push things for a little bit. I have a couple of specific comments for this one that may well apply to the others as well.
Quoted 7 lines
1) Is samples the right destination for these utilities? Some of them might well be better placed under
tools/instead. I'm not sure we've ever formally stated the purpose of those two subtrees; I seesamples/as demonstrations of how to use something, whiletools/are utilities you might actually want to use for some purpose. Something like getdelays might well fall into the latter group. But maybe others disagree?
getdelays stumped me a bit. My first choice was tools and then I noticed that the documentation says it is a tool and an example usage of taskstruct. I am not set on tools or samples as location for this. I can move it to tools instead.
Quoted 6 lines
2) Tools like getdelays are referenced in the documents that have been left behind; see
accounting/delay-accounting.txt, for example. Those documents should be updated so that readers know where to find the referenced programs, wherever they end up. Converting them to Sphinx while you're at it is an extra-credit exercise :)
Right. Documents need updates and also the 00-Index files. I agree with you that converting to Sphinx makes sense. There will be some learning curve on my part. I can take this one once the move happens and do the Documentation and 00-Index file updates.
thanks,
-- Shuah
PATCH 2/8 samples: move auxdisplay example code from Documentation
In reply to Shuah KhanMove auxdisplay examples to samples and remove it from Documentation Makefile. Create a new Makefile to build auxdisplay. It can be built from top level directory or from auxdisplay directory:
Run make -C samples/auxdisplay or cd samples/auxdisplay; make
--- Documentation/Makefile | 3 +- Documentation/auxdisplay/.gitignore | 1 - Documentation/auxdisplay/Makefile | 7 - Documentation/auxdisplay/cfag12864b-example.c | 281 -------------------------- samples/auxdisplay/.gitignore | 1 + samples/auxdisplay/Makefile | 9 + samples/auxdisplay/cfag12864b-example.c | 281 ++++++++++++++++++++++++++ 7 files changed, 292 insertions(+), 291 deletions(-) delete mode 100644 Documentation/auxdisplay/.gitignore delete mode 100644 Documentation/auxdisplay/Makefile delete mode 100644 Documentation/auxdisplay/cfag12864b-example.c create mode 100644 samples/auxdisplay/.gitignore create mode 100644 samples/auxdisplay/Makefile create mode 100644 samples/auxdisplay/cfag12864b-example.c
Documentation/Makefile +1 -2
@@ -1,2 +1 @@ -subdir-y := auxdisplay blackfin \ - laptops mic misc-devices pcmcia timers watchdog +subdir-y := blackfin laptops mic misc-devices pcmcia timers watchdog
Documentation/auxdisplay/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -cfag12864b-example
Documentation/auxdisplay/Makefile deleted +0 -7
@@ -1,7 +0,0 @@ -# List of programs to build -hostprogs-y := cfag12864b-example - -# Tell kbuild to always build the programs -always := $(hostprogs-y) - -HOSTCFLAGS_cfag12864b-example.o += -I$(objtree)/usr/include
Documentation/auxdisplay/cfag12864b-example.c deleted +0 -281
281 lines not on this page · raw message
samples/auxdisplay/.gitignore new file +1 -0
@@ -0,0 +1 @@ +cfag12864b-example
samples/auxdisplay/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +CC := $(CROSS_COMPILE)gcc +CFLAGS := -I../../usr/include + +PROGS := cfag12864b-example + +all: $(PROGS) + +clean: + rm -fr $(PROGS)
samples/auxdisplay/cfag12864b-example.c new file +281 -0
281 lines not on this page · raw message
Signature · 1 line
2.7.4
Jonathan Corbet
maintainerRe: [PATCH 2/8] samples: move auxdisplay example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:33 -0600 Shuah Khan <[email protected]> wrote:
Move auxdisplay examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build auxdisplay. It can be built from top level directory or from auxdisplay directory:
Documentation/auxdisplay/cfag12864b needs to be updated to reflect the new home for the program (which probably does belong in samples/).
I wonder if these programs need MAINTAINERS entries too?
jon
Re: samples: move auxdisplay example code from Documentation
Quoted 4 lines
Documentation/auxdisplay/cfag12864bneeds to be updated to reflect the new home for the program (which probably does belong insamples/).I wonder if these programs need
MAINTAINERSentries too?
Do you find any more update suggestions interesting around this software module?
https://patchwork.kernel.org/project/LKML/list/?q=cfag12864b
Regards,
Markus
Re: [PATCH 2/8] samples: move auxdisplay example code from Documentation
In reply to Jonathan CorbetQuoted 7 lines · Jonathan Corbet
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:33 -0600 Shuah Khan <[email protected]> wrote:
Move auxdisplay examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build auxdisplay. It can be built from top level directory or from auxdisplay directory:
Quoted 7 lines
Documentation/auxdisplay/cfag12864bneeds to be updated to reflect the new home for the program (which probably does belong insamples/).I wonder if these programs need
MAINTAINERSentries too?jon
I will make sure Documentation and MAINTAINERS update happens in v2 patch for this change.
thanks,
-- Shuah
PATCH 3/8 samples: move laptops example code from Documentation
In reply to Shuah KhanMove laptops examples to samples and remove it from Documentation Makefile. Create a new Makefile to build laptops. It can be built from top level directory or from laptops directory:
Run make -C samples/laptops or cd samples/laptops; make
--- Documentation/Makefile | 2 +- Documentation/laptops/.gitignore | 1 - Documentation/laptops/Makefile | 5 -- Documentation/laptops/dslm.c | 166 --------------------------------------- samples/laptops/.gitignore | 1 + samples/laptops/Makefile | 9 +++ samples/laptops/dslm.c | 166 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 177 insertions(+), 173 deletions(-) delete mode 100644 Documentation/laptops/.gitignore delete mode 100644 Documentation/laptops/Makefile delete mode 100644 Documentation/laptops/dslm.c create mode 100644 samples/laptops/.gitignore create mode 100644 samples/laptops/Makefile create mode 100644 samples/laptops/dslm.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin laptops mic misc-devices pcmcia timers watchdog +subdir-y := blackfin mic misc-devices pcmcia timers watchdog
Documentation/laptops/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -dslm
Documentation/laptops/Makefile deleted +0 -5
@@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-y := dslm - -# Tell kbuild to always build the programs -always := $(hostprogs-y)
Documentation/laptops/dslm.c deleted +0 -166
166 lines not on this page · raw message
samples/laptops/.gitignore new file +1 -0
@@ -0,0 +1 @@ +dslm
samples/laptops/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +CC := $(CROSS_COMPILE)gcc +CFLAGS := -I../../usr/include + +PROGS := dslm + +all: $(PROGS) + +clean: + rm -fr $(PROGS)
samples/laptops/dslm.c new file +166 -0
166 lines not on this page · raw message
Signature · 1 line
2.7.4
Jonathan Corbet
maintainerRe: [PATCH 3/8] samples: move laptops example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:34 -0600 Shuah Khan <[email protected]> wrote:
Move laptops examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build laptops. It can be built from top level directory or from laptops directory:
This one might be better called a "tool" rather than a "sample" - assuming it actually still works, of course. It hasn't seen a real update in the Git era, which is a bit disconcerting. Is it possible that this is dead code that we might want to just get rid of?
If it stays, Documentation/laptops/laptop-mode.txt needs an update.
jon
Re: [PATCH 3/8] samples: move laptops example code from Documentation
Quoted 11 lines · Jonathan Corbet
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:34 -0600 Shuah Khan <[email protected]> wrote:
Move laptops examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build laptops. It can be built from top level directory or from laptops directory:This one might be better called a "tool" rather than a "sample" - assuming it actually still works, of course. It hasn't seen a real update in the Git era, which is a bit disconcerting. Is it possible that this is dead code that we might want to just get rid of?
I can send a removal patch and see if anybody objects. :)
Quoted 2 lines
If it stays,
Documentation/laptops/laptop-mode.txtneeds an update.
Right. Looks like I missed Documentation updates for these moves. I get that done in v2.
thanks,
-- Shuah
PATCH 4/8 samples: move mic/mpssd example code from Documentation
In reply to Shuah KhanMove mic/mpssd examples to samples and remove it from Documentation Makefile. Create a new Makefile to build mic/mpssd. It can be built from top level directory or from mic/mpssd directory:
Run make -C samples/mic/mpssd or cd samples/mic/mpssd; make
--- Documentation/Makefile | 2 +- Documentation/mic/Makefile | 1 - Documentation/mic/mpssd/.gitignore | 1 - Documentation/mic/mpssd/Makefile | 21 - Documentation/mic/mpssd/micctrl | 173 ---- Documentation/mic/mpssd/mpss | 200 ---- Documentation/mic/mpssd/mpssd.c | 1826 ------------------------------------ Documentation/mic/mpssd/mpssd.h | 103 -- Documentation/mic/mpssd/sysfs.c | 102 -- samples/mic/mpssd/.gitignore | 1 + samples/mic/mpssd/Makefile | 27 + samples/mic/mpssd/micctrl | 173 ++++ samples/mic/mpssd/mpss | 200 ++++ samples/mic/mpssd/mpssd.c | 1826 ++++++++++++++++++++++++++++++++++++ samples/mic/mpssd/mpssd.h | 103 ++ samples/mic/mpssd/sysfs.c | 102 ++ 16 files changed, 2433 insertions(+), 2428 deletions(-) delete mode 100644 Documentation/mic/Makefile delete mode 100644 Documentation/mic/mpssd/.gitignore delete mode 100644 Documentation/mic/mpssd/Makefile delete mode 100755 Documentation/mic/mpssd/micctrl delete mode 100755 Documentation/mic/mpssd/mpss delete mode 100644 Documentation/mic/mpssd/mpssd.c delete mode 100644 Documentation/mic/mpssd/mpssd.h delete mode 100644 Documentation/mic/mpssd/sysfs.c create mode 100644 samples/mic/mpssd/.gitignore create mode 100644 samples/mic/mpssd/Makefile create mode 100755 samples/mic/mpssd/micctrl create mode 100755 samples/mic/mpssd/mpss create mode 100644 samples/mic/mpssd/mpssd.c create mode 100644 samples/mic/mpssd/mpssd.h create mode 100644 samples/mic/mpssd/sysfs.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin mic misc-devices pcmcia timers watchdog +subdir-y := blackfin misc-devices pcmcia timers watchdog
Documentation/mic/Makefile deleted +0 -1
@@ -1 +0,0 @@ -subdir-y := mpssd
Documentation/mic/mpssd/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -mpssd
Documentation/mic/mpssd/Makefile deleted +0 -21
@@ -1,21 +0,0 @@ -ifndef CROSS_COMPILE -# List of programs to build -hostprogs-$(CONFIG_X86_64) := mpssd - -mpssd-objs := mpssd.o sysfs.o - -# Tell kbuild to always build the programs -always := $(hostprogs-y) - -HOSTCFLAGS += -I$(objtree)/usr/include -I$(srctree)/tools/include - -ifdef DEBUG -HOSTCFLAGS += -DDEBUG=$(DEBUG) -endif - -HOSTLOADLIBES_mpssd := -lpthread - -install: - install mpssd /usr/sbin/mpssd - install micctrl /usr/sbin/micctrl -endif
Documentation/mic/mpssd/micctrl deleted +0 -173
173 lines not on this page · raw message
Documentation/mic/mpssd/mpss deleted +0 -200
200 lines not on this page · raw message
Documentation/mic/mpssd/mpssd.c deleted +0 -1826
1,826 lines not on this page · raw message
Documentation/mic/mpssd/mpssd.h deleted +0 -103
103 lines not on this page · raw message
Documentation/mic/mpssd/sysfs.c deleted +0 -102
102 lines not on this page · raw message
samples/mic/mpssd/.gitignore new file +1 -0
@@ -0,0 +1 @@ +mpssd
samples/mic/mpssd/Makefile new file +27 -0
@@ -0,0 +1,27 @@ +ifndef CROSS_COMPILE +uname_M := $(shell uname -m 2>/dev/null || echo not) +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) + +ifeq ($(ARCH),x86) + +PROGS := mpssd +CC = $(CROSS_COMPILE)gcc +CFLAGS := -I../../../usr/include -I../../../tools/include + +ifdef DEBUG +CFLAGS += -DDEBUG=$(DEBUG) +endif + +all: $(PROGS) +mpssd: mpssd.c sysfs.c + $(CC) $(CFLAGS) mpssd.c sysfs.c -o mpssd -lpthread + +install: + install mpssd /usr/sbin/mpssd + install micctrl /usr/sbin/micctrl + +clean: + rm -fr $(PROGS) + +endif +endif
samples/mic/mpssd/micctrl new file +173 -0
173 lines not on this page · raw message
samples/mic/mpssd/mpss new file +200 -0
200 lines not on this page · raw message
samples/mic/mpssd/mpssd.c new file +1826 -0
170 lines not on this page · raw message
samples/mic/mpssd/mpssd.h new file +103 -0
103 lines not on this page · raw message
samples/mic/mpssd/sysfs.c new file +102 -0
102 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.7.4
Part of the diff is not shown here. View the raw message.
Re: [PATCH 4/8] samples: move mic/mpssd example code from Documentation
Quoted 5 lines · On Mon, 19 Sep 2016 08:47:35 -0600 Shuah Khan <[email protected]> wrote:
Move mic/mpssd examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build mic/mpssd. It can be built from top level directory or from mic/mpssd directory:Run make -C
samples/mic/mpssdor cdsamples/mic/mpssd; make
This one seems good as-is
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 5/8 samples: move misc-devices/mei example code from Documentation
In reply to Shuah KhanMove misc-devices/mei examples to samples/mei and remove it from Documentation Makefile. Delete misc-devices/Makefile.
Create a new Makefile to build samples/mei. It can be built from top level directory or from mei directory:
Run make -C samples/mei or cd samples/mei; make
--- Documentation/Makefile | 2 +- Documentation/misc-devices/Makefile | 1 - Documentation/misc-devices/mei/.gitignore | 1 - Documentation/misc-devices/mei/Makefile | 5 - Documentation/misc-devices/mei/TODO | 2 - Documentation/misc-devices/mei/mei-amt-version.c | 479 ----------------------- samples/mei/.gitignore | 1 + samples/mei/Makefile | 9 + samples/mei/TODO | 2 + samples/mei/mei-amt-version.c | 479 +++++++++++++++++++++++ 10 files changed, 492 insertions(+), 489 deletions(-) delete mode 100644 Documentation/misc-devices/Makefile delete mode 100644 Documentation/misc-devices/mei/.gitignore delete mode 100644 Documentation/misc-devices/mei/Makefile delete mode 100644 Documentation/misc-devices/mei/TODO delete mode 100644 Documentation/misc-devices/mei/mei-amt-version.c create mode 100644 samples/mei/.gitignore create mode 100644 samples/mei/Makefile create mode 100644 samples/mei/TODO create mode 100644 samples/mei/mei-amt-version.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin misc-devices pcmcia timers watchdog +subdir-y := blackfin pcmcia timers watchdog
Documentation/misc-devices/Makefile deleted +0 -1
@@ -1 +0,0 @@ -subdir-y := mei
Documentation/misc-devices/mei/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -mei-amt-version
Documentation/misc-devices/mei/Makefile deleted +0 -5
@@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-y := mei-amt-version -HOSTCFLAGS_mei-amt-version.o += -I$(objtree)/usr/include -# Tell kbuild to always build the programs -always := $(hostprogs-y)
Documentation/misc-devices/mei/TODO deleted +0 -2
@@ -1,2 +0,0 @@ -TODO: - - Cleanup and split the timer function
Documentation/misc-devices/mei/mei-amt-version.c deleted +0 -479
479 lines not on this page · raw message
samples/mei/.gitignore new file +1 -0
@@ -0,0 +1 @@ +mei-amt-version
samples/mei/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +CC := $(CROSS_COMPILE)gcc +CFLAGS := -I../../usr/include + +PROGS := mei-amt-version + +all: $(PROGS) + +clean: + rm -fr $(PROGS)
samples/mei/TODO new file +2 -0
@@ -0,0 +1,2 @@ +TODO: + - Cleanup and split the timer function
samples/mei/mei-amt-version.c new file +479 -0
479 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH 5/8] samples: move misc-devices/mei example code from Documentation
Quoted 5 lines · On Mon, 19 Sep 2016 08:47:36 -0600 Shuah Khan <[email protected]> wrote:
Move misc-devices/mei examples to
samples/meiand remove it from DocumentationMakefile. Delete misc-devices/Makefile.Create a new
Makefileto buildsamples/mei. It can be built from top level directory or from mei directory:
This one still has a fair amount of code hiding in the .txt files, but that's a separate job.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/8] samples: move misc-devices/mei example code from Documentation
Quoted 25 lines
-----Original Message-----
From: Jonathan Corbet [mailto:[email protected]]
Sent: Monday, September 19, 2016 19:14
To: Shuah Khan <[email protected]>
Cc: Dutt, Sudeep <[email protected]>; Dixit, Ashutosh <[email protected]>; Winkler, Tomas <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Chandramouli, Dasaratharaman <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH 5/8] samples: move misc-devices/mei example code from DocumentationQuoted 3 lines · On Mon, 19 Sep 2016 08:47:36 -0600 Shuah Khan <[email protected]> wrote:
Move misc-devices/mei examples to
samples/meiand remove it from DocumentationMakefile. Delete misc-devices/Makefile.
Quoted 7 lines
Quoted 2 lines
Create a new
Makefileto buildsamples/mei. It can be built from top level directory or from mei directory:This one still has a fair amount of code hiding in the .txt files, but that's a separate job.
Acked-by Jonathan Corbet <[email protected]>
Shouldn't this update also the MAINTAINERS file? Tomas
Re: [PATCH 5/8] samples: move misc-devices/mei example code from Documentation
Quoted 28 lines · Tomas
Quoted 28 lines
-----Original Message-----
From: Jonathan Corbet [mailto:[email protected]]
Sent: Monday, September 19, 2016 19:14
To: Shuah Khan <[email protected]>
Cc: Dutt, Sudeep <[email protected]>; Dixit, Ashutosh <[email protected]>; Winkler, Tomas <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Chandramouli, Dasaratharaman <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH 5/8] samples: move misc-devices/mei example code from DocumentationQuoted 5 lines · On Mon, 19 Sep 2016 08:47:36 -0600 Shuah Khan <[email protected]> wrote:
Move misc-devices/mei examples to
samples/meiand remove it from DocumentationMakefile. Delete misc-devices/Makefile.Create a new
Makefileto buildsamples/mei. It can be built from top level directory or from mei directory:
Quoted 8 lines
Quoted 4 lines
This one still has a fair amount of code hiding in the .txt files, but that's a separate job.
Acked-by Jonathan Corbet <[email protected]>Shouldn't this update also the
MAINTAINERSfile? Tomas
It has a catch all F: Documentation/misc-devices/mei/*
Yes. I think it would be a good idea to add a new F: entry to INTEL MANAGEMENT ENGINE (mei) for these moved files.
I will take care of this in v2.
thanks,
-- Shuah
PATCH 6/8 samples: move pcmcia example code from Documentation
In reply to Shuah KhanMove pcmcia examples to samples and remove it from Documentation Makefile. Create a new Makefile to build pcmcia. It can be built from top level directory or from pcmcia directory:
Run make -C samples/pcmcia or cd samples/pcmcia; make
--- Documentation/Makefile | 2 +- Documentation/pcmcia/.gitignore | 1 - Documentation/pcmcia/Makefile | 7 ------- Documentation/pcmcia/crc32hash.c | 32 -------------------------------- samples/pcmcia/.gitignore | 1 + samples/pcmcia/Makefile | 9 +++++++++ samples/pcmcia/crc32hash.c | 32 ++++++++++++++++++++++++++++++++ 7 files changed, 43 insertions(+), 41 deletions(-) delete mode 100644 Documentation/pcmcia/.gitignore delete mode 100644 Documentation/pcmcia/Makefile delete mode 100644 Documentation/pcmcia/crc32hash.c create mode 100644 samples/pcmcia/.gitignore create mode 100644 samples/pcmcia/Makefile create mode 100644 samples/pcmcia/crc32hash.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin pcmcia timers watchdog +subdir-y := blackfin timers watchdog
Documentation/pcmcia/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -crc32hash
Documentation/pcmcia/Makefile deleted +0 -7
@@ -1,7 +0,0 @@ -# List of programs to build -hostprogs-y := crc32hash - -# Tell kbuild to always build the programs -always := $(hostprogs-y) - -HOSTCFLAGS_crc32hash.o += -I$(objtree)/usr/include
Documentation/pcmcia/crc32hash.c deleted +0 -32
@@ -1,32 +0,0 @@ -/* crc32hash.c - derived from linux/lib/crc32.c, GNU GPL v2 */ -/* Usage example: -$ ./crc32hash "Dual Speed" -*/ - -#include <string.h> -#include <stdio.h> -#include <ctype.h> -#include <stdlib.h> - -static unsigned int crc32 (unsigned char const *p,unsigned int len) -{ -int i; -unsigned int crc =0 ; -while (len--) { - crc ^= *p++; -for (i =0 ; i <8 ; i++) - crc = (crc >>1 ) ^ ((crc &1 ) ?0xedb88320 :0 ); - } -return crc; -} - -int main (int argc,char **argv) { -unsigned int result; -if (argc !=2 ) { -printf ("no string passed as argument\n" ); -return -1 ; - } - result =crc32 ((unsigned char const *)argv[1 ],strlen (argv[1 ])); -printf ("0x%x\n" , result); -return 0 ; -}
samples/pcmcia/.gitignore new file +1 -0
@@ -0,0 +1 @@ +crc32hash
samples/pcmcia/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +CC := $(CROSS_COMPILE)gcc +CFLAGS := -I../../usr/include + +PROGS := crc32hash + +all: $(PROGS) + +clean: + rm -fr $(PROGS)
samples/pcmcia/crc32hash.c new file +32 -0
@@ -0,0 +1,32 @@ +/* crc32hash.c - derived from linux/lib/crc32.c, GNU GPL v2 */ +/* Usage example: +$ ./crc32hash "Dual Speed" +*/ + +#include <string.h> +#include <stdio.h> +#include <ctype.h> +#include <stdlib.h> + +static unsigned int crc32 (unsigned char const *p,unsigned int len) +{ +int i; +unsigned int crc =0 ; +while (len--) { + crc ^= *p++; +for (i =0 ; i <8 ; i++) + crc = (crc >>1 ) ^ ((crc &1 ) ?0xedb88320 :0 ); + } +return crc; +} + +int main (int argc,char **argv) { +unsigned int result; +if (argc !=2 ) { +printf ("no string passed as argument\n" ); +return -1 ; + } + result =crc32 ((unsigned char const *)argv[1 ],strlen (argv[1 ])); +printf ("0x%x\n" , result); +return 0 ; +}
Signature · 1 line
2.7.4
Jonathan Corbet
maintainerRe: [PATCH 6/8] samples: move pcmcia example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:37 -0600 Shuah Khan <[email protected]> wrote:
Move pcmcia examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build pcmcia. It can be built from top level directory or from pcmcia directory:
Does PCMCIA still exist/work? I guess it probably must somewhere. This one might better qualify as a "tool." Documentation/pcmcia/devicetable.txt needs an update, as does MAINTAINERS.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 7/8 samples: move timers example code from Documentation
In reply to Shuah KhanMove timers examples to samples and remove it from Documentation Makefile. Create a new Makefile to build timers. It can be built from top level directory or from timers directory:
Run make -C samples/timers or cd samples/timers; make
--- Documentation/Makefile | 2 +- Documentation/timers/.gitignore | 1 - Documentation/timers/Makefile | 5 - Documentation/timers/hpet_example.c | 294 ------------------------------------ samples/timers/.gitignore | 1 + samples/timers/Makefile | 15 ++ samples/timers/hpet_example.c | 294 ++++++++++++++++++++++++++++++++++++ 7 files changed, 311 insertions(+), 301 deletions(-) delete mode 100644 Documentation/timers/.gitignore delete mode 100644 Documentation/timers/Makefile delete mode 100644 Documentation/timers/hpet_example.c create mode 100644 samples/timers/.gitignore create mode 100644 samples/timers/Makefile create mode 100644 samples/timers/hpet_example.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin timers watchdog +subdir-y := blackfin watchdog
Documentation/timers/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -hpet_example
Documentation/timers/Makefile deleted +0 -5
@@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-$(CONFIG_X86) := hpet_example - -# Tell kbuild to always build the programs -always := $(hostprogs-y)
Documentation/timers/hpet_example.c deleted +0 -294
294 lines not on this page · raw message
samples/timers/.gitignore new file +1 -0
@@ -0,0 +1 @@ +hpet_example
samples/timers/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +ifndef CROSS_COMPILE +uname_M := $(shell uname -m 2>/dev/null || echo not) +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) + +ifeq ($(ARCH),x86) +CC := $(CROSS_COMPILE)gcc +PROGS := hpet_example + +all: $(PROGS) + +clean: + rm -fr $(PROGS) + +endif +endif
samples/timers/hpet_example.c new file +294 -0
294 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH 7/8] samples: move timers example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:38 -0600 Shuah Khan <[email protected]> wrote:
Move timers examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build timers. It can be built from top level directory or from timers directory:
Documentation/timers/hpet.txt needs updating. Otherwise
jon
PATCH 8/8 samples: move watchdog example code from Documentation
In reply to Shuah KhanMove watchdog examples to samples and remove it from Documentation Makefile. Create a new Makefile to build watchdog. It can be built from top level directory or from watchdog directory:
Run make -C samples/watchdog or cd samples/watchdog; make
--- Documentation/Makefile | 2 +- Documentation/watchdog/Makefile | 1 - Documentation/watchdog/src/.gitignore | 1 - Documentation/watchdog/src/Makefile | 5 ----- Documentation/watchdog/src/watchdog-simple.c | 24 ------------------------ samples/watchdog/.gitignore | 1 + samples/watchdog/Makefile | 8 ++++++++ samples/watchdog/watchdog-simple.c | 24 ++++++++++++++++++++++++ 8 files changed, 34 insertions(+), 32 deletions(-) delete mode 100644 Documentation/watchdog/Makefile delete mode 100644 Documentation/watchdog/src/.gitignore delete mode 100644 Documentation/watchdog/src/Makefile delete mode 100644 Documentation/watchdog/src/watchdog-simple.c create mode 100644 samples/watchdog/.gitignore create mode 100644 samples/watchdog/Makefile create mode 100644 samples/watchdog/watchdog-simple.c
Documentation/Makefile +1 -1
@@ -1 +1 @@ -subdir-y := blackfin watchdog +subdir-y := blackfin
Documentation/watchdog/Makefile deleted +0 -1
@@ -1 +0,0 @@ -subdir-y := src
Documentation/watchdog/src/.gitignore deleted +0 -1
@@ -1 +0,0 @@ -watchdog-simple
Documentation/watchdog/src/Makefile deleted +0 -5
@@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-y := watchdog-simple - -# Tell kbuild to always build the programs -always := $(hostprogs-y)
Documentation/watchdog/src/watchdog-simple.c deleted +0 -24
@@ -1,24 +0,0 @@ -#include <stdio.h> -#include <stdlib.h> -#include <unistd.h> -#include <fcntl.h> - -int main (void ) -{ -int fd =open ("/dev/watchdog" ,O_WRONLY ); -int ret =0 ; -if (fd ==-1 ) { -perror ("watchdog" ); -exit (EXIT_FAILURE ); - } -while (1 ) { - ret =write (fd,"\0" ,1 ); -if (ret !=1 ) { - ret =-1 ; -break ; - } -sleep (10 ); - } -close (fd); -return ret; -}
samples/watchdog/.gitignore new file +1 -0
@@ -0,0 +1 @@ +watchdog-simple
samples/watchdog/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +CC := $(CROSS_COMPILE)gcc +PROGS := watchdog-simple + +all: $(PROGS) + +clean: + rm -fr $(PROGS) +
samples/watchdog/watchdog-simple.c new file +24 -0
@@ -0,0 +1,24 @@ +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <fcntl.h> + +int main (void ) +{ +int fd =open ("/dev/watchdog" ,O_WRONLY ); +int ret =0 ; +if (fd ==-1 ) { +perror ("watchdog" ); +exit (EXIT_FAILURE ); + } +while (1 ) { + ret =write (fd,"\0" ,1 ); +if (ret !=1 ) { + ret =-1 ; +break ; + } +sleep (10 ); + } +close (fd); +return ret; +}
Signature · 1 line
2.7.4
Jonathan Corbet
maintainerRe: [PATCH 8/8] samples: move watchdog example code from Documentation
Quoted 3 lines · On Mon, 19 Sep 2016 08:47:39 -0600 Shuah Khan <[email protected]> wrote:
Move watchdog examples to samples and remove it from Documentation
Makefile. Create a newMakefileto build watchdog. It can be built from top level directory or from watchdog directory:
Updates needed to watchdog-api.txt and wdt.txt; probably MAINTAINERS too.
(In all of these cases, please feel free to carry the doc file updates with the rest, they don't need to come through me).
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 2 lines · Shuah Khan
Move runnable examples code from Documentation to samples. I moved just the example code, and left documentation files as is.
FWIW I like this.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center