Skip to contentSkip to conversation

support/testing: TestInitSystemSystemdRwIfupdown test expect a RW rootfs

PATCH New Romain Naour 2 participants 4 messages Nov 8, 2020 – Nov 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/testing: TestInitSystemSystemdRwIfupdown test expect a RW rootfs

When running the TestInitSystemSystemdRwIfupdown test, the rootfs must be in read-write mode. The commit log [1] introducing systemd tests say so:

"basic systemd, read-write, network w/ ifupdown"

With systemd 246.5, the service systemd-update-done return an error code when it can't write on the filesystem (/etc)

[1] 117835d5fcd508f301d62dd08ee658c1982c7fa7
[2] https://github.com/systemd/systemd/commit/8019995e9af9c6d7b5985198cedccd24eda3e26e

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/830981813

---
Note: systemd-update-done will continue to fail for other systemd tests when the rootfs is in read-only mode.

---
 support/testing/tests/init/test_systemd.py | 1 -
 1 file changed, 1 deletion(-)
support/testing/tests/init/test_systemd.py +0 -1
index 65c06d21b7..c0ef5e1202 100644
@@ -91,7 +91,6 @@ class TestInitSystemSystemdRwIfupdown(InitSystemSystemdBase):
         """
         BR2_SYSTEM_DHCP="eth0"
         # BR2_PACKAGE_SYSTEMD_NETWORKD is not set
-        # BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW is not set
         BR2_TARGET_ROOTFS_EXT2=y
         """
 
Signature · 1 line
2.25.4
#1 lore raw

PATCH 1/1 support/testing: TestInitSystemSystemdRwIfupdown test expect a RW rootfs

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

When running the TestInitSystemSystemdRwIfupdown test, the rootfs must be in read-write mode. The commit log [1] introducing systemd tests say so:

"basic systemd, read-write, network w/ ifupdown"

With systemd 246.5, the service systemd-update-done return an error code when it can't write on the filesystem (/etc)

[1] 117835d5fcd508f301d62dd08ee658c1982c7fa7
[2] https://github.com/systemd/systemd/commit/8019995e9af9c6d7b5985198cedccd24eda3e26e

Quoted 6 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/830981813

---

Committed, thanks.

Quoted 2 lines

Note: systemd-update-done will continue to fail for other systemd tests when the rootfs is in read-only mode.

What is the impact of that? Anything we can do about it?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 support/testing: TestInitSystemSystemdRwIfupdown test expect a RW rootfs

Hello Peter,

Le 09/11/2020 ? 21:11, Peter Korsgaard a ?crit?:

Quoted 21 lines
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

When running the TestInitSystemSystemdRwIfupdown test, the rootfs must be in read-write mode. The commit log [1] introducing systemd tests say so:

"basic systemd, read-write, network w/ ifupdown"

With systemd 246.5, the service systemd-update-done return an error code when it can't write on the filesystem (/etc)

[1] 117835d5fcd508f301d62dd08ee658c1982c7fa7
[2] https://github.com/systemd/systemd/commit/8019995e9af9c6d7b5985198cedccd24eda3e26e

Quoted 6 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/830981813

---

Quoted 7 lines

Committed, thanks.

Quoted 2 lines

Note: systemd-update-done will continue to fail for other systemd tests when the rootfs is in read-only mode.

What is the impact of that? Anything we can do about it?

The systemd-update-done service can't work for read-only filesystem even if previously the service didn't failed in such case.

I'll take a look if we can disable it at build time.

Best regards,
Romain

#3 lore raw

PATCH 1/1 support/testing: TestInitSystemSystemdRwIfupdown test expect a RW rootfs

In reply to Romain Naour
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

When running the TestInitSystemSystemdRwIfupdown test, the rootfs must be in read-write mode. The commit log [1] introducing systemd tests say so:

"basic systemd, read-write, network w/ ifupdown"

With systemd 246.5, the service systemd-update-done return an error code when it can't write on the filesystem (/etc)

[1] 117835d5fcd508f301d62dd08ee658c1982c7fa7
[2] https://github.com/systemd/systemd/commit/8019995e9af9c6d7b5985198cedccd24eda3e26e

Quoted 8 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/830981813

---
Note: systemd-update-done will continue to fail for other systemd tests when the rootfs is in read-only mode.

Committed to 2020.02.x and 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard