scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err_handler()
PATCH 1/1 scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err_handler()
Commit 5586dd8ea250a ("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves the ufshcd_scsi_block_requests() inside err_handler(), but forgets to remove the ufshcd_scsi_unblock_requests() in the early return path. Correct the coding mistake.
drivers/scsi/ufs/ufshcd.c +0 -1
@@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct work_struct *work)if (hba->ufshcd_state !=UFSHCD_STATE_ERROR ) hba->ufshcd_state =UFSHCD_STATE_OPERATIONAL ;spin_unlock_irqrestore (hba->host->host_lock, flags); -ufshcd_scsi_unblock_requests (hba);return ; }ufshcd_set_eh_in_progress (hba);
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 7 lines · Can Guo
Commit
5586dd8ea250a("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves theufshcd_scsi_block_requests()insideerr_handler(), but forgets to remove theufshcd_scsi_unblock_requests()in the early return path. Correct the coding mistake.Signed-off-by Can Guo <[email protected]>
Quoted 15 lines
drivers/scsi/ufs/ufshcd.c +0
-1@@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct work_struct *work)if (hba->ufshcd_state !=UFSHCD_STATE_ERROR ) hba->ufshcd_state =UFSHCD_STATE_OPERATIONAL ;spin_unlock_irqrestore (hba->host->host_lock, flags); -ufshcd_scsi_unblock_requests (hba);return ; }ufshcd_set_eh_in_progress (hba);Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
[email protected]
Reviewed-byQuoted 10 lines · Asutosh Das
Quoted 7 lines · Can Guo
Commit
5586dd8ea250a("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves theufshcd_scsi_block_requests()insideerr_handler(), but forgets to remove theufshcd_scsi_unblock_requests()in the early return path. Correct the coding mistake.Signed-off-by Can Guo <[email protected]>Reviewed-by Asutosh Das <[email protected]>
Quoted 16 lines
Quoted 13 lines
drivers/scsi/ufs/ufshcd.c +0
-1@@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct work_struct *work)if (hba->ufshcd_state !=UFSHCD_STATE_ERROR ) hba->ufshcd_state =UFSHCD_STATE_OPERATIONAL ;spin_unlock_irqrestore (hba->host->host_lock, flags); -ufshcd_scsi_unblock_requests (hba);return ; }ufshcd_set_eh_in_progress(hba);Quoted 3 lines
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 6 lines · Can Guo
Commit
5586dd8ea250a("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves theufshcd_scsi_block_requests()insideerr_handler(), but forgets to remove theufshcd_scsi_unblock_requests()in the early return path. Correct the coding mistake.Signed-off-by Can Guo <[email protected]>
Hi Can,
Please add a "Fixes:" tag.
Thanks,
Bart.
Quoted 6 lines
Commit
5586dd8ea250a("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves theufshcd_scsi_block_requests()insideerr_handler(), but forgets to remove theufshcd_scsi_unblock_requests()in the early return path. Correct the coding mistake.
"fixes" tag please, for those who don't read the commit message. Thanks,
Avri
Quoted 19 lines
Signed-off-by Can Guo <[email protected]>drivers/scsi/ufs/ufshcd.c +0
-1@@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct work_struct *work)if (hba->ufshcd_state !=UFSHCD_STATE_ERROR ) hba->ufshcd_state =UFSHCD_STATE_OPERATIONAL ;spin_unlock_irqrestore (hba->host->host_lock, flags); -ufshcd_scsi_unblock_requests (hba);return ; }ufshcd_set_eh_in_progress(hba);--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 9 lines · Avri Altman
Quoted 5 lines
Commit
5586dd8ea250a("scsi: ufs: Fix a race condition between error handler and runtime PM ops") moves theufshcd_scsi_block_requests()insideerr_handler(), but forgets to remove theufshcd_scsi_unblock_requests()in the early return path. Correct the coding mistake."fixes" tag please, for those who don't read the commit message. Thanks,
Avri
Already added one in the V2 of it.
Thanks,
Can Guo.
Quoted 20 lines
Quoted 20 lines
Signed-off-by Can Guo <[email protected]>drivers/scsi/ufs/ufshcd.c +0
-0@@ -5670,7 +5670,6 @@ static void ufshcd_err_handler(struct
work_struct
*work)if (hba->ufshcd_state != UFSHCD_STATE_ERROR) hba->ufshcd_state = UFSHCD_STATE_OPERATIONAL; spin_unlock_irqrestore(hba->host->host_lock, flags); - ufshcd_scsi_unblock_requests(hba); return; } ufshcd_set_eh_in_progress(hba);--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.