net: calxedaxgmac: fix driver dependencies
Subsystems (2)
PATCH 1/1 net: calxedaxgmac: fix driver dependencies
Calxeda 1G/10G XGMAC Ethernet support should be available only on Calxeda ECX-1000/2000 (Highbank/Midway) platforms.
--- drivers/net/ethernet/calxeda/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/calxeda/Kconfig +1 -0
@@ -1,6 +1,7 @@ config NET_CALXEDA_XGMAC tristate "Calxeda 1G/10G XGMAC Ethernet driver" depends on HAS_IOMEM && HAS_DMA + depends on ARCH_HIGHBANK || COMPILE_TEST select CRC32 help This is the driver for the XGMAC Ethernet IP block found on Calxeda
Quoted 15 lines · Bartlomiej Zolnierkiewicz
Calxeda 1G/10G XGMAC Ethernet support should be available only on Calxeda ECX-1000/2000 (Highbank/Midway) platforms.
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>Acked-by Kyungmin Park <[email protected]>Cc Rob Herring <[email protected]>--- drivers/net/ethernet/calxeda/Kconfig | 1 + 1 file changed, 1 insertion(+)Index: b/drivers/net/ethernet/calxeda/Kconfig
===================================================================
drivers/net/ethernet/calxeda/Kconfig 2014-09-01 17:33:49.232810483 +0200 line 4
Quoted 4 lines
drivers/net/ethernet/calxeda/Kconfig 2014-09-01 17:33:49.232810483 +0200 renamed from drivers/net/ethernet/calxeda/Kconfig 2014-07-30 14:31:12.159522474 +0200 +1
-0@@ -1,6 +1,7 @@ config NET_CALXEDA_XGMAC tristate "Calxeda 1G/10G XGMAC Ethernet driver" depends on HAS_IOMEM && HAS_DMA + depends on ARCH_HIGHBANK || COMPILE_TEST
Opinions differ on whether drivers should be restricted in this way. There is no actual dependency requiring ARCH_HIGHBANK. So I leave it to David.
Rob
Hi,
Quoted 12 lines · Rob Herring
Quoted 10 lines · Bartlomiej Zolnierkiewicz
Calxeda 1G/10G XGMAC Ethernet support should be available only on Calxeda ECX-1000/2000 (Highbank/Midway) platforms.
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>Acked-by Kyungmin Park <[email protected]>Cc Rob Herring <[email protected]>--- drivers/net/ethernet/calxeda/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
drivers/net/ethernet/calxeda/Kconfig 2014-09-01 17:33:49.232810483 +0200 line 4
Quoted 9 lines
Index: b/drivers/net/ethernet/calxeda/Kconfig
===================================================================drivers/net/ethernet/calxeda/Kconfig 2014-09-01 17:33:49.232810483 +0200 renamed from drivers/net/ethernet/calxeda/Kconfig 2014-07-30 14:31:12.159522474 +0200 +1
-0@@ -1,6 +1,7 @@ config NET_CALXEDA_XGMAC tristate "Calxeda 1G/10G XGMAC Ethernet driver" depends on HAS_IOMEM && HAS_DMA + depends on ARCH_HIGHBANK || COMPILE_TESTOpinions differ on whether drivers should be restricted in this way. There is no actual dependency requiring
ARCH_HIGHBANK. So I leave it to David.
The hardware is specific to ARCH_HIGHBANK and it is just unavailble on any other platform (i.e. I have completely no use for this option on ARM Exynos platform). In such cases we restrict drivers to the specific hardware platform so they don't pollute configs for other platforms (i.e. this option is enabled by default in multi_v7_defconfig and once I go from multi defconfing to single platform one, the option stays enabled).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
From: Bartlomiej Zolnierkiewicz <[email protected]>
Date: Mon, 01 Sep 2014 17:39:04 +0200
Quoted 5 lines
Calxeda 1G/10G XGMAC Ethernet support should be available only on Calxeda ECX-1000/2000 (Highbank/Midway) platforms.
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>Acked-by Kyungmin Park <[email protected]>
Applied.