xen: fix using ZONE_DEVICE memory for foreign mappings
Subsystems (5)
Juergen Gross
maintainercover xen: fix using ZONE_DEVICE memory for foreign mappings
Fix an issue found in dom0 when running on a host with NVMe.
Juergen Gross (2):
xen: add helpers for caching grant mapping pages
xen: don't use page->lru for ZONE_DEVICE memory
drivers/block/xen-blkback/blkback.c | 89 ++++---------------- drivers/block/xen-blkback/common.h | 4 +- drivers/block/xen-blkback/xenbus.c | 6 +- drivers/xen/grant-table.c | 123 ++++++++++++++++++++++++++++ drivers/xen/unpopulated-alloc.c | 20 +++-- drivers/xen/xen-scsiback.c | 60 +++----------- include/xen/grant_table.h | 17 ++++ 7 files changed, 182 insertions(+), 137 deletions(-)
Signature · 1 line
2.26.2
Juergen Gross
maintainerPATCH 1/2 xen: add helpers for caching grant mapping pages
Instead of having similar helpers in multiple backend drivers use common helpers for caching pages allocated via gnttab_alloc_pages().
Make use of those helpers in blkback and scsiback.
--- drivers/block/xen-blkback/blkback.c | 89 ++++++----------------------- drivers/block/xen-blkback/common.h | 4 +- drivers/block/xen-blkback/xenbus.c | 6 +- drivers/xen/grant-table.c | 72 +++++++++++++++++++++++ drivers/xen/xen-scsiback.c | 60 ++++--------------- include/xen/grant_table.h | 13 +++++ 6 files changed, 116 insertions(+), 128 deletions(-)
drivers/block/xen-blkback/blkback.c +17 -72
@@ -132,73 +132,12 @@ module_param(log_stats, int, 0644);#define BLKBACK_INVALID_HANDLE (~0) -/* Number of free pages to remove on each call to gnttab_free_pages */ -#define NUM_BATCH_FREE_PAGES 10 -static inline bool persistent_gnt_timeout (struct persistent_gnt *persistent_gnt) {return pgrant_timeout && (jiffies - persistent_gnt->last_used >=HZ * pgrant_timeout); } -static inline int get_free_page (struct xen_blkif_ring *ring,struct page **page) -{ -unsigned long flags; - -spin_lock_irqsave (&ring->free_pages_lock, flags); -if (list_empty (&ring->free_pages)) { -BUG_ON (ring->free_pages_num !=0 ); -spin_unlock_irqrestore (&ring->free_pages_lock, flags); -return gnttab_alloc_pages (1 , page); - } -BUG_ON (ring->free_pages_num ==0 ); - page[0] = list_first_entry(&ring->free_pages, struct page, lru); -list_del (&page[0 ]->lru); - ring->free_pages_num--; -spin_unlock_irqrestore (&ring->free_pages_lock, flags); - -return 0 ; -} - -static inline void put_free_pages (struct xen_blkif_ring *ring,struct page **page, -int num) -{ -unsigned long flags; -int i; - -spin_lock_irqsave (&ring->free_pages_lock, flags); -for (i =0 ; i < num; i++) -list_add (&page[i]->lru, &ring->free_pages); - ring->free_pages_num += num; -spin_unlock_irqrestore (&ring->free_pages_lock, flags); -} - -static inline void shrink_free_pagepool (struct xen_blkif_ring *ring,int num) -{ -/* Remove requested pages in batches of NUM_BATCH_FREE_PAGES */ -struct page *page[NUM_BATCH_FREE_PAGES ]; -unsigned int num_pages =0 ; -unsigned long flags; - -spin_lock_irqsave (&ring->free_pages_lock, flags); -while (ring->free_pages_num > num) { -BUG_ON (list_empty (&ring->free_pages)); - page[num_pages] =list_first_entry (&ring->free_pages, - struct page, lru); -list_del (&page[num_pages]->lru); - ring->free_pages_num--; -if (++num_pages ==NUM_BATCH_FREE_PAGES ) { -spin_unlock_irqrestore (&ring->free_pages_lock, flags); -gnttab_free_pages (num_pages, page); -spin_lock_irqsave (&ring->free_pages_lock, flags); - num_pages =0 ; - } - } -spin_unlock_irqrestore (&ring->free_pages_lock, flags); -if (num_pages !=0 ) -gnttab_free_pages (num_pages, page); -} -#define vaddr (page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))static int do_block_io_op (struct xen_blkif_ring *ring,unsigned int *eoi_flags);
@@ -331,7 +270,8 @@ static void free_persistent_gnts(struct xen_blkif_ring *ring, struct rb_root *ro unmap_data.count = segs_to_unmap;BUG_ON (gnttab_unmap_refs_sync (&unmap_data)); -put_free_pages (ring, pages, segs_to_unmap); +gnttab_page_cache_put (&ring->free_pages, pages, + segs_to_unmap); segs_to_unmap =0 ; }
@@ -371,7 +311,8 @@ void xen_blkbk_unmap_purged_grants(struct work_struct *work)if (++segs_to_unmap ==BLKIF_MAX_SEGMENTS_PER_REQUEST ) { unmap_data.count = segs_to_unmap;BUG_ON (gnttab_unmap_refs_sync (&unmap_data)); -put_free_pages (ring, pages, segs_to_unmap); +gnttab_page_cache_put (&ring->free_pages, pages, + segs_to_unmap); segs_to_unmap =0 ; }kfree (persistent_gnt);
@@ -379,7 +320,7 @@ void xen_blkbk_unmap_purged_grants(struct work_struct *work)if (segs_to_unmap >0 ) { unmap_data.count = segs_to_unmap;BUG_ON (gnttab_unmap_refs_sync (&unmap_data)); -put_free_pages (ring, pages, segs_to_unmap); +gnttab_page_cache_put (&ring->free_pages, pages, segs_to_unmap); } }
@@ -664,9 +605,10 @@ int xen_blkif_schedule(void *arg)/* Shrink the free pages pool if it is too large. */ if (time_before (jiffies, blkif->buffer_squeeze_end)) -shrink_free_pagepool (ring,0 ); +gnttab_page_cache_shrink (&ring->free_pages,0 );else -shrink_free_pagepool (ring, max_buffer_pages); +gnttab_page_cache_shrink (&ring->free_pages, + max_buffer_pages);if (log_stats &&time_after (jiffies, ring->st_print))print_stats (ring);
@@ -697,7 +639,7 @@ void xen_blkbk_free_caches(struct xen_blkif_ring *ring) ring->persistent_gnt_c =0 ;/* Since we are shutting down remove all pages from the buffer */ -shrink_free_pagepool (ring,0 /* All */ ); +gnttab_page_cache_shrink (&ring->free_pages,0 /* All */ ); } static unsigned int xen_blkbk_unmap_prepare(
@@ -736,7 +678,7 @@ static void xen_blkbk_unmap_and_respond_callback(int result, struct gntab_unmap_but is this the best way to deal with this? */ BUG_ON (result); -put_free_pages (ring, data->pages, data->count); +gnttab_page_cache_put (&ring->free_pages, data->pages, data->count);make_response (ring, pending_req->id, pending_req->operation, pending_req->status);free_req (ring, pending_req);
@@ -803,7 +745,8 @@ static void xen_blkbk_unmap(struct xen_blkif_ring *ring,if (invcount) { ret =gnttab_unmap_refs (unmap,NULL , unmap_pages, invcount);BUG_ON (ret); -put_free_pages (ring, unmap_pages, invcount); +gnttab_page_cache_put (&ring->free_pages, unmap_pages, + invcount); } pages += batch; num -= batch;
@@ -850,7 +793,8 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring, pages[i]->page = persistent_gnt->page; pages[i]->persistent_gnt = persistent_gnt; }else { -if (get_free_page (ring, &pages[i]->page)) +if (gnttab_page_cache_get (&ring->free_pages, + &pages[i]->page)) goto out_of_memory; addr =vaddr (pages[i]->page); pages_to_gnt[segs_to_map] = pages[i]->page;
@@ -883,7 +827,8 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring,BUG_ON (new_map_idx >= segs_to_map);if (unlikely (map[new_map_idx].status !=0 )) {pr_debug ("invalid buffer -- could not remap it\n" ); -put_free_pages (ring, &pages[seg_idx]->page,1 ); +gnttab_page_cache_put (&ring->free_pages, + &pages[seg_idx]->page,1 ); pages[seg_idx]->handle =BLKBACK_INVALID_HANDLE ; ret |=1 ; goto next;
@@ -944,7 +889,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring, out_of_memory:pr_alert ("%s: out of memory\n" , __func__); -put_free_pages (ring, pages_to_gnt, segs_to_map); +gnttab_page_cache_put (&ring->free_pages, pages_to_gnt, segs_to_map);for (i = last_map; i < num; i++) pages[i]->handle =BLKBACK_INVALID_HANDLE ;return -ENOMEM ;
drivers/block/xen-blkback/common.h +1 -3
@@ -288,9 +288,7 @@ struct xen_blkif_ring {struct work_struct persistent_purge_work;/* Buffer of free pages to map grant refs. */ -spinlock_t free_pages_lock; -int free_pages_num; -struct list_head free_pages; +struct gnttab_page_cache free_pages;struct work_struct free_work;/* Thread shutdown wait queue. */
drivers/block/xen-blkback/xenbus.c +2 -4
@@ -144,8 +144,7 @@ static int xen_blkif_alloc_rings(struct xen_blkif *blkif)INIT_LIST_HEAD (&ring->pending_free);INIT_LIST_HEAD (&ring->persistent_purge_list);INIT_WORK (&ring->persistent_purge_work, xen_blkbk_unmap_purged_grants); -spin_lock_init (&ring->free_pages_lock); -INIT_LIST_HEAD (&ring->free_pages); +gnttab_page_cache_init (&ring->free_pages);spin_lock_init (&ring->pending_free_lock);init_waitqueue_head (&ring->pending_free_wq);
@@ -317,8 +316,7 @@ static int xen_blkif_disconnect(struct xen_blkif *blkif)BUG_ON (atomic_read (&ring->persistent_gnt_in_use) !=0 );BUG_ON (!list_empty (&ring->persistent_purge_list));BUG_ON (!RB_EMPTY_ROOT (&ring->persistent_gnts)); -BUG_ON (!list_empty (&ring->free_pages)); -BUG_ON (ring->free_pages_num !=0 ); +BUG_ON (ring->free_pages.num_pages !=0 );BUG_ON (ring->persistent_gnt_c !=0 );WARN_ON (i != (XEN_BLKIF_REQS_PER_PAGE * blkif->nr_ring_pages)); ring->active = false;
drivers/xen/grant-table.c +72 -0
78 lines not on this page · raw message
drivers/xen/xen-scsiback.c +11 -49
114 lines not on this page · raw message
include/xen/grant_table.h +13 -0
@@ -198,6 +198,19 @@ void gnttab_free_auto_xlat_frames(void);int gnttab_alloc_pages (int nr_pages,struct page **pages);void gnttab_free_pages (int nr_pages,struct page **pages); +struct gnttab_page_cache { +spinlock_t lock; +struct list_head pages; +unsigned int num_pages; +}; + +void gnttab_page_cache_init (struct gnttab_page_cache *cache); +int gnttab_page_cache_get (struct gnttab_page_cache *cache,struct page **page); +void gnttab_page_cache_put (struct gnttab_page_cache *cache,struct page **page, +unsigned int num); +void gnttab_page_cache_shrink (struct gnttab_page_cache *cache, +unsigned int num); +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC struct gnttab_dma_alloc_args {/* Device for which DMA memory will be/was allocated. */
Signature · 1 line
2.26.2
Re: [PATCH 1/2] xen: add helpers for caching grant mapping pages
Quoted 6 lines · Juergen Gross
Instead of having similar helpers in multiple backend drivers use common helpers for caching pages allocated via
gnttab_alloc_pages().Make use of those helpers in blkback and scsiback.
Signed-off-by Juergen Gross <[email protected]>
Quoted 16 lines
drivers/xen/grant-table.c +16
-0+ +void gnttab_page_cache_shrink (struct gnttab_page_cache *cache,unsigned int num) +{ +struct page *page[10 ]; +unsigned int i =0 ; +unsigned long flags; + +spin_lock_irqsave (&cache->lock, flags); + +while (cache->num_pages > num) { + page[i] = list_first_entry(&cache->pages, struct page, lru); +list_del (&page[i]->lru); + cache->num_pages--; +if (++i ==ARRAY_SIZE (page)) { +spin_unlock_irqrestore (&cache->lock, flags); +gnttab_free_pages (i, page);
drivers/xen/grant-table.c int gnttab_alloc_pages(int nr_pages, struct page **pages) · line 885
Quoted 10 lines
drivers/xen/grant-table.c +10
-0+ i =0 ; +spin_lock_irqsave (&cache->lock, flags); + } + } + +spin_unlock_irqrestore (&cache->lock, flags); + +if (i !=0 ) +gnttab_free_pages (i, page); +}
How about splitting cache->pages list into two lists (one @num long and the other holding the rest) and then batching gntab_free_pages() from that first list? Then you won't have to deal with locking.
In fact, I am not even sure batching gains us much, I'd consider going one-by-one.
-boris
Juergen Gross
maintainerPATCH 2/2 xen: don't use page->lru for ZONE_DEVICE memory
In reply to Juergen GrossCommit 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") introduced usage of ZONE_DEVICE memory for foreign memory mappings.
Unfortunately this collides with using page->lru for Xen backend private page caches.
Fix that by using page->zone_device_data instead.
--- drivers/xen/grant-table.c | 65 +++++++++++++++++++++++++++++---- drivers/xen/unpopulated-alloc.c | 20 +++++----- include/xen/grant_table.h | 4 ++ 3 files changed, 73 insertions(+), 16 deletions(-)
drivers/xen/grant-table.c +58 -7
@@ -813,10 +813,63 @@ int gnttab_alloc_pages(int nr_pages, struct page **pages) }EXPORT_SYMBOL_GPL (gnttab_alloc_pages); +#ifdef CONFIG_XEN_UNPOPULATED_ALLOC +static inline void cache_init (struct gnttab_page_cache *cache) +{ + cache->pages =NULL ; +} + +static inline bool cache_empty (struct gnttab_page_cache *cache) +{ +return !cache->pages; +} + +static inline struct page *cache_deq (struct gnttab_page_cache *cache) +{ +struct page *page; + + page = cache->pages; + cache->pages = page->zone_device_data; + +return page; +} + +static inline void cache_enq (struct gnttab_page_cache *cache,struct page *page) +{ + page->zone_device_data = cache->pages; + cache->pages = page; +} +#else +static inline void cache_init (struct gnttab_page_cache *cache) +{ +INIT_LIST_HEAD (&cache->pages); +} + +static inline bool cache_empty (struct gnttab_page_cache *cache) +{ +return list_empty (&cache->pages); +} + +static inline struct page *cache_deq (struct gnttab_page_cache *cache) +{ +struct page *page; + + page = list_first_entry(&cache->pages, struct page, lru); +list_del (&page[0 ]->lru); + +return page; +} + +static inline void cache_enq (struct gnttab_page_cache *cache,struct page *page) +{ +list_add (&page->lru, &cache->pages); +} +#endif +void gnttab_page_cache_init (struct gnttab_page_cache *cache) {spin_lock_init (&cache->lock); -INIT_LIST_HEAD (&cache->pages); +cache_init (cache); cache->num_pages =0 ; }EXPORT_SYMBOL_GPL (gnttab_page_cache_init);
@@ -827,13 +880,12 @@ int gnttab_page_cache_get(struct gnttab_page_cache *cache, struct page **page)spin_lock_irqsave (&cache->lock, flags); -if (list_empty (&cache->pages)) { +if (cache_empty (cache)) {spin_unlock_irqrestore (&cache->lock, flags);return gnttab_alloc_pages (1 , page); } - page[0] = list_first_entry(&cache->pages, struct page, lru); -list_del (&page[0 ]->lru); + page[0 ] =cache_deq (cache); cache->num_pages--;spin_unlock_irqrestore (&cache->lock, flags);
@@ -851,7 +903,7 @@ void gnttab_page_cache_put(struct gnttab_page_cache *cache, struct page **page,spin_lock_irqsave (&cache->lock, flags);for (i =0 ; i < num; i++) -list_add (&page[i]->lru, &cache->pages); +cache_enq (cache, page[i]); cache->num_pages += num;spin_unlock_irqrestore (&cache->lock, flags);
@@ -867,8 +919,7 @@ void gnttab_page_cache_shrink(struct gnttab_page_cache *cache, unsigned int num)spin_lock_irqsave (&cache->lock, flags);while (cache->num_pages > num) { - page[i] = list_first_entry(&cache->pages, struct page, lru); -list_del (&page[i]->lru); + page[i] =cache_deq (cache); cache->num_pages--;if (++i ==ARRAY_SIZE (page)) {spin_unlock_irqrestore (&cache->lock, flags);
drivers/xen/unpopulated-alloc.c +11 -9
@@ -12,7 +12,7 @@#include <xen/xen.h> static DEFINE_MUTEX (list_lock); -static LIST_HEAD (page_list); +static struct page *page_list;static unsigned int list_count;static int fill_list (unsigned int nr_pages)
@@ -84,7 +84,8 @@ static int fill_list(unsigned int nr_pages)struct page *pg =virt_to_page (vaddr +PAGE_SIZE * i);BUG_ON (!virt_addr_valid (vaddr +PAGE_SIZE * i)); -list_add (&pg->lru, &page_list); + pg->zone_device_data = page_list; + page_list = pg; list_count++; }
@@ -118,12 +119,10 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages) }for (i =0 ; i < nr_pages; i++) { -struct page *pg =list_first_entry_or_null (&page_list, - struct page, - lru); +struct page *pg = page_list;BUG_ON (!pg); -list_del (&pg->lru); + page_list = pg->zone_device_data; list_count--; pages[i] = pg;
@@ -134,7 +133,8 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)unsigned int j;for (j =0 ; j <= i; j++) { -list_add (&pages[j]->lru, &page_list); + pages[j]->zone_device_data = page_list; + page_list = pages[j]; list_count++; } goto out;
@@ -160,7 +160,8 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)mutex_lock (&list_lock);for (i =0 ; i < nr_pages; i++) { -list_add (&pages[i]->lru, &page_list); + pages[i]->zone_device_data = page_list; + page_list = pages[i]; list_count++; }mutex_unlock (&list_lock);
@@ -189,7 +190,8 @@ static int __init init(void)struct page *pg =pfn_to_page (xen_extra_mem[i].start_pfn + j); -list_add (&pg->lru, &page_list); + pg->zone_device_data = page_list; + page_list = pg; list_count++; } }
include/xen/grant_table.h +4 -0
@@ -200,7 +200,11 @@ void gnttab_free_pages(int nr_pages, struct page **pages);struct gnttab_page_cache {spinlock_t lock; +#ifdef CONFIG_XEN_UNPOPULATED_ALLOC +struct page *pages; +#else struct list_head pages; +#endif unsigned int num_pages; };
Signature · 1 line
2.26.2
Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
Quoted 5 lines · Juergen Gross
Commit
9e2369c06c8a18("xen: add helpers to allocate unpopulated memory") introduced usage ofZONE_DEVICEmemory for foreign memory mappings.
Quoted 7 lines
Unfortunately this collides with using
page->lrufor Xen backend private page caches.Fix that by using
page->zone_device_datainstead.Fixes 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory")Signed-off-by Juergen Gross <[email protected]>
Would it make sense to add BUG_ON(is_zone_device_page(page)) and the opposite as appropriate to cache_enq? Either way:
Jürgen Groß
maintainerRe: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
Quoted 9 lines · Jason Andryuk
Quoted 8 lines · Juergen Gross
Commit
9e2369c06c8a18("xen: add helpers to allocate unpopulated memory") introduced usage ofZONE_DEVICEmemory for foreign memory mappings.Unfortunately this collides with using
page->lrufor Xen backend private page caches.
Quoted 7 lines
Quoted 4 lines
Fix that by using
page->zone_device_datainstead.Fixes 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory")Signed-off-by Juergen Gross <[email protected]>Would it make sense to add BUG_ON(is_zone_device_page(page)) and the opposite as appropriate to
cache_enq?
No, I don't think so. At least in the CONFIG_ZONE_DEVICE case the initial list in a PV dom0 is populated from extra memory (basically the same, but not marked as zone device memory explicitly).
Juergen
Roger Pau Monné
Acked-byRe: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
Quoted 15 lines · Jürgen Groß
Quoted 14 lines · Jason Andryuk
Quoted 12 lines · Juergen Gross
Commit
9e2369c06c8a18("xen: add helpers to allocate unpopulated memory") introduced usage ofZONE_DEVICEmemory for foreign memory mappings.Unfortunately this collides with using
page->lrufor Xen backend private page caches.Fix that by using
page->zone_device_datainstead.Fixes 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory")Signed-off-by Juergen Gross <[email protected]>
Quoted 6 lines
Quoted 2 lines
Would it make sense to add BUG_ON(is_zone_device_page(page)) and the opposite as appropriate to
cache_enq?No, I don't think so. At least in the
CONFIG_ZONE_DEVICEcase the initial list in a PV dom0 is populated from extra memory (basically the same, but not marked as zone device memory explicitly).
I assume it's fine for us to then use page->zone_device_data even if the page is not explicitly marked as ZONE_DEVICE memory?
If that's fine, add my:
To both patches, and thank you very much for fixing this!
Roger.
Jürgen Groß
maintainerRe: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
Quoted 19 lines · Roger Pau Monné
Quoted 18 lines · Jürgen Groß
Quoted 16 lines · Jason Andryuk
Quoted 5 lines · Juergen Gross
Commit
9e2369c06c8a18("xen: add helpers to allocate unpopulated memory") introduced usage ofZONE_DEVICEmemory for foreign memory mappings.Quoted 7 lines
Unfortunately this collides with using
page->lrufor Xen backend private page caches.Fix that by using
page->zone_device_datainstead.Fixes 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory")Signed-off-by Juergen Gross <[email protected]>Would it make sense to add BUG_ON(is_zone_device_page(page)) and the opposite as appropriate to
cache_enq?
Quoted 6 lines
Quoted 3 lines
No, I don't think so. At least in the
CONFIG_ZONE_DEVICEcase the initial list in a PV dom0 is populated from extra memory (basically the same, but not marked as zone device memory explicitly).I assume it's fine for us to then use
page->zone_device_dataeven if the page is not explicitly marked asZONE_DEVICEmemory?
I think so, yes, as we are owner of that page and we were fine to use lru, too.
Quoted 6 lines
If that's fine, add my:
Acked-by Roger Pau Monné <[email protected]>To both patches, and thank you very much for fixing this!
UR welcome. :-)
Juergen
Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
Quoted 25 lines · Jürgen Groß
Quoted 23 lines · Roger Pau Monné
Quoted 21 lines · Jürgen Groß
Quoted 9 lines · Jason Andryuk
Quoted 8 lines · Juergen Gross
Commit
9e2369c06c8a18("xen: add helpers to allocate unpopulated memory") introduced usage ofZONE_DEVICEmemory for foreign memory mappings.Unfortunately this collides with using
page->lrufor Xen backend private page caches.Quoted 7 lines
Quoted 4 lines
Fix that by using
page->zone_device_datainstead.Fixes 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory")Signed-off-by Juergen Gross <[email protected]>Would it make sense to add BUG_ON(is_zone_device_page(page)) and the opposite as appropriate to
cache_enq?No, I don't think so. At least in the
CONFIG_ZONE_DEVICEcase the initial list in a PV dom0 is populated from extra memory (basically the same, but not marked as zone device memory explicitly).
Quoted 5 lines
Quoted 2 lines
I assume it's fine for us to then use
page->zone_device_dataeven if the page is not explicitly marked asZONE_DEVICEmemory?I think so, yes, as we are owner of that page and we were fine to use lru, too.
I think memremap_pages or devm_memremap_pages (which calls memremap_pages) is how you mark memory as ZONE_DEVICE. i.e. they are explicitly marked.
memremap_pages
memmap_init_zone_device (with ZONE_DEVICE)
__init_single_page
set_page_links
set_page_zone
grep only finds a few uses of ZONE_DEVICE in the whole tree.
Regards,
Jason
Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory
In reply to Juergen Grossdrivers/xen/unpopulated-alloc.c line 15
Quoted 8 lines · Juergen Gross
drivers/xen/unpopulated-alloc.c +1
-1@@ -12,7 +12,7 @@#include <xen/xen.h> static DEFINE_MUTEX (list_lock); -static LIST_HEAD (page_list); +static struct page *page_list;
next_page or next_allocated_page?
Either way