Skip to contentSkip to conversation

smb/server: fix memory leak bugs

PATCH In review ZhangGuoDong 3 participants 6 messages Jul 31 – Aug 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover smb/server: fix memory leak bugs

From: ZhangGuoDong <[email protected]>

ZhangGuoDong (2):
smb/server: fix memory leak in ksmbd_krb5_authenticate() smb/server: fix memory leak in ksmbd_login_user()

 fs/smb/server/auth.c             | 1 +
 fs/smb/server/mgmt/user_config.c | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 smb/server: fix memory leak in ksmbd_krb5_authenticate()

From: ZhangGuoDong <[email protected]>

ksmbd_ipc_login_request_ext() returns an independently allocated response. ksmbd_alloc_user() copies the supplementary group IDs from the response, but ksmbd_krb5_authenticate() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with it.

---
 fs/smb/server/auth.c | 1 +
 1 file changed, 1 insertion(+)
fs/smb/server/auth.c +1 -0
index 4e7b6f0e6b8c..e886ea5681ca 100644
@@ -464,6 +464,7 @@ int ksmbd_krb5_authenticate(struct ksmbd_session *sess, char *in_blob,
 	*out_len = resp->spnego_blob_len;
 	retval = 0;
 out:
+	kvfree(resp_ext);
 	kvfree(resp);
 	return retval;
 }
Signature · 1 line
2.43.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] smb/server: fix memory leak in ksmbd_krb5_authenticate()

Quoted 20 lines · ZhangGuoDong

From: ZhangGuoDong <[email protected]>

ksmbd_ipc_login_request_ext() returns an independently allocated response. ksmbd_alloc_user() copies the supplementary group IDs from the response, but ksmbd_krb5_authenticate() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with it.

---
  fs/smb/server/auth.c | 1 +
  1 file changed, 1 insertion(+)
fs/smb/server/auth.c +0 -0
index 4e7b6f0e6b8c..e886ea5681ca 100644

fs/smb/server/auth.c int ksmbd_krb5_authenticate(struct ksmbd_session *sess, char *in_blob, · line 470

Quoted 7 lines
fs/smb/server/auth.c +1 -0
@@ -464,6 +464,7 @@ int ksmbd_krb5_authenticate(struct ksmbd_session *sess, char *in_blob,
  	*out_len = resp->spnego_blob_len;
  	retval = 0;
  out:
+	kvfree(resp_ext);
  	kvfree(resp);
  	return retval;
  }
Fixes a77e0e02af1c2 ("ksmbd: add support for supplementary groups")
#3 lore raw

PATCH 2/2 smb/server: fix memory leak in ksmbd_login_user()

In reply to ZhangGuoDong

From: ZhangGuoDong <[email protected]>

ksmbd_ipc_login_request_ext() returns an independently allocated response. ksmbd_alloc_user() copies the supplementary group IDs from the response, but ksmbd_login_user() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with it.

---
 fs/smb/server/mgmt/user_config.c | 1 +
 1 file changed, 1 insertion(+)
fs/smb/server/mgmt/user_config.c +1 -0
index cf45841d9d1b..21b1d51d918b 100644
@@ -27,6 +27,7 @@ struct ksmbd_user *ksmbd_login_user(const char *account)
 
 	user = ksmbd_alloc_user(resp, resp_ext);
 out:
+	kvfree(resp_ext);
 	kvfree(resp);
 	return user;
 }
Signature · 1 line
2.43.0
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] smb/server: fix memory leak in ksmbd_login_user()

Quoted 20 lines · ZhangGuoDong

From: ZhangGuoDong <[email protected]>

ksmbd_ipc_login_request_ext() returns an independently allocated response. ksmbd_alloc_user() copies the supplementary group IDs from the response, but ksmbd_login_user() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with it.

---
  fs/smb/server/mgmt/user_config.c | 1 +
  1 file changed, 1 insertion(+)
fs/smb/server/mgmt/user_config.c +0 -0
index cf45841d9d1b..21b1d51d918b 100644

fs/smb/server/mgmt/user_config.c struct ksmbd_user *ksmbd_login_user(const char *account) · line 33

Quoted 7 lines
fs/smb/server/mgmt/user_config.c +1 -0
@@ -27,6 +27,7 @@ struct ksmbd_user *ksmbd_login_user(const char *account)
 
  	user = ksmbd_alloc_user(resp, resp_ext);
  out:
+	kvfree(resp_ext);
  	kvfree(resp);
  	return user;
  }
Fixes a77e0e02af1c2 ("ksmbd: add support for supplementary groups")
maintainer
#5 lore raw
In reply to ZhangGuoDong
Quoted 6 lines · ZhangGuoDong

From: ZhangGuoDong <[email protected]>

ZhangGuoDong (2):
smb/server: fix memory leak in ksmbd_krb5_authenticate() smb/server: fix memory leak in ksmbd_login_user()

Enzo previously sent the same patch, and it is currently applied to ksmbd-for-next-next.

https://github.com/smfrench/smb3-kernel/commit/151d00564ce5b643ed8e9e9343bd21f1073386eb

Thanks.

Quoted 8 lines
 fs/smb/server/auth.c             | 1 +
 fs/smb/server/mgmt/user_config.c | 1 +
 2 files changed, 2 insertions(+)

--
2.43.0