Skip to contentSkip to conversation

crypto: caam - Add missing Job Ring include

PATCH In review Michael Neuling 3 participants 4 messages Nov 18, 2013 – Nov 26, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: caam - Add missing Job Ring include

linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig giving:

drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function 'of_iomap' [-Werror=implicit-function-declaration]

In:
commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
Author: Ruchika Gupta <[email protected]>
crypto: caam - Add Platform driver for Job Ring

We added a reference to of_iomap but did add the necessary include file.

The below adds this include.

drivers/crypto/caam/jr.c +1 -0
index d23356d2..1d80bd3 100644
@@ -6,6 +6,7 @@
  */
 
 #include <linux/of_irq.h>
+#include <linux/of_address.h>
 
 #include "compat.h"
 #include "regs.h"
Acked-by on v1 1/1
#1 lore raw
Quoted 43 lines

-----Original Message-----
From: [email protected] [mailto:linux-crypto- [email protected]] On Behalf Of Michael Neuling
Sent: Monday, November 18, 2013 9:50 AM
To: Gupta Ruchika-R66431
Cc: Garg Vakul-B16394; Herbert Xu; [email protected]; [email protected]
Subject: [PATCH] crypto: caam - Add missing Job Ring include

linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig giving:

drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
'of_iomap' [-Werror=implicit-function-declaration]

In:
commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
Author: Ruchika Gupta <[email protected]>
crypto: caam - Add Platform driver for Job Ring

We added a reference to of_iomap but did add the necessary include file.

The below adds this include.

drivers/crypto/caam/jr.c index renamed from drivers/crypto/caam/jr.c +0 -0

d23356d2..1d80bd3 100644

drivers/crypto/caam/jr.c +1 -1
@@ -6,6 +6,7 @@
  */
 
 #include <linux/of_irq.h>
+#include <linux/of_address.h>
 
 #include "compat.h"
 #include "regs.h"
--

To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Michael Neuling

Hi Herbert,

Can you please apply this patch.

Regards,
Ruchika

Quoted 53 lines

-----Original Message-----
From: Gupta Ruchika-R66431
Sent: Tuesday, November 19, 2013 9:47 AM
To: 'Michael Neuling'
Cc: Garg Vakul-B16394; Herbert Xu; [email protected]; [email protected]
Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include

Quoted 43 lines

-----Original Message-----
From: [email protected] [mailto:linux-crypto- [email protected]] On Behalf Of Michael Neuling
Sent: Monday, November 18, 2013 9:50 AM
To: Gupta Ruchika-R66431
Cc: Garg Vakul-B16394; Herbert Xu; [email protected]; [email protected]
Subject: [PATCH] crypto: caam - Add missing Job Ring include

linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig giving:

drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
drivers/crypto/caam/jr.c:468:2: error: implicit declaration of
function 'of_iomap' [-Werror=implicit-function-declaration]

In:
commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
Author: Ruchika Gupta <[email protected]>
crypto: caam - Add Platform driver for Job Ring

We added a reference to of_iomap but did add the necessary include file.

The below adds this include.

drivers/crypto/caam/jr.c index renamed from drivers/crypto/caam/jr.c +0 -0

d23356d2..1d80bd3 100644

drivers/crypto/caam/jr.c +1 -1
@@ -6,6 +6,7 @@
  */
 
 #include <linux/of_irq.h>
+#include <linux/of_address.h>
 
 #include "compat.h"
 #include "regs.h"
--

To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html