clk: samsung: exynos7885: Correct "div4" clock parents
Subsystems (3)
PATCH RESEND 1/1 clk: samsung: exynos7885: Correct "div4" clock parents
"div4" DIVs which divide PLLs by 4 are actually dividing "div2" DIVs by 2 to achieve a by 4 division, thus their parents are the respective "div2" DIVs. These DIVs were mistakenly set to have the PLLs as parents. This leads to the kernel thinking "div4"s and everything under them run at 2x the clock speed. Fix this.
--- drivers/clk/samsung/clk-exynos7885.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos7885.c +2 -2
@@ -182,7 +182,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED0_DIV2, 0, 1),DIV (CLK_DOUT_SHARED0_DIV3 ,"dout_shared0_div3" ,"fout_shared0_pll" ,CLK_CON_DIV_PLL_SHARED0_DIV3 ,0 ,2 ), -DIV (CLK_DOUT_SHARED0_DIV4 ,"dout_shared0_div4" ,"fout_shared0_pll" , +DIV (CLK_DOUT_SHARED0_DIV4 ,"dout_shared0_div4" ,"dout_shared0_div2" ,CLK_CON_DIV_PLL_SHARED0_DIV4 ,0 ,1 ),DIV (CLK_DOUT_SHARED0_DIV5 ,"dout_shared0_div5" ,"fout_shared0_pll" , CLK_CON_DIV_PLL_SHARED0_DIV5, 0, 3),
@@ -190,7 +190,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED1_DIV2, 0, 1),DIV (CLK_DOUT_SHARED1_DIV3 ,"dout_shared1_div3" ,"fout_shared1_pll" ,CLK_CON_DIV_PLL_SHARED1_DIV3 ,0 ,2 ), -DIV (CLK_DOUT_SHARED1_DIV4 ,"dout_shared1_div4" ,"fout_shared1_pll" , +DIV (CLK_DOUT_SHARED1_DIV4 ,"dout_shared1_div4" ,"dout_shared1_div2" , CLK_CON_DIV_PLL_SHARED1_DIV4, 0, 1),/* CORE */
Signature · 1 line
2.35.1
Quoted 9 lines · David Virag
"div4" DIVs which divide PLLs by 4 are actually dividing "div2" DIVs by 2 to achieve a by 4 division, thus their parents are the respective "div2" DIVs. These DIVs were mistakenly set to have the PLLs as parents. This leads to the kernel thinking "div4"s and everything under them run at 2x the clock speed. Fix this.
Fixes 45bd8166a1d8 ("clk: samsung: Add initial Exynos7885 clock driver")Signed-off-by David Virag <[email protected]>---
Looks good, I'll take it after merge window.
Best regards,
Krzysztof
Quoted 26 lines · David Virag
"div4" DIVs which divide PLLs by 4 are actually dividing "div2" DIVs by 2 to achieve a by 4 division, thus their parents are the respective "div2" DIVs. These DIVs were mistakenly set to have the PLLs as parents. This leads to the kernel thinking "div4"s and everything under them run at 2x the clock speed. Fix this.
Fixes 45bd8166a1d8 ("clk: samsung: Add initial Exynos7885 clock driver")Signed-off-by David Virag <[email protected]>--- drivers/clk/samsung/clk-exynos7885.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/clk/samsung/clk-exynos7885.c +1
-1@@ -182,7 +182,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED0_DIV2, 0, 1),DIV (CLK_DOUT_SHARED0_DIV3 ,"dout_shared0_div3" ,"fout_shared0_pll" ,CLK_CON_DIV_PLL_SHARED0_DIV3 ,0 ,2 ), -DIV (CLK_DOUT_SHARED0_DIV4 ,"dout_shared0_div4" ,"fout_shared0_pll" , +DIV (CLK_DOUT_SHARED0_DIV4 ,"dout_shared0_div4" ,"dout_shared0_div2" ,CLK_CON_DIV_PLL_SHARED0_DIV4 ,0 ,1 ),DIV (CLK_DOUT_SHARED0_DIV5 ,"dout_shared0_div5" ,"fout_shared0_pll" , CLK_CON_DIV_PLL_SHARED0_DIV5, 0, 3),
drivers/clk/samsung/clk-exynos7885.c static const struct samsung_div_clock top_div_clks[] __initconst = { · line 196
Quoted 8 lines
drivers/clk/samsung/clk-exynos7885.c +1
-1@@ -190,7 +190,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED1_DIV2, 0, 1),DIV (CLK_DOUT_SHARED1_DIV3 ,"dout_shared1_div3" ,"fout_shared1_pll" ,CLK_CON_DIV_PLL_SHARED1_DIV3 ,0 ,2 ), -DIV (CLK_DOUT_SHARED1_DIV4 ,"dout_shared1_div4" ,"fout_shared1_pll" , +DIV (CLK_DOUT_SHARED1_DIV4 ,"dout_shared1_div4" ,"dout_shared1_div2" , CLK_CON_DIV_PLL_SHARED1_DIV4, 0, 1),/* CORE */
Thanks for fix-up.
Signature · 3 lines
Best Regards, Samsung Electronics Chanwoo Choi
Krzysztof Kozlowski
AppliedQuoted 8 lines · David Virag
"div4" DIVs which divide PLLs by 4 are actually dividing "div2" DIVs by 2 to achieve a by 4 division, thus their parents are the respective "div2" DIVs. These DIVs were mistakenly set to have the PLLs as parents. This leads to the kernel thinking "div4"s and everything under them run at 2x the clock speed. Fix this.
[...]
Applied, thanks!
[1/1] clk: samsung: exynos7885: Correct "div4" clock parents
https://git.kernel.org/krzk/linux/c/ef80c95c29dc67c3034f32d93c41e2ede398e387
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>