Skip to contentSkip to conversation

net: sun8i-emac: Allow all RGMII PHY modes

PATCH New Andre Przywara 3 participants 4 messages Nov 16, 2020 – Jan 14, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sun8i-emac: Allow all RGMII PHY modes

So far all GBit users of the sun8i-emac driver were using the "rgmii" PHY mode, even though this turns out to be mostly wrong. It just worked because the PHY driver doesn't do the proper setup (yet).
In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the correct ones.

To allow the DTs to describe the phy-mode correctly, and to stay compatible with Linux, at least allow those other RGMII modes in the driver.

This avoids breakage if mainline DTs will be synced with U-Boot.

An almost identical patch (f1239d8aa84d) was merged into the Linux driver and has been backported to stable kernels.

---
 drivers/net/sun8i_emac.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/sun8i_emac.c +3 -0
index 4524604126c..5db33f5c135 100644
@@ -353,6 +353,9 @@ static int sun8i_emac_set_syscon(struct sun8i_eth_pdata *pdata,
 		/* default */
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_ID:
+	case PHY_INTERFACE_MODE_RGMII_RXID:
+	case PHY_INTERFACE_MODE_RGMII_TXID:
 		reg |= SC_EPIT | SC_ETCS_INT_GMII;
 		break;
 	case PHY_INTERFACE_MODE_RMII:
Signature · 1 line
2.17.5
#1 lore raw

PATCH 1/1 net: sun8i-emac: Allow all RGMII PHY modes

Quoted 10 lines · Andre Przywara

So far all GBit users of the sun8i-emac driver were using the "rgmii" PHY mode, even though this turns out to be mostly wrong. It just worked because the PHY driver doesn't do the proper setup (yet).
In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the correct ones.

To allow the DTs to describe the phy-mode correctly, and to stay compatible with Linux, at least allow those other RGMII modes in the driver.

Quoted 6 lines

This avoids breakage if mainline DTs will be synced with U-Boot.

An almost identical patch (f1239d8aa84d) was merged into the Linux driver and has been backported to stable kernels.

Hello Joe,

could we get this into v2021.01, please?

#2 lore raw

PATCH 1/1 net: sun8i-emac: Allow all RGMII PHY modes

On 30/11/2020 17:23, Heinrich Schuchardt wrote:

Hi Joe,

Quoted 11 lines · Andre Przywara
Quoted 10 lines

So far all GBit users of the sun8i-emac driver were using the "rgmii" PHY mode, even though this turns out to be mostly wrong. It just worked because the PHY driver doesn't do the proper setup (yet).
In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the correct ones.

To allow the DTs to describe the phy-mode correctly, and to stay compatible with Linux, at least allow those other RGMII modes in the driver.

Quoted 6 lines
Quoted 6 lines

This avoids breakage if mainline DTs will be synced with U-Boot.

An almost identical patch (f1239d8aa84d) was merged into the Linux driver and has been backported to stable kernels.

Are you going to take this through your tree?
Or are you OK with me merging this through u-boot-sunxi?
We depend on this for a DT update, which relies on those new PHY modes.

Cheers,
Andre

Quoted 6 lines

Hello Joe,

could we get this into v2021.01, please?

#3 lore raw

PATCH 1/1 net: sun8i-emac: Allow all RGMII PHY modes

Quoted 18 lines · Andr? Przywara

On 30/11/2020 17:23, Heinrich Schuchardt wrote:

Hi Joe,

Quoted 13 lines · Andre Przywara
Quoted 12 lines

So far all GBit users of the sun8i-emac driver were using the "rgmii" PHY mode, even though this turns out to be mostly wrong. It just worked because the PHY driver doesn't do the proper setup (yet).
In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the correct ones.

To allow the DTs to describe the phy-mode correctly, and to stay compatible with Linux, at least allow those other RGMII modes in the driver.

This avoids breakage if mainline DTs will be synced with U-Boot.

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

An almost identical patch (f1239d8aa84d) was merged into the Linux driver and has been backported to stable kernels.

Are you going to take this through your tree?
Or are you OK with me merging this through u-boot-sunxi?
We depend on this for a DT update, which relies on those new PHY modes.

Feel free to take it through your tree.
Cheers,
-Joe

Quoted 9 lines

Cheers,
Andre

Quoted 6 lines

Hello Joe,

could we get this into v2021.01, please?