s390: virtio: let arch validate VIRTIO features
Subsystems (4)
v7 cover s390: virtio: let arch validate VIRTIO features
Hi all,
The goal of the series is to give a chance to the architecture to validate VIRTIO device features.
in this respin:
1) I kept removed the ack from Jason as I reworked the patch @Jason, the nature and goal of the patch did not really changed please can I get back your acked-by with these changes?
2) Rewording for warning messages
Regards,
Pierre
Pierre Morel (2):
virtio: let arch validate VIRTIO features
s390: virtio: PV needs VIRTIO I/O device protection
arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 48 insertions(+)
Signature · 60 lines
2.25.1 Changelog to v7: - typo in warning message (Connie) to v6: - rewording warning messages (Connie, Halil) to v5: - return directly from S390 arch_validate_virtio_features() when the guest is not protected. (Connie) - Somme rewording (Connie, Michael) - moved back code from arch/s390/ ...kernel/uv.c to ...mm/init.c (Christian) to v4: - separate virtio and arch code (Pierre) - moved code from arch/s390/mm/init.c to arch/s390/kernel/uv.c (as interpreted from Heiko's comment) - moved validation inside the arch code (Connie) - moved the call to arch validation before VIRTIO_F_1 test (Michael) to v3: - add warning (Connie, Christian) - add comment (Connie) - change hook name (Halil, Connie) to v2: - put the test in virtio_finalize_features() (Connie) - put the test inside VIRTIO core (Jason) - pass a virtio device as parameter (Halil)
PATCH v7 1/2 virtio: let arch validate VIRTIO features
An architecture may need to validate the VIRTIO devices features based on architecture specifics.
--- drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 2 files changed, 20 insertions(+)
drivers/virtio/virtio.c +19 -0
@@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) }EXPORT_SYMBOL_GPL (virtio_add_status); +/* +* arch_validate_virtio_features - provide arch specific hook when finalizing +* features for VIRTIO device dev +* @dev: the VIRTIO device being added +* +* Permits the platform to handle architecture-specific requirements when +* device features are finalized. This is the default implementation. +* Architecture implementations can override this. +*/ + +int __weak arch_validate_virtio_features (struct virtio_device *dev) +{ +return 0 ; +} +int virtio_finalize_features (struct virtio_device *dev) {int ret = dev->config->finalize_features (dev);
@@ -176,6 +191,10 @@ int virtio_finalize_features(struct virtio_device *dev)if (ret)return ret; + ret =arch_validate_virtio_features (dev); +if (ret) +return ret; +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 ))return 0 ;
include/linux/virtio_config.h +1 -0
@@ -459,4 +459,5 @@ static inline void virtio_cwrite64(struct virtio_device *vdev, _r; \ }) +int arch_validate_virtio_features (struct virtio_device *dev);#endif /* _LINUX_VIRTIO_CONFIG_H */
Signature · 1 line
2.25.1
PATCH v7 2/2 s390: virtio: PV needs VIRTIO I/O device protection
In reply to Pierre MorelIf protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() interface to fail probe if that's not the case, preventing a host error on access attempt.
--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
arch/s390/mm/init.c +28 -0
@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +} +/* protected virtualization */ static void pv_init (void ) {
Signature · 1 line
2.25.1
Michael S. Tsirkin
maintainerRe: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Quoted 50 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +21
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { + dev_warn(&dev->dev,
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 10 lines
arch/s390/mm/init.c +7
-0+ "support for limited memory access required for protected virtualization\n"); +return -ENODEV ; + } + +return 0 ; +} +/* protected virtualization */ static void pv_init (void ) {
What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct virtio_device can change.
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
Quoted 2 lines
Signature · 1 line
2.25.1
Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Quoted 57 lines · Michael S. Tsirkin
Quoted 56 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +27
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +}
Quoted 8 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 4 lines
arch/s390/mm/init.c +1
-0+/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.
The code was only called from virtio.c so it should be fine.
And my understanding is that we don't need to care about the kABI issue during upstream development?
Thanks
Quoted 7 lines
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
Quoted 2 lines
Signature · 1 line
2.25.1
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerRe: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Quoted 66 lines · Jason Wang
Quoted 54 lines · Michael S. Tsirkin
Quoted 53 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +27
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +}Quoted 8 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 4 lines
arch/s390/mm/init.c +1
-0+/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.
Quoted 6 lines
The code was only called from
virtio.cso it should be fine.And my understanding is that we don't need to care about the kABI issue during upstream development?
Thanks
No, but so far it has been convenient at least for me, for development, to just be able to unload all of virtio and load a different version.
Quoted 8 lines
Quoted 8 lines
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
Quoted 2 lines
Signature · 1 line
2.25.1
Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Quoted 58 lines · Michael S. Tsirkin
Quoted 57 lines · Jason Wang
Quoted 55 lines · Michael S. Tsirkin
Quoted 54 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +28
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +} +
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 3 lines
arch/s390/mm/init.c +0
-0/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.
If you prefer that, we can simply create an arch/s390/kernel/virtio.c ?
Michael S. Tsirkin
maintainerRe: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Quoted 70 lines · Christian Borntraeger
Quoted 58 lines · Michael S. Tsirkin
Quoted 57 lines · Jason Wang
Quoted 55 lines · Michael S. Tsirkin
Quoted 54 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +28
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +} +Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 3 lines
arch/s390/mm/init.c +0
-0/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.
Quoted 1 line
If you prefer that, we can simply create an
arch/s390/kernel/virtio.c?
How would that address the issues above?
Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
In reply to Michael S. TsirkinQuoted 69 lines · Michael S. Tsirkin
Quoted 68 lines · Jason Wang
Quoted 54 lines · Michael S. Tsirkin
Quoted 53 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +27
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +}Quoted 8 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 4 lines
arch/s390/mm/init.c +1
-0+/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.The code was only called from
virtio.cso it should be fine.
Quoted 18 lines
Quoted 4 lines
And my understanding is that we don't need to care about the kABI issue during upstream development?
Thanks
No, but so far it has been convenient at least for me, for development, to just be able to unload all of virtio and load a different version.
Quoted 8 lines
Quoted 8 lines
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
Quoted 2 lines
Signature · 1 line
2.25.1
Hi Michael,
I am not sure to understand the problem so I may propose a wrong solution but, let's try:
Would a callback registration instead of a weak function solve the problem?
The registrating function in core could test a parameter to check if the callback is in sync with the VIRTIO core.
What do you think?
Regards,
Pierre
Signature · 2 lines
Pierre Morel IBM Lab Boeblingen
Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
In reply to Michael S. Tsirkingentle ping.
Quoted 87 lines · Michael S. Tsirkin
Quoted 66 lines · Jason Wang
Quoted 54 lines · Michael S. Tsirkin
Quoted 53 lines · Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless
VIRTIO_F_IOMMU_PLATFORMhas been negotiated. Use the newarch_validate_virtio_features()interface to fail probe if that's not the case, preventing a host error on access attempt.Signed-off-by Pierre Morel <[email protected]>Reviewed-by Cornelia Huck <[email protected]>Acked-by Halil Pasic <[email protected]>--- arch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)arch/s390/mm/init.c +27
-0@@ -45,6 +45,7 @@#include <asm/kasan.h> #include <asm/dma-mapping.h> #include <asm/uv.h> +#include <linux/virtio_config.h> pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);@@ -161,6 +162,33 @@ bool force_dma_unencrypted(struct device *dev)return is_prot_virt_guest (); } +/* +* arch_validate_virtio_features +* @dev: the VIRTIO device being added +* +* Return an error if required features are missing on a guest running +* with protected virtualization. +*/ +int arch_validate_virtio_features (struct virtio_device *dev) +{ +if (!is_prot_virt_guest ()) +return 0 ; + +if (!virtio_has_feature (dev,VIRTIO_F_VERSION_1 )) { +dev_warn (&dev->dev, +"legacy virtio not supported with protected virtualization\n" ); +return -ENODEV ; + } + +if (!virtio_has_feature (dev,VIRTIO_F_IOMMU_PLATFORM )) { +dev_warn (&dev->dev, +"support for limited memory access required for protected virtualization\n" ); +return -ENODEV ; + } + +return 0 ; +}Quoted 8 lines
arch/s390/mm/init.c bool force_dma_unencrypted(struct device *dev) · line 194
Quoted 4 lines
arch/s390/mm/init.c +1
-0+/* protected virtualization */ static void pv_init (void ) {What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.Quoted 6 lines
The code was only called from
virtio.cso it should be fine.And my understanding is that we don't need to care about the kABI issue during upstream development?
Thanks
No, but so far it has been convenient at least for me, for development, to just be able to unload all of virtio and load a different version.
Quoted 8 lines
Quoted 8 lines
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
Quoted 2 lines
Signature · 1 line
2.25.1
Signature · 2 lines
Pierre Morel IBM Lab Boeblingen
Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
On 2020-07-30 13:31, Pierre Morel wrote:
...snip...
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 4 lines
What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct
virtio_devicecan change.The code was only called from
virtio.cso it should be fine.And my understanding is that we don't need to care about the kABI issue during upstream development?
Thanks
Quoted 8 lines
Quoted 8 lines
No, but so far it has been convenient at least for me, for development, to just be able to unload all of virtio and load a different version.
Quoted 4 lines
Quoted 4 lines
I'm not sure what to do with this yet, will try to think about it over the weekend. Thanks!
After reflection, I am not sure that this problem must be treated on the architecture level or inside the VIRTIO transport. Consequently, I will propose another patch series based on CCW transport.
This also should be more convenient for core development.
Regards,
Pierre
Signature · 2 lines
Pierre Morel IBM Lab Boeblingen
Quoted 10 lines · Pierre Morel
Hi all,
The goal of the series is to give a chance to the architecture to validate VIRTIO device features.
in this respin:
1) I kept removed the ack from Jason as I reworked the patch @Jason, the nature and goal of the patch did not really changed please can I get back your acked-by with these changes?
Yes.
Thanks
Quoted 15 lines
2) Rewording for warning messages
Regards,
PierrePierre Morel (2):
virtio: let arch validate VIRTIO features
s390: virtio: PV needs VIRTIO I/O device protectionarch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 48 insertions(+)
Quoted 16 lines · On Wed, 15 Jul 2020 10:31:07 +0200 Pierre Morel <[email protected]> wrote:
Hi all,
The goal of the series is to give a chance to the architecture to validate VIRTIO device features.
in this respin:
1) I kept removed the ack from Jason as I reworked the patch @Jason, the nature and goal of the patch did not really changed please can I get back your acked-by with these changes?
2) Rewording for warning messages
Regards,
Pierre
Quoted 9 lines
Pierre Morel (2):
virtio: let arch validate VIRTIO features
s390: virtio: PV needs VIRTIO I/O device protectionarch/s390/mm/init.c | 28 ++++++++++++++++++++++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 48 insertions(+)
LGTM.
I assume that this will go either via the virtio tree or via the s390 arch tree, i.e. not through virtio-ccw, right?