Skip to contentSkip to conversation

arch64: export __flush_dcache_area

PATCH In review Mark Salyzyn 2 participants 3 messages May 17, 2019 – May 20, 2019 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch64: export __flush_dcache_area

Some (out of tree modular) drivers feel a need to ensure data is flushed to the DDR before continuing flow.

---
 arch/arm64/mm/cache.S | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/mm/cache.S +1 -0
index a194fd0e837f..70d7cb5c0bd2 100644
@@ -120,6 +120,7 @@ ENTRY(__flush_dcache_area)
 	dcache_by_line_op civac, sy, x0, x1, x2, x3
 	ret
 ENDPIPROC(__flush_dcache_area)
+EXPORT_SYMBOL_GPL(__flush_dcache_area)
 
 /*
  *	__clean_dcache_area_pou(kaddr, size)
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
maintainer
#1 lore raw
Quoted 15 lines · Mark Salyzyn

Some (out of tree modular) drivers feel a need to ensure data is flushed to the DDR before continuing flow.

---
 arch/arm64/mm/cache.S | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/mm/cache.S +0 -0
index a194fd0e837f..70d7cb5c0bd2 100644

arch/arm64/mm/cache.S ENTRY(__flush_dcache_area) · line 126

Quoted 7 lines
arch/arm64/mm/cache.S +1 -0
@@ -120,6 +120,7 @@ ENTRY(__flush_dcache_area)
 	dcache_by_line_op civac, sy, x0, x1, x2, x3
 	ret
 ENDPIPROC(__flush_dcache_area)
+EXPORT_SYMBOL_GPL(__flush_dcache_area)
 
 /*
  *	__clean_dcache_area_pou(kaddr, size)

NAK. Such drivers are doing something wrong, there is a dedicated in-kernel API for that handles kernel maintenance (hint: DMA).

Signature · 1 line
Catalin
#2 lore raw
Quoted 21 lines · Catalin Marinas
Quoted 20 lines · Mark Salyzyn

Some (out of tree modular) drivers feel a need to ensure data is flushed to the DDR before continuing flow.

---
  arch/arm64/mm/cache.S | 1 +
  1 file changed, 1 insertion(+)
arch/arm64/mm/cache.S +1 -0
index a194fd0e837f..70d7cb5c0bd2 100644
@@ -120,6 +120,7 @@ ENTRY(__flush_dcache_area)
  	dcache_by_line_op civac, sy, x0, x1, x2, x3
  	ret
  ENDPIPROC(__flush_dcache_area)
+EXPORT_SYMBOL_GPL(__flush_dcache_area)
 
Quoted 4 lines

arch/arm64/mm/cache.S ENTRY(__flush_dcache_area) · line 126

Quoted 2 lines
arch/arm64/mm/cache.S +0 -0
  /*
   *	__clean_dcache_area_pou(kaddr, size)

NAK. Such drivers are doing something wrong, there is a dedicated in-kernel API for that handles kernel maintenance (hint: DMA).

Thanks!

-- Mark