board/qemu/arm-vexpress-tz: use enable=on
PATCH 1/2 board/qemu/arm-vexpress-tz: use enable=on
Since Qemu 6.0.0 [1], a warning appear in the log if a short-form boolean option is used.
[1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ccd3b3b8112b670fdccf8a392b8419b173ffccb4
--- board/qemu/arm-vexpress-tz/readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/qemu/arm-vexpress-tz/readme.txt +1 -1
@@ -16,7 +16,7 @@ from the image directory: -smp 1 -s -m 1024 -d unimp \ -serial stdio \ -netdev user,id=vmnic -device virtio-net-device,netdev=vmnic \ - -semihosting-config enable,target=native \ + -semihosting-config enable=on,target=native \ -bios flash.bin # qemu_arm_vexpress_tz_defconfig The boot stage traces (if any) followed by the login prompt will appear
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 2/2 support/scripts/boot-qemu-image.py: increase the timeout by 10
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfig tested locally with sucess.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046
--- support/scripts/boot-qemu-image.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
support/scripts/boot-qemu-image.py +4 -4
@@ -25,7 +25,7 @@ def main(): qemu_start = os.path.join(os.getcwd(), 'output/images/start-qemu.sh') child = pexpect.spawn(qemu_start, ['serial-only'], - timeout=5, encoding='utf-8', + timeout=50, encoding='utf-8', env={"QEMU_AUDIO_DRV": "none"}) # We want only stdout into the log to avoid double echo
@@ -36,7 +36,7 @@ def main(): time.sleep(1) try: - child.expect(["buildroot login:"], timeout=60) + child.expect(["buildroot login:"], timeout=600) except pexpect.EOF as e: # Some emulations require a fork of qemu-system, which may be # missing on the system, and is not provided by Buildroot.
@@ -58,7 +58,7 @@ def main(): child.sendline("root\r") try: - child.expect(["# "], timeout=60) + child.expect(["# "], timeout=600) except pexpect.EOF: print("Cannot connect to shell") sys.exit(1)
@@ -69,7 +69,7 @@ def main(): child.sendline("poweroff\r") try: - child.expect(["System halted"], timeout=60) + child.expect(["System halted"], timeout=600) child.expect(pexpect.EOF) except pexpect.EOF: pass
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
Romain, All,
On 2022-01-15 15:33 +0100, Romain Naour spake thusly:
Quoted 7 lines
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046
Are you sure increasing the timeout will fix this failure? The build-run.log contains another error:
loaded file zImage from 40400000 to 408CAABF, 004CAAC0 bytes
loaded file rootfs.cpio.uboot from 44000000 to 4438FA4E, 0038FA4F bytes
Kernel image @ 0x40400000 [ 0x000000 - 0x4caac0 ]
## Loading init Ramdisk from Legacy Image at 44000000 ...
Image Name:
Created: 2022-01-13 16:06:53 UTC
Image Type: ARM Linux RAMDisk Image (uncompressed)
Data Size: 3734031 Bytes = 3.6 MiB
Load Address: 00000000
Entry Point: 00000000
Verifying Checksum ... OK
## Flattened Device Tree blob at 40000000
Booting using the fdt blob at 0x40000000
ERROR: reserving fdt memory region failed (addr=7fe00000 size=200000)
Using Device Tree in place at 40000000, end 400051f7So, to me, this is not a timeout issue, but an actual boot issue.
Regards,
Yann E. MORIN.
Quoted 52 lines
Signed-off-by Romain Naour <[email protected]>--- support/scripts/boot-qemu-image.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)support/scripts/boot-qemu-image.py +4
-4@@ -25,7 +25,7 @@ def main(): qemu_start = os.path.join(os.getcwd(), 'output/images/start-qemu.sh') child = pexpect.spawn(qemu_start, ['serial-only'], - timeout=5, encoding='utf-8', + timeout=50, encoding='utf-8', env={"QEMU_AUDIO_DRV": "none"}) # We want only stdout into the log to avoid double echo@@ -36,7 +36,7 @@ def main(): time.sleep(1) try: - child.expect(["buildroot login:"], timeout=60) + child.expect(["buildroot login:"], timeout=600) except pexpect.EOF as e: # Some emulations require a fork of qemu-system, which may be # missing on the system, and is not provided by Buildroot.@@ -58,7 +58,7 @@ def main(): child.sendline("root\r") try: - child.expect(["# "], timeout=60) + child.expect(["# "], timeout=600) except pexpect.EOF: print("Cannot connect to shell") sys.exit(1)@@ -69,7 +69,7 @@ def main(): child.sendline("poweroff\r") try: - child.expect(["System halted"], timeout=60) + child.expect(["System halted"], timeout=600) child.expect(pexpect.EOF) except pexpect.EOF: passSignature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
Hello Yann,
Le 15/01/2022 à 17:05, Yann E. MORIN a écrit :
Quoted 30 lines
Romain, All,
On 2022-01-15 15:33 +0100, Romain Naour spake thusly:
Quoted 7 lines
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046Are you sure increasing the timeout will fix this failure? The build-run.log contains another error:
loaded file zImage from 40400000 to 408CAABF, 004CAAC0 bytes loaded file rootfs.cpio.uboot from 44000000 to 4438FA4E, 0038FA4F bytes Kernel image @ 0x40400000 [ 0x000000 - 0x4caac0 ] ## Loading init Ramdisk from Legacy Image at 44000000 ... Image Name: Created: 2022-01-13 16:06:53 UTC Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 3734031 Bytes = 3.6 MiB Load Address: 00000000 Entry Point: 00000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 40000000 Booting using the fdt blob at 0x40000000 ERROR: reserving fdt memory region failed (addr=7fe00000 size=200000) Using Device Tree in place at 40000000, end 400051f7
Quoted 1 line
So, to me, this is not a timeout issue, but an actual boot issue.
The system stop in the middle of optee startup
optee: dynamic shared memory is enabled
Also, I got the same error message while testing locally.
Best regards,
Romain
Quoted 52 lines
Regards,
Yann E. MORIN.Quoted 48 lines
Signed-off-by Romain Naour <[email protected]>--- support/scripts/boot-qemu-image.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)support/scripts/boot-qemu-image.py +4
-4@@ -25,7 +25,7 @@ def main(): qemu_start = os.path.join(os.getcwd(), 'output/images/start-qemu.sh') child = pexpect.spawn(qemu_start, ['serial-only'], - timeout=5, encoding='utf-8', + timeout=50, encoding='utf-8', env={"QEMU_AUDIO_DRV": "none"}) # We want only stdout into the log to avoid double echo@@ -36,7 +36,7 @@ def main(): time.sleep(1) try: - child.expect(["buildroot login:"], timeout=60) + child.expect(["buildroot login:"], timeout=600) except pexpect.EOF as e: # Some emulations require a fork of qemu-system, which may be # missing on the system, and is not provided by Buildroot.@@ -58,7 +58,7 @@ def main(): child.sendline("root\r") try: - child.expect(["# "], timeout=60) + child.expect(["# "], timeout=600) except pexpect.EOF: print("Cannot connect to shell") sys.exit(1)@@ -69,7 +69,7 @@ def main(): child.sendline("poweroff\r") try: - child.expect(["System halted"], timeout=60) + child.expect(["System halted"], timeout=600) child.expect(pexpect.EOF) except pexpect.EOF: passSignature · 1 line
2.31.1
Quoted 5 lines
Quoted 4 lines
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
Romain, All,
On 2022-01-15 20:28 +0100, Romain Naour spake thusly:
Quoted 11 lines
Le 15/01/2022 à 17:05, Yann E. MORIN a écrit :
Quoted 10 lines
On 2022-01-15 15:33 +0100, Romain Naour spake thusly:
Quoted 7 lines
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046Are you sure increasing the timeout will fix this failure? The build-run.log contains another error:
[--SNIP--]
Quoted 6 lines
Quoted 3 lines
ERROR: reserving fdt memory region failed (addr=7fe00000 size=200000)
Using Device Tree in place at 40000000, end400051f7
So, to me, this is not a timeout issue, but an actual boot issue.The system stop in the middle of optee startup
optee: dynamic shared memory is enabled
I was very confused by the above. Indeed, the log file I downladed earler really stopped at the error message I pasted. I am sure of that, as I still had it in my ~/tmp directory, so I could really double-check.
But now I downloaded it again, and indeed, there are much more traces, up to that optee issue you point ed at.
This is a really weird situation, that the download I had was only partial...
Quoted 1 line
Also, I got the same error message while testing locally.
But testing locally should not have the same impact on boot time, would it? The boot times out on the eleastic runners because they are too slow (and many congtainers contend for the CPU there). But locally, it is really surprising that you hit the exact same timeout issue, and the exact same point in the boot sequence...
Anyway, can you resend your patch, as I marked it rejected in patchwork, please?
Regards,
Yann E. MORIN.
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
Hello Yann, All,
Le 15/01/2022 à 21:23, Yann E. MORIN a écrit :
Quoted 26 lines
Romain, All,
On 2022-01-15 20:28 +0100, Romain Naour spake thusly:
Quoted 11 lines
Le 15/01/2022 à 17:05, Yann E. MORIN a écrit :
Quoted 10 lines
On 2022-01-15 15:33 +0100, Romain Naour spake thusly:
Quoted 7 lines
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046Are you sure increasing the timeout will fix this failure? The build-run.log contains another error:
[--SNIP--]
Quoted 6 lines
Quoted 3 lines
ERROR: reserving fdt memory region failed (addr=7fe00000 size=200000)
Using Device Tree in place at 40000000, end400051f7
So, to me, this is not a timeout issue, but an actual boot issue.The system stop in the middle of optee startup
optee: dynamic shared memory is enabledI was very confused by the above. Indeed, the log file I downladed earler really stopped at the error message I pasted. I am sure of that, as I still had it in my ~/tmp directory, so I could really double-check.
Quoted 5 lines
But now I downloaded it again, and indeed, there are much more traces, up to that optee issue you point ed at.
This is a really weird situation, that the download I had was only partial...
weird ineed.
Quoted 8 lines
Quoted 2 lines
Also, I got the same error message while testing locally.
But testing locally should not have the same impact on boot time, would it? The boot times out on the eleastic runners because they are too slow (and many congtainers contend for the CPU there). But locally, it is really surprising that you hit the exact same timeout issue, and the exact same point in the boot sequence...
I'm not able to reproduce the timeout locally but by looking at the timeout multiplier used for the Buildroot testsuite I would say that a sporadic failures.
I restarted the job in gitlab and this time it succeeded:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1979108650
Best regards,
Romain
Quoted 7 lines
Anyway, can you resend your patch, as I marked it rejected in patchwork, please?
Regards,
Yann E. MORIN.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
In reply to Romain NaourQuoted 5 lines · On Sat, 15 Jan 2022 15:33:44 +0100 Romain Naour <[email protected]> wrote:
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.
Quoted 7 lines
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046Signed-off-by Romain Naour <[email protected]>--- support/scripts/boot-qemu-image.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] support/scripts/boot-qemu-image.py: increase the timeout by 10
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:
Quoted 8 lines · On Sat, 15 Jan 2022 15:33:44 +0100 Romain Naour <[email protected]> wrote:
As for the Buildroot testsuite, multiply every emulator timeout by 10 to avoid sporadic failures in elastic runners.
qemu_arm_vexpress_tz_defconfigtested locally with sucess.Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084046
Quoted 6 lines
Quoted 4 lines
Signed-off-by Romain Naour <[email protected]>---
support/scripts/boot-qemu-image.py| 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)Applied to master, thanks.
Committed to 2022.05.x and 2022.02.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN
AppliedRomain, All,
On 2022-01-15 15:33 +0100, Romain Naour spake thusly:
Quoted 8 lines
Since Qemu 6.0.0 [1], a warning appear in the log if a short-form boolean option is used.
[1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ccd3b3b8112b670fdccf8a392b8419b173ffccb4
Signed-off-by Romain Naour <[email protected]>Cc Etienne Carriere <[email protected]>Cc Dick Olsson <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- board/qemu/arm-vexpress-tz/readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/qemu/arm-vexpress-tz/readme.txt +1
-1@@ -16,7 +16,7 @@ from the image directory: -smp 1 -s -m 1024 -d unimp \ -serial stdio \ -netdev user,id=vmnic -device virtio-net-device,netdev=vmnic \ - -semihosting-config enable,target=native \ + -semihosting-config enable=on,target=native \ -bios flash.bin # qemu_arm_vexpress_tz_defconfig The boot stage traces (if any) followed by the login prompt will appearSignature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Romain,
Quoted 27 lines · Romain Naour
Since Qemu 6.0.0 [1], a warning appear in the log if a short-form boolean option is used.
[1] https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ccd3b3b8112b670fdccf8a392b8419b173ffccb4
Signed-off-by Romain Naour <[email protected]>Cc Etienne Carriere <[email protected]>Cc Dick Olsson <[email protected]>--- board/qemu/arm-vexpress-tz/readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/qemu/arm-vexpress-tz/readme.txt +1
-2@@ -16,7 +16,7 @@ from the image directory: -smp 1 -s -m 1024 -d unimp \ -serial stdio \ -netdev user,id=vmnic -device virtio-net-device,netdev=vmnic \ - -semihosting-config enable,target=native \ + -semihosting-config enable=on,target=native \ -bios flash.bin # qemu_arm_vexpress_tz_defconfig The boot stage traces (if any) followed by the login prompt will appear --
Quoted 2 lines
2.31.1
Thanks for the fix.
Br,
Etienne
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot