platform/x86: hp-wmi: Ignore Win-Lock key events
PATCH 1/1 platform/x86: hp-wmi: Ignore Win-Lock key events
Follow up from https://lore.kernel.org/all/[email protected]/
There is a "Win-Lock" key on HP Omen Laptops which supports enabling and disabling the Windows key, which trigger commands 0x21a4 and 0x121a4 respectively. Currently the hp-wmi driver throws warnings for this event. These can be ignored using KE_IGNORE as the functionality is handled by the keyboard firmware itself.
--- drivers/platform/x86/hp/hp-wmi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/platform/x86/hp/hp-wmi.c +2 -0
@@ -216,6 +216,8 @@ static const struct key_entry hp_wmi_keymap[] = { { KE_KEY, 0x213b, { KEY_INFO } }, { KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } }, { KE_KEY, 0x216a, { KEY_SETUP } }, + { KE_IGNORE, 0x21a4, }, /* Win Lock On */ + { KE_IGNORE, 0x121a4, }, /* Win Lock Off */ { KE_KEY, 0x21a9, { KEY_TOUCHPAD_OFF } }, { KE_KEY, 0x121a9, { KEY_TOUCHPAD_ON } }, { KE_KEY, 0x231b, { KEY_HELP } },
Signature · 1 line
2.37.2
Hi,
Quoted 9 lines · Rishit Bansal
Follow up from https://lore.kernel.org/all/[email protected]/
There is a "Win-Lock" key on HP Omen Laptops which supports enabling and disabling the Windows key, which trigger commands
0x21a4and0x121a4respectively. Currently the hp-wmi driver throws warnings for this event. These can be ignored usingKE_IGNOREas the functionality is handled by the keyboard firmware itself.Signed-off-by Rishit Bansal <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 17 lines
--- drivers/platform/x86/hp/hp-wmi.c | 2 ++ 1 file changed, 2 insertions(+)drivers/platform/x86/hp/hp-wmi.c +2
-0@@ -216,6 +216,8 @@ static const struct key_entry hp_wmi_keymap[] = { { KE_KEY, 0x213b, { KEY_INFO } }, { KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } }, { KE_KEY, 0x216a, { KEY_SETUP } }, + { KE_IGNORE, 0x21a4, }, /* Win Lock On */ + { KE_IGNORE, 0x121a4, }, /* Win Lock Off */ { KE_KEY, 0x21a9, { KEY_TOUCHPAD_OFF } }, { KE_KEY, 0x121a9, { KEY_TOUCHPAD_ON } }, { KE_KEY, 0x231b, { KEY_HELP } },