small fixes
cover small fixes
This series contains small fixes for virtio and vhost.
Xiaolong Ye (2):
net/virtio: fix for out of date comment
vhost: remove unused variable
drivers/net/virtio/virtio_ethdev.c | 6 +++--- lib/librte_vhost/vhost.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/2 net/virtio: fix for out of date comment
Fix the comment that's incorrect as the code evolves.
--- drivers/net/virtio/virtio_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/virtio/virtio_ethdev.c +3 -3
@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) }if (!vtpci_packed_queue (hw) && !rte_is_power_of_2 (vq_size)) { -PMD_INIT_LOG (ERR ,"split virtqueue size is not powerof 2" ); +PMD_INIT_LOG (ERR ,"split virtqueue size is not power of 2" );return -EINVAL ; }
@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) hw->cvq = cvq; } -/* For virtio_user case (that is when hw->dev is NULL), we use -* virtual address. And we need properly set _offset_, please see +/* For virtio_user case (that is when hw->virtio_user_dev is not NULL), +* we use virtual address. And we need properly set _offset_, please see * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information. */ if (!hw->virtio_user_dev)
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment
Quoted 25 lines · Xiaolong Ye
Fix the comment that's incorrect as the code evolves.
Fixes 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")Signed-off-by Xiaolong Ye <[email protected]>--- drivers/net/virtio/virtio_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/virtio/virtio_ethdev.c +1
-1@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) }if (!vtpci_packed_queue (hw) && !rte_is_power_of_2 (vq_size)) { -PMD_INIT_LOG (ERR ,"split virtqueue size is not powerof 2" ); +PMD_INIT_LOG (ERR ,"split virtqueue size is not power of 2" );return -EINVAL ; }
drivers/net/virtio/virtio_ethdev.c virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) · line 595
Quoted 10 lines
drivers/net/virtio/virtio_ethdev.c +2
-2@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) hw->cvq = cvq; } -/* For virtio_user case (that is when hw->dev is NULL), we use -* virtual address. And we need properly set _offset_, please see +/* For virtio_user case (that is when hw->virtio_user_dev is not NULL), +* we use virtual address. And we need properly set _offset_, please see * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information. */ if (!hw->virtio_user_dev)
Thanks,
Maxime
PATCH 2/2 vhost: remove unused variable
In reply to Xiaolong YeVHOST_FEATURES has been removed in previous refactor.
--- lib/librte_vhost/vhost.h | 1 - 1 file changed, 1 deletion(-)
lib/librte_vhost/vhost.h +0 -1
@@ -543,7 +543,6 @@ extern int vhost_data_log_level;#define PRINT_PACKET (device, addr, size, header) do {} while (0)#endif -extern uint64_t VHOST_FEATURES ;#define MAX_VHOST_DEVICE 1024extern struct virtio_net *vhost_devices[MAX_VHOST_DEVICE ];
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v1 2/2] vhost: remove unused variable
Quoted 16 lines · Xiaolong Ye
VHOST_FEATUREShas been removed in previous refactor.Fixes 0917f9d1f059 ("vhost: use new APIs to handle features")Signed-off-by Xiaolong Ye <[email protected]>--- lib/librte_vhost/vhost.h | 1 - 1 file changed, 1 deletion(-)lib/librte_vhost/vhost.h +0
-0
lib/librte_vhost/vhost.h extern int vhost_data_log_level; · line 548
Quoted 7 lines
lib/librte_vhost/vhost.h +0
-1@@ -543,7 +543,6 @@ extern int vhost_data_log_level;#define PRINT_PACKET (device, addr, size, header) do {} while (0)#endif -extern uint64_t VHOST_FEATURES ;#define MAX_VHOST_DEVICE 1024extern struct virtio_net *vhost_devices[MAX_VHOST_DEVICE ];
Thanks,
Maxime
Maxime Coquelin
AppliedQuoted 10 lines · Xiaolong Ye
This series contains small fixes for virtio and vhost.
Xiaolong Ye (2):
net/virtio: fix for out of date comment
vhost: remove unused variabledrivers/net/virtio/virtio_ethdev.c | 6 +++--- lib/librte_vhost/vhost.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime