block: don't run get_page() on pages from non-bvec iov iter
PATCH 1/1 block: don't run get_page() on pages from non-bvec iov iter
The refcount has been increased for pages retrieved from non-bvec iov iter via __bio_iov_iter_get_pages(), so don't need to do that again.
Otherwise, IO pages are leaked easily.
--- block/bio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/bio.c +1 -1
@@ -992,7 +992,7 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)if (iov_iter_bvec_no_ref (iter))bio_set_flag (bio,BIO_NO_PAGE_REF ); -else +else if (is_bvec)bio_get_pages (bio);return bio->bi_vcnt ?0 : ret;
Signature · 1 line
2.9.5
Looks good.
Quoted 26 lines · Ming Lei
The refcount has been increased for pages retrieved from non-bvec iov iter via
__bio_iov_iter_get_pages(), so don't need to do that again.Otherwise, IO pages are leaked easily.
Cc Christoph Hellwig <[email protected]>Fixes 7321ecbfc7cf ("block: change how we get page references in bio_iov_iter_get_pages")Signed-off-by Ming Lei <[email protected]>--- block/bio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)block/bio.c +1
-1@@ -992,7 +992,7 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)if (iov_iter_bvec_no_ref (iter))bio_set_flag (bio,BIO_NO_PAGE_REF ); -else +else if (is_bvec)bio_get_pages (bio);return bio->bi_vcnt ?0 : ret;
Jens Axboe
maintainerQuoted 4 lines · Ming Lei
The refcount has been increased for pages retrieved from non-bvec iov iter via
__bio_iov_iter_get_pages(), so don't need to do that again.Otherwise, IO pages are leaked easily.
Thanks Ming, applied.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Ming Lei
The refcount has been increased for pages retrieved from non-bvec iov iter via
__bio_iov_iter_get_pages(), so don't need to do that again.Otherwise, IO pages are leaked easily.
Looks good,