License mismatched for libxshmfence_1.3.bb and recipeutils-test_1.2.bb
Hello,
The following two recipes use the similar sources, but their LICENSE are different in the recipe:
meta-selftest/recipes-test/recipeutils/recipeutils-test_1.2.bbSRC_URI = "http://xorg.freedesktop.org/releases/individual/lib/libxshmfence-1.2.tar.bz2" LICENSE = "Proprietary"
meta/recipes-graphics/xorg-lib/libxshmfence_1.3.bbSRC_URI = "https://www.x.org/releases//individual/lib/libxshmfence-1.3.tar.bz2" LICENSE = "MIT"
There is a COPYING file inside ibxshmfence-1.2.tar.bz2 and libxshmfence-1.3.tar.bz2, they exactly the same:
$ diff libxshmfence-1.2/COPYING libxshmfence-1.3/COPYING
Please check the end for the full contents of COPYING, it's not either MIT or Proprietary, but should be a free software.
How to fix the LICENSE name, please? Add a license file called libxshmfence? Any comments is appreciated.
Signature · 3 lines
Thanks Robert
Quoted 17 lines · Robert Yang
Hello,
The following two recipes use the similar sources, but their LICENSE are different in the recipe:
meta-selftest/recipes-test/recipeutils/recipeutils-test_1.2.bb
SRC_URI= "http://xorg.freedesktop.org/releases/individual/lib/libxshmfence-1.2.tar.bz2" LICENSE = "Proprietary"meta/recipes-graphics/xorg-lib/libxshmfence_1.3.bb
SRC_URI= "https://www.x.org/releases//individual/lib/libxshmfence-1.3.tar.bz2" LICENSE = "MIT"There is a COPYING file inside ibxshmfence-1.2.tar.bz2 and libxshmfence-1.3.tar.bz2, they exactly the same:
Quoted 7 lines
$ diff libxshmfence-1.2/COPYING libxshmfence-1.3/COPYINGPlease check the end for the full contents of COPYING, it's not either MIT or Proprietary, but should be a free software.
How to fix the LICENSE name, please? Add a license file called libxshmfence? Any comments is appreciated.
Having looked at a few SPDX licenses, I think this looks like HPND:
https://spdx.org/licenses/HPND.html
I suspect the license set in the recipeutils-test is there for testing purposes and not as a "real" license but we probably need to make that clear, or only modify it at runtime in the test.
Cheers,
Richard
Hi RP,
Thank you very much, I'm trying to run the test cases, but I found that you've already fixed them, thanks again.
// Robert
Quoted 40 lines · Richard Purdie
Quoted 17 lines · Robert Yang
Hello,
The following two recipes use the similar sources, but their LICENSE are different in the recipe:
meta-selftest/recipes-test/recipeutils/recipeutils-test_1.2.bb
SRC_URI= "http://xorg.freedesktop.org/releases/individual/lib/libxshmfence-1.2.tar.bz2" LICENSE = "Proprietary"meta/recipes-graphics/xorg-lib/libxshmfence_1.3.bb
SRC_URI= "https://www.x.org/releases//individual/lib/libxshmfence-1.3.tar.bz2" LICENSE = "MIT"There is a COPYING file inside ibxshmfence-1.2.tar.bz2 and libxshmfence-1.3.tar.bz2, they exactly the same:
Quoted 7 lines
$ diff libxshmfence-1.2/COPYING libxshmfence-1.3/COPYINGPlease check the end for the full contents of COPYING, it's not either MIT or Proprietary, but should be a free software.
How to fix the LICENSE name, please? Add a license file called libxshmfence? Any comments is appreciated.
Having looked at a few SPDX licenses, I think this looks like HPND:
https://spdx.org/licenses/HPND.html
I suspect the license set in the recipeutils-test is there for testing purposes and not as a "real" license but we probably need to make that clear, or only modify it at runtime in the test.
Cheers,
Richard
Quoted 2 lines · Robert Yang
Thank you very much, I'm trying to run the test cases, but I found that you've already fixed them, thanks again.
I don't know why it was set to proprietary in the test but it doesn't seem to cause any regressions so I removed it. It is at an older version which should mean it doesn't affect other builds so I'm happy to leave it on the older version.
Cheers,
Richard
Quoted 8 lines · Richard Purdie
Quoted 2 lines · Robert Yang
Thank you very much, I'm trying to run the test cases, but I found that you've already fixed them, thanks again.
I don't know why it was set to proprietary in the test but it doesn't seem to cause any regressions so I removed it. It is at an older version which should mean it doesn't affect other builds so I'm happy to leave it on the older version.
The following supported versions have the same problem, should we also fix them?
Dunfell
Hardknott
Honister
I'd like to send the patches after testing if we need fix them.
// Robert
Quoted 6 lines
Cheers,
Richard
Quoted 11 lines · Robert Yang
Quoted 8 lines · Richard Purdie
Quoted 2 lines · Robert Yang
Thank you very much, I'm trying to run the test cases, but I found that you've already fixed them, thanks again.
I don't know why it was set to proprietary in the test but it doesn't seem to cause any regressions so I removed it. It is at an older version which should mean it doesn't affect other builds so I'm happy to leave it on the older version.
Quoted 7 lines
The following supported versions have the same problem, should we also fix them?
Dunfell
Hardknott
HonisterI'd like to send the patches after testing if we need fix them.
It would seem reasonable although hardknott is due to have it's final build soon.
Cheers,
Richard