Skip to contentSkip to conversation

glusterfs/librdmacm: fix dependency issue with libibverbs

PATCH In review [email protected] 3 participants 5 messages Apr 17, 2019 – Apr 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glusterfs/librdmacm: fix dependency issue with libibverbs

From: Kai Kang <[email protected]>

glusterfs and librdmacm depend on libibverbs. But libibverbs has been set imcompatible with mipsarch and arm. Update glusterfs and librdmacm accordingly.

---
 recipes-extended/glusterfs/glusterfs.inc      | 3 +++
 recipes-extended/librdmacm/librdmacm_1.1.0.bb | 3 +++
 2 files changed, 6 insertions(+)
recipes-extended/glusterfs/glusterfs.inc +3 -0
index 5843d7c6..3fc04ffb 100644
@@ -51,6 +51,9 @@ EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \
                "
 
 PACKAGECONFIG ??= "georeplication libibverbs"
+PACKAGECONFIG_remove_mipsarch = "libibverbs"
+PACKAGECONFIG_remove_arm = "libibverbs"
+
 PACKAGECONFIG[bd-xlator] = "--enable-bd-xlator,--disable-bd-xlator,lvm2,"
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug,,"
 PACKAGECONFIG[georeplication] = "--enable-georeplication,--disable-georeplication,,rsync"
recipes-extended/librdmacm/librdmacm_1.1.0.bb +3 -0
index 30a0c943..edf92f01 100644
@@ -39,3 +39,6 @@ do_install_append() {
         rm -f ${D}${libdir}/librdmacm.la
         rm -f ${D}${libdir}/rsocket/librspreload.la
 }
+
+COMPATIBLE_HOST_mipsarch = "none"
+COMPATIBLE_HOST_arm = "none"
Signature · 1 line
2.20.0
#1 lore raw
Quoted 32 lines · On Wed, Apr 17, 2019 at 3:51 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

glusterfs and librdmacm depend on libibverbs. But libibverbs has been set imcompatible with mipsarch and arm. Update glusterfs and librdmacm accordingly.

---
 recipes-extended/glusterfs/glusterfs.inc      | 3 +++
 recipes-extended/librdmacm/librdmacm_1.1.0.bb | 3 +++
 2 files changed, 6 insertions(+)
recipes-extended/glusterfs/glusterfs.inc +3 -0
index 5843d7c6..3fc04ffb 100644
@@ -51,6 +51,9 @@ EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \
                "
 
 PACKAGECONFIG ??= "georeplication libibverbs"
+PACKAGECONFIG_remove_mipsarch = "libibverbs"
+PACKAGECONFIG_remove_arm = "libibverbs"
+
 PACKAGECONFIG[bd-xlator] = "--enable-bd-xlator,--disable-bd-xlator,lvm2,"
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug,,"
 PACKAGECONFIG[georeplication] = "--enable-georeplication,--disable-georeplication,,rsync"
recipes-extended/librdmacm/librdmacm_1.1.0.bb +0 -0
index 30a0c943..edf92f01 100644

recipes-extended/librdmacm/librdmacm_1.1.0.bb do_install_append() { · line 44

Quoted 6 lines
recipes-extended/librdmacm/librdmacm_1.1.0.bb +3 -0
@@ -39,3 +39,6 @@ do_install_append() {
         rm -f ${D}${libdir}/librdmacm.la
         rm -f ${D}${libdir}/rsocket/librspreload.la
 }
+
+COMPATIBLE_HOST_mipsarch = "none"
+COMPATIBLE_HOST_arm = "none"

This should be a separate commit. We shouldn't mix the default packageconfig change
and the marking of librdmacm as incompatible with mips/arm into the same commit.

In particular, since I'd like the error message you get if librdmacm is compiled for arm/mips
to be logged in the commit where we make it incompatible.

Bruce

Quoted 3 lines

--
2.20.0

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#2 lore raw

Comments inline, preceded by [Joe Slater]. Sorry, but I'm using outlook...

-----Original Message-----
From: Bruce Ashfield [mailto:[email protected]]
Sent: Thursday, April 18, 2019 6:13 AM
To: Kang, Kai
Cc: [email protected]; Slater, Joseph
Subject: Re: [meta-virtualization][m-c-s][PATCH] glusterfs/librdmacm: fix dependency issue with libibverbs

Quoted 18 lines · On Wed, Apr 17, 2019 at 3:51 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

glusterfs and librdmacm depend on libibverbs. But libibverbs has been set imcompatible with mipsarch and arm. Update glusterfs and librdmacm accordingly.

---
 recipes-extended/glusterfs/glusterfs.inc      | 3 +++
 recipes-extended/librdmacm/librdmacm_1.1.0.bb | 3 +++
 2 files changed, 6 insertions(+)
recipes-extended/glusterfs/glusterfs.inc +0 -0
index 5843d7c6..3fc04ffb 100644

recipes-extended/glusterfs/glusterfs.inc EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \ · line 55

Quoted 5 lines
recipes-extended/glusterfs/glusterfs.inc +2 -0
@@ -51,6 +51,9 @@ EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \
                "
 
 PACKAGECONFIG ??= "georeplication libibverbs"
+PACKAGECONFIG_remove_mipsarch = "libibverbs"
+PACKAGECONFIG_remove_arm = "libibverbs"

[Joe Slater]
Because this removes libibverbs from all PACKAGECONG's, I think it would be better to set the lazy default via a local variable.

Quoted 9 lines
recipes-extended/glusterfs/glusterfs.inc +1 -0
+
 PACKAGECONFIG[bd-xlator] = "--enable-bd-xlator,--disable-bd-xlator,lvm2,"
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug,,"
 PACKAGECONFIG[georeplication] = "--enable-georeplication,--disable-georeplication,,rsync"
recipes-extended/librdmacm/librdmacm_1.1.0.bb +0 -0
index 30a0c943..edf92f01 100644

recipes-extended/librdmacm/librdmacm_1.1.0.bb do_install_append() { · line 44

Quoted 6 lines
recipes-extended/librdmacm/librdmacm_1.1.0.bb +3 -0
@@ -39,3 +39,6 @@ do_install_append() {
         rm -f ${D}${libdir}/librdmacm.la
         rm -f ${D}${libdir}/rsocket/librspreload.la
 }
+
+COMPATIBLE_HOST_mipsarch = "none"
+COMPATIBLE_HOST_arm = "none"

[Joe Slater]
Maybe an exclusion for world would be better, because this restriction will be gone when the libibverbs provider is fixed.

This should be a separate commit. We shouldn't mix the default packageconfig change
and the marking of librdmacm as incompatible with mips/arm into the same commit.

In particular, since I'd like the error message you get if librdmacm is compiled for arm/mips
to be logged in the commit where we make it incompatible.

Bruce

Quoted 3 lines

--
2.20.0

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#3 lore raw
Quoted 29 lines · Joseph

Comments inline, preceded by [Joe Slater]. Sorry, but I'm using outlook...

-----Original Message-----
From: Bruce Ashfield [mailto:[email protected]]
Sent: Thursday, April 18, 2019 6:13 AM
To: Kang, Kai
Cc: [email protected]; Slater, Joseph
Subject: Re: [meta-virtualization][m-c-s][PATCH] glusterfs/librdmacm: fix dependency issue with libibverbs

Quoted 19 lines · On Wed, Apr 17, 2019 at 3:51 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

glusterfs and librdmacm depend on libibverbs. But libibverbs has been set imcompatible with mipsarch and arm. Update glusterfs and librdmacm accordingly.

---
  recipes-extended/glusterfs/glusterfs.inc      | 3 +++
  recipes-extended/librdmacm/librdmacm_1.1.0.bb | 3 +++
  2 files changed, 6 insertions(+)
recipes-extended/glusterfs/glusterfs.inc +0 -0
index 5843d7c6..3fc04ffb 100644
@@ -51,6 +51,9 @@ EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \
                 "
 
Quoted 5 lines

recipes-extended/glusterfs/glusterfs.inc EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \ · line 55

Quoted 3 lines
recipes-extended/glusterfs/glusterfs.inc +2 -0
  PACKAGECONFIG ??= "georeplication libibverbs"
+PACKAGECONFIG_remove_mipsarch = "libibverbs"
+PACKAGECONFIG_remove_arm = "libibverbs"

[Joe Slater]
Because this removes libibverbs from all PACKAGECONG's, I think it would be better to set the lazy default via a local variable.

Hi Joe,

It seems just remove "libibverbs" for _arm and _mipsarch,  isn't it?

Quoted 10 lines
Quoted 10 lines
recipes-extended/glusterfs/glusterfs.inc +1 -0
+
  PACKAGECONFIG[bd-xlator] = "--enable-bd-xlator,--disable-bd-xlator,lvm2,"
  PACKAGECONFIG[debug] = "--enable-debug,--disable-debug,,"
  PACKAGECONFIG[georeplication] = "--enable-georeplication,--disable-georeplication,,rsync"
recipes-extended/librdmacm/librdmacm_1.1.0.bb +0 -0
index 30a0c943..edf92f01 100644
@@ -39,3 +39,6 @@ do_install_append() {
Quoted 8 lines

recipes-extended/librdmacm/librdmacm_1.1.0.bb do_install_append() { · line 44

Quoted 6 lines
recipes-extended/librdmacm/librdmacm_1.1.0.bb +3 -0
          rm -f ${D}${libdir}/librdmacm.la
          rm -f ${D}${libdir}/rsocket/librspreload.la
  }
+
+COMPATIBLE_HOST_mipsarch = "none"
+COMPATIBLE_HOST_arm = "none"

[Joe Slater]
Maybe an exclusion for world would be better, because this restriction will be gone when the libibverbs provider is fixed.

It depends on what strategy we perfer.

If set COMPATIBLE_HOST, when build librdmacm, it shows error message:

ERROR: Nothing PROVIDES 'librdmacm'
librdmacm was skipped: incompatible with host arm-wrs-linux-gnueabi (not in COMPATIBLE_HOST)

If set exclude from world, run 'bitbake librdmacm' shows following errors:

NOTE: Resolving any missing task queue dependencies
ERROR: Nothing PROVIDES 'virtual/libibverbs' (but /home/kkang/buildarea/wrlx-201902/repo/layers/meta-cloud-services/recipes-extended/librdmacm/librdmacm_1.1.0.bb DEPENDS on or otherwise requires it) libibverbs PROVIDES virtual/libibverbs but was skipped: incompatible with host arm-wrs-linux-gnueabi (not in COMPATIBLE_HOST)
ERROR: Required build target 'librdmacm' has no buildable providers.
Missing or unbuildable dependency chain was: ['librdmacm', 'virtual/libibverbs']

I prefer COMPATIBLE_HOST way myself because the error message is a little clear.

Regards,
Kai

Quoted 15 lines

This should be a separate commit. We shouldn't mix the default packageconfig change
and the marking of librdmacm as incompatible with mips/arm into the same commit.

In particular, since I'd like the error message you get if librdmacm is compiled for arm/mips
to be logged in the commit where we make it incompatible.

Bruce

Quoted 3 lines

--
2.20.0

Signature · 1 line
Kai Kang
author
#4 lore raw
In reply to Bruce Ashfield
Quoted 33 lines · Bruce Ashfield
Quoted 32 lines · On Wed, Apr 17, 2019 at 3:51 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

glusterfs and librdmacm depend on libibverbs. But libibverbs has been set imcompatible with mipsarch and arm. Update glusterfs and librdmacm accordingly.

---
  recipes-extended/glusterfs/glusterfs.inc      | 3 +++
  recipes-extended/librdmacm/librdmacm_1.1.0.bb | 3 +++
  2 files changed, 6 insertions(+)
recipes-extended/glusterfs/glusterfs.inc +3 -0
index 5843d7c6..3fc04ffb 100644
@@ -51,6 +51,9 @@ EXTRA_OECONF = "ac_cv_file__etc_debian_version=no \
                 "
 
  PACKAGECONFIG ??= "georeplication libibverbs"
+PACKAGECONFIG_remove_mipsarch = "libibverbs"
+PACKAGECONFIG_remove_arm = "libibverbs"
+
  PACKAGECONFIG[bd-xlator] = "--enable-bd-xlator,--disable-bd-xlator,lvm2,"
  PACKAGECONFIG[debug] = "--enable-debug,--disable-debug,,"
  PACKAGECONFIG[georeplication] = "--enable-georeplication,--disable-georeplication,,rsync"
recipes-extended/librdmacm/librdmacm_1.1.0.bb +0 -0
index 30a0c943..edf92f01 100644
@@ -39,3 +39,6 @@ do_install_append() {
          rm -f ${D}${libdir}/librdmacm.la
Quoted 8 lines

recipes-extended/librdmacm/librdmacm_1.1.0.bb do_install_append() { · line 44

Quoted 5 lines
recipes-extended/librdmacm/librdmacm_1.1.0.bb +3 -0
          rm -f ${D}${libdir}/rsocket/librspreload.la
  }
+
+COMPATIBLE_HOST_mipsarch = "none"
+COMPATIBLE_HOST_arm = "none"

This should be a separate commit. We shouldn't mix the default packageconfig change
and the marking of librdmacm as incompatible with mips/arm into the same commit.

OK.

Quoted 4 lines

In particular, since I'd like the error message you get if librdmacm is compiled for arm/mips
to be logged in the commit where we make it incompatible.

Got it. Thanks.

Kai

Quoted 7 lines

Bruce

Quoted 3 lines

--
2.20.0

Signature · 1 line
Kai Kang