Skip to contentSkip to conversation

ARM: dts: Fix more boolean properties with values

PATCH Applied Rob Herring 4 participants 4 messages Apr 7, 2022 – Apr 14, 2022

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: Fix more boolean properties with values

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Cc Krzysztof Kozlowski <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc "Benoît Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts            | 2 +-
 arch/arm/boot/dts/imx28-ts4600.dts               | 2 +-
 arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++--
 arch/arm/boot/dts/qcom-ipq8064.dtsi              | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/boot/dts/at91-sam9_l9260.dts +1 -1
index 1e2a28c2f365..2fb51b9aca2a 100644
@@ -101,7 +101,7 @@ pinctrl_board_mmc0: mmc0-board {
 		nand0: nand@40000000 {
 			nand-bus-width = <8>;
 			nand-ecc-mode = "soft";
-			nand-on-flash-bbt = <1>;
+			nand-on-flash-bbt;
 			status = "okay";
 		};
 
arch/arm/boot/dts/imx28-ts4600.dts +1 -1
index 097ec35c62d8..0d58da1c0cc5 100644
@@ -26,7 +26,7 @@ ssp0: spi@80010000 {
 				pinctrl-0 = <&mmc0_4bit_pins_a
 					     &mmc0_sck_cfg
 					     &en_sd_pwr>;
-				broken-cd = <1>;
+				broken-cd;
 				bus-width = <4>;
 				vmmc-supply = <&reg_vddio_sd0>;
 				status = "okay";
arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi +2 -2
index b4664ab00256..d3da8b1b473b 100644
@@ -118,8 +118,8 @@ usb@6,0 {
 		gpmc,device-width = <2>;
 		gpmc,wait-pin = <0>;
 		gpmc,burst-length = <4>;
-		gpmc,cycle2cycle-samecsen = <1>;
-		gpmc,cycle2cycle-diffcsen = <1>;
+		gpmc,cycle2cycle-samecsen;
+		gpmc,cycle2cycle-diffcsen;
 		gpmc,cs-on-ns = <0>;
 		gpmc,cs-rd-off-ns = <45>;
 		gpmc,cs-wr-off-ns = <45>;
arch/arm/boot/dts/qcom-ipq8064.dtsi +4 -4
index 996f4458d9fc..8cb04aa8ed2f 100644
@@ -972,7 +972,7 @@ gmac0: ethernet@37000000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -996,7 +996,7 @@ gmac1: ethernet@37200000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -1020,7 +1020,7 @@ gmac2: ethernet@37400000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -1044,7 +1044,7 @@ gmac3: ethernet@37600000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Rob Herring

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Cc Krzysztof Kozlowski <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc "Benoît Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Quoted 2 lines
---
 arch/arm/boot/dts/at91-sam9_l9260.dts            | 2 +-

For this one:

Quoted 5 lines
 arch/arm/boot/dts/imx28-ts4600.dts               | 2 +-
 arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++--
 arch/arm/boot/dts/qcom-ipq8064.dtsi              | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 24 lines · Rob Herring

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

Cc Krzysztof Kozlowski <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc "Benoît Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Quoted 5 lines
---
 arch/arm/boot/dts/at91-sam9_l9260.dts            | 2 +-
 arch/arm/boot/dts/imx28-ts4600.dts               | 2 +-
 arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++--
 arch/arm/boot/dts/qcom-ipq8064.dtsi              | 8 ++++----

Regards,
Bjorn

Quoted 86 lines
 4 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/boot/dts/at91-sam9_l9260.dts +1 -1
index 1e2a28c2f365..2fb51b9aca2a 100644
@@ -101,7 +101,7 @@ pinctrl_board_mmc0: mmc0-board {
 		nand0: nand@40000000 {
 			nand-bus-width = <8>;
 			nand-ecc-mode = "soft";
-			nand-on-flash-bbt = <1>;
+			nand-on-flash-bbt;
 			status = "okay";
 		};
 
arch/arm/boot/dts/imx28-ts4600.dts +1 -1
index 097ec35c62d8..0d58da1c0cc5 100644
@@ -26,7 +26,7 @@ ssp0: spi@80010000 {
 				pinctrl-0 = <&mmc0_4bit_pins_a
 					     &mmc0_sck_cfg
 					     &en_sd_pwr>;
-				broken-cd = <1>;
+				broken-cd;
 				bus-width = <4>;
 				vmmc-supply = <&reg_vddio_sd0>;
 				status = "okay";
arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi +2 -2
index b4664ab00256..d3da8b1b473b 100644
@@ -118,8 +118,8 @@ usb@6,0 {
 		gpmc,device-width = <2>;
 		gpmc,wait-pin = <0>;
 		gpmc,burst-length = <4>;
-		gpmc,cycle2cycle-samecsen = <1>;
-		gpmc,cycle2cycle-diffcsen = <1>;
+		gpmc,cycle2cycle-samecsen;
+		gpmc,cycle2cycle-diffcsen;
 		gpmc,cs-on-ns = <0>;
 		gpmc,cs-rd-off-ns = <45>;
 		gpmc,cs-wr-off-ns = <45>;
arch/arm/boot/dts/qcom-ipq8064.dtsi +4 -4
index 996f4458d9fc..8cb04aa8ed2f 100644
@@ -972,7 +972,7 @@ gmac0: ethernet@37000000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -996,7 +996,7 @@ gmac1: ethernet@37200000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -1020,7 +1020,7 @@ gmac2: ethernet@37400000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
@@ -1044,7 +1044,7 @@ gmac3: ethernet@37600000 {
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,pbl = <32>;
-			snps,aal = <1>;
+			snps,aal;
 
 			qcom,nss-common = <&nss_common>;
 			qcom,qsgmii-csr = <&qsgmii_csr>;
Signature · 1 line
2.32.0
#3 lore raw
In reply to Rob Herring
This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <[email protected]>:

Quoted 8 lines · On Thu, 7 Apr 2022 17:51:07 -0500 you wrote:

Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter.

It may have been intended that 0 values are false, but there is no change in behavior with this patch.

[...]

Here is the summary with links:
- ARM: dts: Fix more boolean properties with values

    https://git.kernel.org/soc/soc/c/558bd89edc06

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html