Skip to contentSkip to conversation

arndale: fix unknown status

PATCH New Minkyu Kang 3 participants 8 messages Mar 14, 2019 – Mar 15, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20190314004445epcas1p3ace241b1a00f3237790cb95e2d338794@epcas1p3.samsung.com

#1 lore raw

PATCH 1/1 arndale: fix unknown status

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/arndale/MAINTAINERS +1 -1
index 98ccaa4..aa64c7a 100644
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:	Krzysztof Kozlowski <[email protected]>
-S:	Odd Fixes
+S:	Maintained
 F:	board/samsung/arndale/
 F:	include/configs/arndale.h
 F:	configs/arndale_defconfig
Signature · 4 lines
1.9.1
-- 
Thanks,
Minkyu Kang.
#2 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 14 lines · Minkyu Kang

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/arndale/MAINTAINERS +0 -0
index 98ccaa4..aa64c7a 100644

board/samsung/arndale/MAINTAINERS line 6

Quoted 7 lines
board/samsung/arndale/MAINTAINERS +1 -1
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:	Krzysztof Kozlowski <[email protected]>
-S:	Odd Fixes
+S:	Maintained
 F:	board/samsung/arndale/
 F:	include/configs/arndale.h
 F:	configs/arndale_defconfig

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

#3 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 10 lines · Minkyu Kang
Quoted 8 lines · Minkyu Kang

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

board/samsung/arndale/MAINTAINERS line 6

Quoted 13 lines
board/samsung/arndale/MAINTAINERS +1 -1
index 98ccaa4..aa64c7a 100644
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:   Krzysztof Kozlowski <[email protected]>
-S:   Odd Fixes
+S:   Maintained
 F:   board/samsung/arndale/
 F:   include/configs/arndale.h
 F:   configs/arndale_defconfig

applied to u-boot-samsung.

Hi,

In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained?

Best regards,
Krzysztof

#4 lore raw

PATCH 1/1 arndale: fix unknown status

Hi,

Quoted 27 lines · Krzysztof Kozlowski
Quoted 10 lines · Minkyu Kang
Quoted 8 lines · Minkyu Kang

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

board/samsung/arndale/MAINTAINERS line 6

Quoted 13 lines
board/samsung/arndale/MAINTAINERS +1 -1
index 98ccaa4..aa64c7a 100644
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:   Krzysztof Kozlowski <[email protected]>
-S:   Odd Fixes
+S:   Maintained
 F:   board/samsung/arndale/
 F:   include/configs/arndale.h
 F:   configs/arndale_defconfig

applied to u-boot-samsung.

Quoted 7 lines

Hi,

In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained?

$ ./tools/genboardscfg.py -f
WARNING: Odd Fixes: unknown status for 'arndale'

If you don't want to maintain then, it would be set to Orphan?

Thanks,
Minkyu Kang.

#5 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 39 lines · Minkyu Kang

Hi,

Quoted 27 lines · Krzysztof Kozlowski
Quoted 10 lines · Minkyu Kang
Quoted 8 lines · Minkyu Kang

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

board/samsung/arndale/MAINTAINERS line 6

Quoted 13 lines
board/samsung/arndale/MAINTAINERS +1 -1
index 98ccaa4..aa64c7a 100644
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:   Krzysztof Kozlowski <[email protected]>
-S:   Odd Fixes
+S:   Maintained
 F:   board/samsung/arndale/
 F:   include/configs/arndale.h
 F:   configs/arndale_defconfig

applied to u-boot-samsung.

Quoted 7 lines

Hi,

In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained?

Quoted 4 lines
$ ./tools/genboardscfg.py -f
WARNING: Odd Fixes: unknown status for 'arndale'

If you don't want to maintain then, it would be set to Orphan?

I think then the genboardscfg.py should be updated because "Odd fixer" is a valid entry from MAINTAINERS (although not popular).
"Odd Fixes: It has a maintainer but they don't have time to do much
other than throw the odd patch in. See below.."
The board is pretty close to being orphaned but not yet.

Best regards,
Krzysztof

#6 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 43 lines · Krzysztof Kozlowski
Quoted 42 lines · Minkyu Kang

Hi,

Quoted 27 lines · Krzysztof Kozlowski
Quoted 10 lines · Minkyu Kang
Quoted 8 lines · Minkyu Kang

set status to Maintained

Cc Krzysztof Kozlowski <[email protected]>
---
 board/samsung/arndale/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

board/samsung/arndale/MAINTAINERS line 6

Quoted 13 lines
board/samsung/arndale/MAINTAINERS +1 -1
index 98ccaa4..aa64c7a 100644
@@ -1,6 +1,6 @@
 ARNDALE BOARD
 M:   Krzysztof Kozlowski <[email protected]>
-S:   Odd Fixes
+S:   Maintained
 F:   board/samsung/arndale/
 F:   include/configs/arndale.h
 F:   configs/arndale_defconfig

applied to u-boot-samsung.

Quoted 7 lines

Hi,

In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained?

$ ./tools/genboardscfg.py -f
WARNING: Odd Fixes: unknown status for 'arndale'
Quoted 7 lines
Quoted 1 line

If you don't want to maintain then, it would be set to Orphan?

I think then the genboardscfg.py should be updated because "Odd fixer" is a valid entry from MAINTAINERS (although not popular).
"Odd Fixes: It has a maintainer but they don't have time to do much
other than throw the odd patch in. See below.."
The board is pretty close to being orphaned but not yet.

I'm taking your patch to the MAINTAINERS file now. That said, generally "odd fixes" are what's required of board maintainers, once the port is in. However, as we push forward on moving to various frameworks that should make life easier overall, over the long term, changes are needed that may be more than just an occasional fix. Looking at arndale right now for example:
arm: w+ arndale
+(arndale) ===================== WARNING ====================== +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove +(arndale) (possibly in a subsequent patch in your series) +(arndale) before sending patches to the mailing list. +(arndale) ====================================================

So, do you have time to look into that build time warning? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190314/1292c6b5/attachment.sig>
#7 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 13 lines · Tom Rini

I'm taking your patch to the MAINTAINERS file now. That said, generally "odd fixes" are what's required of board maintainers, once the port is in. However, as we push forward on moving to various frameworks that should make life easier overall, over the long term, changes are needed that may be more than just an occasional fix. Looking at arndale right now for example:
arm: w+ arndale

(quoted diff) +5 -0
+(arndale) ===================== WARNING ======================
+(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove
+(arndale) (possibly in a subsequent patch in your series)
+(arndale) before sending patches to the mailing list.
+(arndale) ====================================================
Quoted 1 line

So, do you have time to look into that build time warning? Thanks!

Sure, let me take a look.

Best regards,
Krzysztof

#8 lore raw

PATCH 1/1 arndale: fix unknown status

Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · Tom Rini

I'm taking your patch to the MAINTAINERS file now. That said, generally "odd fixes" are what's required of board maintainers, once the port is in. However, as we push forward on moving to various frameworks that should make life easier overall, over the long term, changes are needed that may be more than just an occasional fix. Looking at arndale right now for example:
arm: w+ arndale

(quoted diff) +5 -0
+(arndale) ===================== WARNING ======================
+(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove
+(arndale) (possibly in a subsequent patch in your series)
+(arndale) before sending patches to the mailing list.
+(arndale) ====================================================
Quoted 3 lines
Quoted 1 line

So, do you have time to look into that build time warning? Thanks!

Sure, let me take a look.

Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190315/82f61f42/attachment.sig>