Skip to contentSkip to conversation

github: fix config mistake preventing repo lockdown commenting

PATCH In review Daniel P. Berrangé 2 participants 2 messages Mar 23, 2022 – Mar 28, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 github: fix config mistake preventing repo lockdown commenting

The config key names were all wrong, resulting in the repo lockdown throwing warnings:

Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull', valid inputs are ['github-token', 'exclude-issue-created-before', 'exclude-issue-labels', 'issue-labels', 'issue-comment', 'skip-closed-issue-comment', 'close-issue', 'lock-issue', 'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels', 'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr', 'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']

It still locked down the pull requests, due to its default config, but didn't leave the friendly message explaining why.

---
 .github/workflows/lockdown.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
.github/workflows/lockdown.yml +3 -3
index ad8b8f7e30..d5e1265cff 100644
@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: dessant/repo-lockdown@v2
         with:
-          pull-comment: |
+          pr-comment: |
             Thank you for your interest in the QEMU project.
 
             This repository is a read-only mirror of the project's repostories hosted
@@ -26,5 +26,5 @@ jobs:
             functionality). However, we get a lot of patches, and so we have some
             guidelines about contributing on the project website:
             https://www.qemu.org/contribute/
-          lock-pull: true
-          close-pull: true
+          lock-pr: true
+          close-pr: true
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Daniel P. Berrangé

The config key names were all wrong,

Since commit 2b678923bb@repo-lockdown (22 Aug 2020, 2 years ago...):

feat: move to GitHub Actions

BREAKING CHANGE: The deployment method and configuration options have changed.

https://github.com/dessant/repo-lockdown/commit/2b678923bbf2df051

Quoted 11 lines

resulting in the repo lockdown
throwing warnings:

Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull', valid inputs are ['github-token', 'exclude-issue-created-before', 'exclude-issue-labels', 'issue-labels', 'issue-comment', 'skip-closed-issue-comment', 'close-issue', 'lock-issue', 'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels', 'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr', 'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']

Quoted 7 lines

It still locked down the pull requests, due to its default config, but didn't leave the friendly message explaining why.

---
  .github/workflows/lockdown.yml | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Preferably with description tweaked: