ARM: dts: socfpga: Fix NAND controller node compatible

PATCH New Marek Vasut 3 participants 7 messages May 10, 2018 – May 14, 2018 Device tree bindings

Share & tools

Marek Vasut

author

2018-05-10 12:52 UTC #0 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.

Signed-off-by Marek Vasut <[email protected]>

Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")

Cc Steffen Trumtrar <[email protected]>

Cc Dinh Nguyen <[email protected]>

---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/socfpga.dtsi +1 -1

index 7e24dc8e82d4..d697f5062624 100644
@@ -744,7 +744,7 @@
 		nand0: nand at ff900000 {
 			#address-cells = <0x1>;
 			#size-cells = <0x1>;
-			compatible = "denali,denali-nand-dt";
+			compatible = "altr,socfpga-denali-nand";
 			reg = <0xff900000 0x100000>,
 			      <0xffb80000 0x10000>;
 			reg-names = "nand_data", "denali_reg";

Signature · 1 line

2.16.2

Steffen Trumtrar

2018-05-14 07:11 UTC #1 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

Quoted 20 lines · Marek Vasut

The compatible string for the Denali NAND controller is incorrect,
fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller
nodes")
Cc: Steffen Trumtrar <[email protected]>
Cc: Dinh Nguyen <[email protected]>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644

arch/arm/boot/dts/socfpga.dtsi line 750

Quoted 8 lines

arch/arm/boot/dts/socfpga.dtsi +1 -1

@@ -744,7 +744,7 @@
 		nand0: nand at ff900000 {
 			#address-cells = <0x1>;
 			#size-cells = <0x1>;
-			compatible = "denali,denali-nand-dt";
+			compatible = "altr,socfpga-denali-nand";
 			reg = <0xff900000 0x100000>,
 			      <0xffb80000 0x10000>;
 			reg-names = "nand_data", "denali_reg";

Ack. As the binding was changed after d837a80d19 this is obviously correct.

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Thanks,
Steffen

Signature · 8 lines

Pengutronix e.K.                           | Steffen Trumtrar 
|
Industrial Linux Solutions                 | 
http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: 
+49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax: 
+49-5121-206917-5555 |

Dinh Nguyen

2018-05-14 15:11 UTC #2 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

Quoted 33 lines · Steffen Trumtrar

Quoted 18 lines · Marek Vasut
The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
?arch/arm/boot/dts/socfpga.dtsi | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644
arch/arm/boot/dts/socfpga.dtsi line 750
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -744,7 +744,7 @@
 ???????? nand0: nand at ff900000 {
 ???????????? #address-cells = <0x1>;
 ???????????? #size-cells = <0x1>;
-??????????? compatible = "denali,denali-nand-dt";
+??????????? compatible = "altr,socfpga-denali-nand";
 ???????????? reg = <0xff900000 0x100000>,
 ?????????????????? <0xffb80000 0x10000>;
 ???????????? reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously correct.

Quoted 3 lines

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh

Dinh Nguyen

2018-05-14 15:11 UTC #3 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

In reply to Steffen Trumtrar

Quoted 33 lines · Steffen Trumtrar

Quoted 18 lines · Marek Vasut
The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
?arch/arm/boot/dts/socfpga.dtsi | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644
arch/arm/boot/dts/socfpga.dtsi line 750
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -744,7 +744,7 @@
 ???????? nand0: nand at ff900000 {
 ???????????? #address-cells = <0x1>;
 ???????????? #size-cells = <0x1>;
-??????????? compatible = "denali,denali-nand-dt";
+??????????? compatible = "altr,socfpga-denali-nand";
 ???????????? reg = <0xff900000 0x100000>,
 ?????????????????? <0xffb80000 0x10000>;
 ???????????? reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously correct.

Quoted 3 lines

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh

Dinh Nguyen

2018-05-14 15:11 UTC #4 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

In reply to Steffen Trumtrar

Quoted 33 lines · Steffen Trumtrar

Quoted 18 lines · Marek Vasut
The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
?arch/arm/boot/dts/socfpga.dtsi | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644
arch/arm/boot/dts/socfpga.dtsi line 750
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -744,7 +744,7 @@
 ???????? nand0: nand at ff900000 {
 ???????????? #address-cells = <0x1>;
 ???????????? #size-cells = <0x1>;
-??????????? compatible = "denali,denali-nand-dt";
+??????????? compatible = "altr,socfpga-denali-nand";
 ???????????? reg = <0xff900000 0x100000>,
 ?????????????????? <0xffb80000 0x10000>;
 ???????????? reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously correct.

Quoted 3 lines

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Patch applied and cc'd stable kernel.

Will clean up arria10.

Thanks,
Dinh

Dinh Nguyen

2018-05-14 15:21 UTC #5 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

In reply to Steffen Trumtrar

Quoted 33 lines · Steffen Trumtrar

Quoted 18 lines · Marek Vasut
The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
?arch/arm/boot/dts/socfpga.dtsi | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644
arch/arm/boot/dts/socfpga.dtsi line 750
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -744,7 +744,7 @@
 ???????? nand0: nand at ff900000 {
 ???????????? #address-cells = <0x1>;
 ???????????? #size-cells = <0x1>;
-??????????? compatible = "denali,denali-nand-dt";
+??????????? compatible = "altr,socfpga-denali-nand";
 ???????????? reg = <0xff900000 0x100000>,
 ?????????????????? <0xffb80000 0x10000>;
 ???????????? reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously correct.

Quoted 3 lines

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Applied and cc'd stable.

Will fix up for Arria10.

Thanks

Dinh

Dinh Nguyen

2018-05-14 15:21 UTC #6 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller node compatible

In reply to Steffen Trumtrar

Quoted 33 lines · Steffen Trumtrar

Quoted 18 lines · Marek Vasut
The compatible string for the Denali NAND controller is incorrect, fix it by replacing it with one matching the DT bindings and the driver.
Signed-off-by Marek Vasut <[email protected]>
Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
?arch/arm/boot/dts/socfpga.dtsi | 2 +-
?1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index 7e24dc8e82d4..d697f5062624 100644
arch/arm/boot/dts/socfpga.dtsi line 750
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -744,7 +744,7 @@
 ???????? nand0: nand at ff900000 {
 ???????????? #address-cells = <0x1>;
 ???????????? #size-cells = <0x1>;
-??????????? compatible = "denali,denali-nand-dt";
+??????????? compatible = "altr,socfpga-denali-nand";
 ???????????? reg = <0xff900000 0x100000>,
 ?????????????????? <0xffb80000 0x10000>;
 ???????????? reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously correct.

Quoted 3 lines

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.

Applied and cc'd stable.

Will fix up for Arria10.

Thanks

Dinh