Skip to contentSkip to conversation

ARM: dts: socfpga: arria10: add aliases for ethernet

PATCH New Steffen Trumtrar 2 participants 4 messages Sep 28, 2018 – Oct 8, 2018 Device tree bindings

lore
Share & tools
lore

Steffen Trumtrar

author
#0 lore raw

PATCH 1/1 ARM: dts: socfpga: arria10: add aliases for ethernet

The stmmac driver uses the alias id to enumerate multiple ethernet devices. Add the aliases for ethernet, so multiple ethernet ports can be enabled without errors.

Signed-off-by Steffen Trumtrar <[email protected]>
---
 arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/socfpga_arria10.dtsi +7 -0
index a4dcb68f4322..9d490f907c98 100644
@@ -21,6 +21,13 @@
 	#address-cells = <1>;
 	#size-cells = <1>;
 
+	aliases {
+		ethernet0 = &gmac0;
+		ethernet1 = &gmac1;
+		ethernet2 = &gmac2;
+	};
+
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.19.0
Applied
#1 lore raw

PATCH 1/1 ARM: dts: socfpga: arria10: add aliases for ethernet

Quoted 9 lines · Steffen Trumtrar

The stmmac driver uses the alias id to enumerate multiple ethernet devices. Add the aliases for ethernet, so multiple ethernet ports can be enabled without errors.

Signed-off-by Steffen Trumtrar <[email protected]>
---
 arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks!

Dinh

#2 lore raw

PATCH 1/1 ARM: dts: socfpga: arria10: add aliases for ethernet

Quoted 7 lines · Dinh Nguyen
Quoted 4 lines · Steffen Trumtrar

The stmmac driver uses the alias id to enumerate multiple ethernet devices. Add the aliases for ethernet, so multiple ethernet ports can be enabled without errors.

Quoted 7 lines
Quoted 5 lines
Signed-off-by Steffen Trumtrar <[email protected]>
---
 arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks!

I don't think we can add these ethernet aliases to the base arria10 dtsi file. The reason is that different boards may elect to use other gmacs instead of gmac0.

Do you agree?

Dinh

author
#3 lore raw

PATCH 1/1 ARM: dts: socfpga: arria10: add aliases for ethernet

Quoted 18 lines · Dinh Nguyen
Quoted 9 lines · Dinh Nguyen
Quoted 6 lines · Steffen Trumtrar

The stmmac driver uses the alias id to enumerate multiple ethernet devices.
Add the aliases for ethernet, so multiple ethernet ports can be enabled
without errors.

Quoted 7 lines
Quoted 5 lines
Signed-off-by Steffen Trumtrar <[email protected]>
---
 arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks!

Quoted 8 lines

I don't think we can add these ethernet aliases to the base arria10 dtsi
file. The reason is that different boards may elect to use other gmacs
instead of gmac0.

Do you agree?

Ack. I was following socfpga.dtsi, but I'm going to fix it instead of following it ;-)

Steffen

Signature · 8 lines
Pengutronix e.K.                          | Steffen Trumtrar 
|
Industrial Linux Solutions                | 
http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany| Phone: 
+49-5121-206917-0   |
Amtsgericht Hildesheim, HRA 2686          | Fax: 
+49-5121-206917-5555|