devtools: Add recipe for Chromium Embedded Controller utilities
PATCH v3 1/1 devtools: Add recipe for Chromium Embedded Controller utilities
Add a recipe to build 'ectool' a utility to interact with the embedded controller on Google's chromebooks (and other platforms using it).
---
Changes from v1:
- Replaced DESCRIPTION with SUMMARY (Martin)
- Use EXTRA_OEMAKE (Martin)
- Removed FILESEXTRAPATHS (Martin)
- Changed PV (Martin / Khem)
- Removed FILES_PN (Khem)
Changes from v2:
- Changed PV (Martin)
--- .../chromium-utils/chromium-utils.bb | 24 ++++++++++++++++++++ .../files/0001-build-Add-HOST_LDFLAGS.patch | 26 ++++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 meta/recipes-devtools/chromium-utils/chromium-utils.bb create mode 100644 meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch
meta/recipes-devtools/chromium-utils/chromium-utils.bb new file +24 -0
@@ -0,0 +1,24 @@ +SUMMARY = "Chromium EC utilities" +DEPENDS = "libftdi" +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://LICENSE;md5=562c740877935f40b262db8af30bca36" + +SRCREV = "b19bb1f22a3fd0102030485d324c0321a18827e8" +SRC_URI = "git://chromium.googlesource.com/chromiumos/platform/ec;protocol=https \ + file://0001-build-Add-HOST_LDFLAGS.patch \ + " + +PV = "1.1.9999+gitr${SRCPV}" + +S = "${WORKDIR}/git" + +EXTRA_OEMAKE = "'HOSTCC=${CC}' 'HOSTCFLAGS=${CFLAGS}' 'HOST_LDFLAGS=${LDFLAGS}'" + +do_compile() { + oe_runmake utils +} + +do_install() { + install -m 0755 -d ${D}${bindir} + install -m 0755 ${S}/build/bds/util/ectool ${D}${bindir}/ectool +}
meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch new file +26 -0
@@ -0,0 +1,26 @@ +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001 +From: Moritz Fischer <[email protected]> +Date: Tue, 27 Dec 2016 22:24:07 -0800 +Subject: [PATCH] build Add HOST_LDFLAGS + +Signed-off-by: Moritz Fischer <[email protected]> +--- + Makefile.rules | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Makefile.rules b/Makefile.rules +index 404454d..0057ba9 100644 +--- a/Makefile.rules ++++ b/Makefile.rules +@@ -60,7 +60,7 @@ cmd_c_to_build = $(BUILDCC) $(BUILD_CFLAGS) \ + $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) $*.c) \ + $(BUILD_LDFLAGS) \ + -MMD -MF [email protected] -o $@ +-cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) -MMD -MF [email protected] -o $@ \ ++cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS) -MMD -MF [email protected] -o $@ \ + $(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) $*.c) + cmd_cxx_to_host = $(HOSTCXX) -std=c++0x $(COMMON_WARN) $(HOST_CXXFLAGS)\ + -I ./$($(notdir $@)_ROOT) -o $@ $(filter %.cc,$^) $($(notdir $@)_LIBS) +-- +2.4.11 +
Signature · 1 line
2.7.4
meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch line 5
Quoted 13 lines
(quoted diff) +1
-0+}meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch new file +5
-0@@ -0,0 +1,26 @@ +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001 +From: Moritz Fischer <[email protected]> +Date: Tue, 27 Dec 2016 22:24:07 -0800 +Subject: [PATCH] build Add HOST_LDFLAGS +
what is the Upstream Status of this patch? At least for oe-core, you need to provide it. More info at http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Quoted 4 lines
meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch new file +3
-0+Signed-off-by: Moritz Fischer <[email protected]> +--- + Makefile.rules | 2 +-
Leonardo,
Quoted 13 lines · Leonardo Sandoval
Quoted 13 lines
+}
diff --gita/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patchb/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patchnew file mode 100644
index 0000000..46e8cad
---/dev/null
+++b/meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patchmeta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch new file +2
-0@@ -0,0 +1,26 @@ +From 56ffeeffea735a6a8f69fc111278ebabe3c7e2d8 Mon Sep 17 00:00:00 2001 +From: Moritz Fischer <[email protected]>
Quoted 8 lines
meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch line 5
Quoted 3 lines
meta/recipes-devtools/chromium-utils/files/0001-build-Add-HOST_LDFLAGS.patch new file +3
-0+Date: Tue, 27 Dec 2016 22:24:07 -0800 +Subject: [PATCH] build Add HOST_LDFLAGS +what is the Upstream Status of this patch? At least for oe-core, you need to provide it. More info at
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Good catch, thanks. I submitted it upstream. I'll just wait for that to resubmit my v4 here, maybe by then I don't need the patch anymore then.
Moritz
Quoted 4 lines · Moritz Fischer
Good catch, thanks. I submitted it upstream. I'll just wait for that to resubmit my v4 here, maybe by then I don't need the patch anymore then.
Is there a good rationale to put this in oe-core, instead of a BSP layer or meta-oe? How widespread are boards that use this tool?
Ross
Quoted 10 lines · Ross
Quoted 4 lines · Moritz Fischer
Good catch, thanks. I submitted it upstream. I'll just wait for that to resubmit my v4 here, maybe by then I don't need the patch anymore then.
Is there a good rationale to put this in oe-core, instead of a BSP layer or meta-oe? How widespread are boards that use this tool?
it should be in meta-oe imo
Quoted 10 lines
Ross
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core