I2C-Blackfin TWI: Adjustments for i2c_bfin_twi_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 19:09:08 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determination

 drivers/i2c/busses/i2c-bfin-twi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

2.16.1

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 18:55:04 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

---
 drivers/i2c/busses/i2c-bfin-twi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

index ff3343186a82..ed596fd56b8b 100644
@@ -621,10 +621,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
 
 	iface = devm_kzalloc(&pdev->dev, sizeof(struct bfin_twi_iface),
 			GFP_KERNEL);
-	if (!iface) {
-		dev_err(&pdev->dev, "Cannot allocate memory\n");
+	if (!iface)
 		return -ENOMEM;
-	}
 
 	spin_lock_init(&(iface->lock));
 

2.16.1

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 19:01:14 +0100

Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

---
 drivers/i2c/busses/i2c-bfin-twi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

index ed596fd56b8b..f57e3247f717 100644
@@ -619,8 +619,7 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
 	int rc;
 	unsigned int clkhilow;
 
-	iface = devm_kzalloc(&pdev->dev, sizeof(struct bfin_twi_iface),
-			GFP_KERNEL);
+	iface = devm_kzalloc(&pdev->dev, sizeof(*iface), GFP_KERNEL);
 	if (!iface)
 		return -ENOMEM;
 

2.16.1