Skip to contentSkip to conversation

octeontx2-af: Remove unused rvu_npc_enable_bcast_entry

PATCH Applied [email protected] 3 participants 3 messages Apr 20, 2025 – Apr 23, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 octeontx2-af: Remove unused rvu_npc_enable_bcast_entry

From: "Dr. David Alan Gilbert" <[email protected]>

The last use of rvu_npc_enable_bcast_entry() was removed in 2021 by commit 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature")

Remove it.

---
 .../net/ethernet/marvell/octeontx2/af/rvu.h    |  2 --
 .../ethernet/marvell/octeontx2/af/rvu_npc.c    | 18 ------------------
 2 files changed, 20 deletions(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu.h +0 -2
index 60f085b00a8c..147d7f5c1fcc 100644
@@ -969,8 +969,6 @@ void rvu_npc_enable_promisc_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				  bool enable);
 void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
 				       int nixlf, u64 chan);
-void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
-				bool enable);
 void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				    u64 chan);
 void rvu_npc_enable_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +0 -18
index 821fe242f821..6296a3cdabbb 100644
@@ -820,24 +820,6 @@ void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
 	rvu_mbox_handler_npc_install_flow(rvu, &req, &rsp);
 }
 
-void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
-				bool enable)
-{
-	struct npc_mcam *mcam = &rvu->hw->mcam;
-	int blkaddr, index;
-
-	blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);
-	if (blkaddr < 0)
-		return;
-
-	/* Get 'pcifunc' of PF device */
-	pcifunc = pcifunc & ~RVU_PFVF_FUNC_MASK;
-
-	index = npc_get_nixlf_mcam_index(mcam, pcifunc, nixlf,
-					 NIXLF_BCAST_ENTRY);
-	npc_enable_mcam_entry(rvu, mcam, blkaddr, index, enable);
-}
-
 void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				    u64 chan)
 {
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On 4/20/2025 3:58 PM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The last use of rvu_npc_enable_bcast_entry() was removed in 2021 by commit 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature")

Remove it.

---

Quoted 22 lines
 .../net/ethernet/marvell/octeontx2/af/rvu.h    |  2 --
 .../ethernet/marvell/octeontx2/af/rvu_npc.c    | 18 ------------------
 2 files changed, 20 deletions(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu.h +0 -2
index 60f085b00a8c..147d7f5c1fcc 100644
@@ -969,8 +969,6 @@ void rvu_npc_enable_promisc_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				  bool enable);
 void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
 				       int nixlf, u64 chan);
-void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
-				bool enable);
 void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				    u64 chan);
 void rvu_npc_enable_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +0 -0
index 821fe242f821..6296a3cdabbb 100644

drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc, · line 825

Quoted 6 lines
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +0 -3
@@ -820,24 +820,6 @@ void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
 	rvu_mbox_handler_npc_install_flow(rvu, &req, &rsp);
 }
 
-void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
-				bool enable)
-{

Its a bit odd since that commit also updated the signature of this function adding the nixlf parameter, but indeed it didn't add any callers to the function.

Quoted 18 lines
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +0 -15
-	struct npc_mcam *mcam = &rvu->hw->mcam;
-	int blkaddr, index;
-
-	blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);
-	if (blkaddr < 0)
-		return;
-
-	/* Get 'pcifunc' of PF device */
-	pcifunc = pcifunc & ~RVU_PFVF_FUNC_MASK;
-
-	index = npc_get_nixlf_mcam_index(mcam, pcifunc, nixlf,
-					 NIXLF_BCAST_ENTRY);
-	npc_enable_mcam_entry(rvu, mcam, blkaddr, index, enable);
-}
-
 void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
 				    u64 chan)
 {
#2 lore raw
In reply to [email protected]
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Sun, 20 Apr 2025 23:58:10 +0100 you wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The last use of rvu_npc_enable_bcast_entry() was removed in 2021 by commit 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature")

Remove it.

[...]

Here is the summary with links:
- [net-next] octeontx2-af: Remove unused rvu_npc_enable_bcast_entry

    https://git.kernel.org/netdev/net-next/c/67b083f14fb7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html