Skip to contentSkip to conversation

drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

PATCH In review Thomas Zimmermann 2 participants 3 messages Jun 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem_prime_mmap(), is now the default for the operation, so there is no change in functionality.

Fixes 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
Cc Thomas Zimmermann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc "Pan, Xinhui" <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
index 43613569801b6..07e16ad465d06 100644
@@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
 	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
 	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
 	.gem_prime_import = amdgpu_gem_prime_import,
-	.gem_prime_mmap = drm_gem_prime_mmap,
 
 	.name = DRIVER_NAME,
 	.desc = DRIVER_DESC,
Signature · 1 line
2.41.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am 19.06.23 um 16:11 schrieb Thomas Zimmermann:

Quoted 5 lines

The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem_prime_mmap(), is now the default for the operation, so there is no change in functionality.

Quoted 8 lines
Fixes 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
Cc Thomas Zimmermann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc "Pan, Xinhui" <[email protected]>
Quoted 16 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
index 43613569801b6..07e16ad465d06 100644
@@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
  	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
  	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
  	.gem_prime_import = amdgpu_gem_prime_import,
-	.gem_prime_mmap = drm_gem_prime_mmap,
 
  	.name = DRIVER_NAME,
  	.desc = DRIVER_DESC,
#2 lore raw

Hi Christian

Am 19.06.23 um 16:13 schrieb Christian König:

Quoted 17 lines

Am 19.06.23 um 16:11 schrieb Thomas Zimmermann:

Quoted 5 lines

The callback struct drm_driver.gem_prime_mmap as been removed in commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap"). Do not assign to it. The assigned function, drm_gem_prime_mmap(), is now the default for the operation, so there is no change in functionality.

Quoted 8 lines
Fixes 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
Cc Thomas Zimmermann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc "Pan, Xinhui" <[email protected]>
Quoted 1 line

Thanks for the quick response. I'll add the patch to drm-misc-next immediately, to make the tree's amdgpu build again.

Best regards
Thomas

Quoted 17 lines
Quoted 16 lines

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -

  1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
index 43613569801b6..07e16ad465d06 100644
@@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
       .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
       .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
       .gem_prime_import = amdgpu_gem_prime_import,
-    .gem_prime_mmap = drm_gem_prime_mmap,
       .name = DRIVER_NAME,
       .desc = DRIVER_DESC,
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)