Skip to contentSkip to conversation

arm64: dts: xilinx: Drop undocumented "always-on" properties

PATCH In review Rob Herring (Arm) 4 participants 5 messages Aug 28, 2025 – Sep 4, 2025

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: xilinx: Drop undocumented "always-on" properties

The "always-on" properties are not documented for "silabs,si5341" binding nor used by the Linux driver, so drop them.

---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 8 --------
 arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 6 ------
 arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 6 ------
 3 files changed, 20 deletions(-)
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts +0 -8
index e172a30e7b21..6bee21d4fa4d 100644
@@ -552,42 +552,34 @@ si5341: clock-generator@36 { /* SI5341 - u69 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_4: out@4 {
 					/* refclk4 for PS-GT, used for PCIE slot */
 					reg = <4>;
-					always-on;
 				};
 				si5341_5: out@5 {
 					/* refclk5 for PS-GT, used for PCIE */
 					reg = <5>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_7: out@7 {
 					/* refclk7 PL CLK74 */
 					reg = <7>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 		};
arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts +0 -6
index cd132abf6e00..f450fad0edf8 100644
@@ -551,32 +551,26 @@ si5341: clock-generator@36 { /* SI5341 - u69 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_7: out@7 {
 					/* refclk7 PL CLK74 */
 					reg = <7>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 
arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts +0 -6
index 428b5558fbba..b4768f615182 100644
@@ -439,32 +439,26 @@ si5341: clock-generator@36 { /* SI5341 - u46 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_5: out@5 {
 					/* refclk5 PL CLK100 */
 					reg = <5>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 		};
Signature · 1 line
2.50.1
maintainer
#1 lore raw

Hi,

Quoted 2 lines · Rob Herring (Arm)

The "always-on" properties are not documented for "silabs,si5341" binding nor used by the Linux driver, so drop them.

Binding Documentation/devicetree/bindings/clock/silabs,si5341.txt doesn't contain it
but driver drivers/clk/clk-si5341.c is reading it.

1345 config[num].always_on =
1346 of_property_read_bool(child, "always-on");

It is there from 2019 when driver has been added.

If it is not standard clock property it should be moved to standard one. And DT binding should be converted to yaml with all properties used today.

Thanks,
Michal

#2 lore raw
Quoted 11 lines · Michal Simek

Hi,

Quoted 2 lines · Rob Herring (Arm)

The "always-on" properties are not documented for "silabs,si5341" binding nor used by the Linux driver, so drop them.

Binding Documentation/devicetree/bindings/clock/silabs,si5341.txt doesn't contain it
but driver drivers/clk/clk-si5341.c is reading it.

Quoted 6 lines

1345                 config[num].always_on =
1346                         of_property_read_bool(child, "always-on");

It is there from 2019 when driver has been added.

If it is not standard clock property it should be moved to standard one.

Agree - either "always-on" should become a standard property, or it should be removed from the driver.

As a standard property, akin to "regulator-always-on", maybe it should probably be renamed to "clock-always-on"?

I'd be happy to provide a patch either way.

Quoted 6 lines

And DT binding should be converted to yaml with all properties used today.

Thanks,
Michal

Mike.

#3 lore raw
Quoted 19 lines · Mike Looijmans
Quoted 11 lines · Michal Simek

Hi,

Quoted 2 lines · Rob Herring (Arm)

The "always-on" properties are not documented for "silabs,si5341" binding nor used by the Linux driver, so drop them.

Binding Documentation/devicetree/bindings/clock/silabs,si5341.txt doesn't contain it
but driver drivers/clk/clk-si5341.c is reading it.

Quoted 6 lines

1345                 config[num].always_on =
1346                         of_property_read_bool(child, "always-on");

It is there from 2019 when driver has been added.

If it is not standard clock property it should be moved to standard one.

Quoted 7 lines

Agree - either "always-on" should become a standard property, or it should be removed from the driver.

As a standard property, akin to "regulator-always-on", maybe it should probably be renamed to "clock-always-on"?

I'd be happy to provide a patch either way.

That's an implied ABI now, so you cannot remove it, but about "clock-always-on" - it does not look like a property we want in DT. If on one board this is always connected (but on other not), you should take the proper clock reference.

Quoted 1 line

Best regards,
Krzysztof

author maintainer
#4 lore raw
In reply to Michal Simek
Quoted 12 lines · Michal Simek

Hi,

Quoted 2 lines · Rob Herring (Arm)

The "always-on" properties are not documented for "silabs,si5341" binding nor used by the Linux driver, so drop them.

Binding Documentation/devicetree/bindings/clock/silabs,si5341.txt doesn't contain it
but driver drivers/clk/clk-si5341.c is reading it.

Quoted 4 lines

1345 config[num].always_on =
1346 of_property_read_bool(child, "always-on");

It is there from 2019 when driver has been added.

Sigh. I checked and missed that. We should just add it to the binding.

Rob