Skip to contentSkip to conversation

cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases

PATCH In review Bartlomiej Zolnierkiewicz 4 participants 6 messages Feb 20, 2015 – Mar 24, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases

Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()).

Cc Kukjin Kim <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Lukasz Majewski <[email protected]>
Fixes 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +2 -1
index 1b06fc4..f4df4af3 100644
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
 	tristate "SAMSUNG EXYNOS CPUfreq Driver"
 	depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-	depends on THERMAL
+	# if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+	depends on !CPU_THERMAL || THERMAL
 	help
 	  This adds the CPUFreq driver for Samsung EXYNOS platforms.
 	  Supported SoC versions are:
Signature · 1 line
1.8.2.3
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Bartlomiej Zolnierkiewicz

Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()).

Cc Kukjin Kim <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Lukasz Majewski <[email protected]>
Fixes 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +0 -0
index 1b06fc4..f4df4af3 100644

drivers/cpufreq/Kconfig.arm config ARM_VEXPRESS_SPC_CPUFREQ · line 35

Quoted 9 lines
drivers/cpufreq/Kconfig.arm +2 -1
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
        tristate "SAMSUNG EXYNOS CPUfreq Driver"
        depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-       depends on THERMAL
+       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+       depends on !CPU_THERMAL || THERMAL
        help
          This adds the CPUFreq driver for Samsung EXYNOS platforms.
          Supported SoC versions are:
#2 lore raw

Hi,

Quoted 18 lines · Viresh Kumar
Quoted 16 lines · Bartlomiej Zolnierkiewicz

Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()).

Cc Kukjin Kim <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Lukasz Majewski <[email protected]>
Fixes 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
drivers/cpufreq/Kconfig.arm +0 -0
index 1b06fc4..f4df4af3 100644

drivers/cpufreq/Kconfig.arm config ARM_VEXPRESS_SPC_CPUFREQ · line 35

Quoted 9 lines
drivers/cpufreq/Kconfig.arm +2 -1
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
        tristate "SAMSUNG EXYNOS CPUfreq Driver"
        depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-       depends on THERMAL
+       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+       depends on !CPU_THERMAL || THERMAL
        help
          This adds the CPUFreq driver for Samsung EXYNOS platforms.
          Supported SoC versions are:

Thank you for the ACK.

Would you pick this patch up or should I resend it to Rafael?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

maintainer
#3 lore raw
Quoted 1 line · Bartlomiej Zolnierkiewicz

Would you pick this patch up or should I resend it to Rafael?

Please resend it to Rafael and cc me and linux-pm list.. Also add my Ack to it.

Acked-by
#4 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 3 lines · Bartlomiej Zolnierkiewicz

Hi,

Hi,

Quoted 10 lines · Viresh Kumar
Quoted 9 lines
Quoted 7 lines · Bartlomiej Zolnierkiewicz

Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()).

Cc Kukjin Kim <[email protected]>

Looks OK to me,

Thanks,
Kukjin

Quoted 35 lines
Quoted 9 lines
Quoted 9 lines
Cc Arnd Bergmann <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Lukasz Majewski <[email protected]>
Fixes 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
drivers/cpufreq/Kconfig.arm +0 -0
index 1b06fc4..f4df4af3 100644

drivers/cpufreq/Kconfig.arm config ARM_VEXPRESS_SPC_CPUFREQ · line 35

Quoted 9 lines
drivers/cpufreq/Kconfig.arm +2 -1
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
        tristate "SAMSUNG EXYNOS CPUfreq Driver"
        depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-       depends on THERMAL
+       # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+       depends on !CPU_THERMAL || THERMAL
        help
          This adds the CPUFreq driver for Samsung EXYNOS platforms.
          Supported SoC versions are:

Thank you for the ACK.

Would you pick this patch up or should I resend it to Rafael?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Acked-by on v1 1/1
#5 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 6 lines · Bartlomiej Zolnierkiewicz

Allow driver build for !THERMAL or !CPU_THERMAL cases.

The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()).

Quoted 6 lines
Cc Kukjin Kim <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Lukasz Majewski <[email protected]>
Fixes 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
Quoted 22 lines
---
 drivers/cpufreq/Kconfig.arm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +2 -1
index 1b06fc4..f4df4af3 100644
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
 config ARM_EXYNOS_CPUFREQ
 	tristate "SAMSUNG EXYNOS CPUfreq Driver"
 	depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
-	depends on THERMAL
+	# if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+	depends on !CPU_THERMAL || THERMAL
 	help
 	  This adds the CPUFreq driver for Samsung EXYNOS platforms.
 	  Supported SoC versions are:
Signature · 1 line
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150324/1de02919/attachment-0001.sig>