Skip to contentSkip to conversation

checkpatch: fix false positive for REPEATED_WORD warning

PATCH In review Aditya Srivastava 3 participants 10 messages Oct 21, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: fix false positive for REPEATED_WORD warning

Presence of hexadecimal address or symbol results in false warning message by checkpatch.pl.

For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix memory leak in mptcp_subflow_create_socket()") results in warning:

WARNING:REPEATED_WORD: Possible repeated word: 'ff'

    00 00 00 00 00 00 00 00 00 2f 30 0a 81 88 ff ff  ........./0.....

Here, it reports 'ff' to be repeated, but it is infact part of some address or code, where it has to be repeated. Thus the warning seems unnecessary in this case.

To avoid all such reports, add an additional regex check for a repeating pattern of 4 or more 2-lettered words separated by space in a line.

---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +3 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
 
 				my $first = $1;
 				my $second = $2;
Signature · 6 lines
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
author
#1 lore raw
Quoted 27 lines · Aditya Srivastava

Presence of hexadecimal address or symbol results in false warning message by checkpatch.pl.

For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix memory leak in mptcp_subflow_create_socket()") results in warning:

WARNING:REPEATED_WORD: Possible repeated word: 'ff'

    00 00 00 00 00 00 00 00 00 2f 30 0a 81 88 ff ff  ........./0.....

Here, it reports 'ff' to be repeated, but it is infact part of some address or code, where it has to be repeated. Thus the warning seems unnecessary in this case.

To avoid all such reports, add an additional regex check for a repeating pattern of 4 or more 2-lettered words separated by space in a line.

---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +0 -0
index 9b9ffd876e8a..181c95691715 100755

scripts/checkpatch.pl sub process { · line 3060

Quoted 10 lines
scripts/checkpatch.pl +3 -1
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
 
 				my $first = $1;
 				my $second = $2;

Report of the impact of patch/changes(taken over v5.6..v5.8):

List of errors and warnings after applying the patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/summary.txt

Change in errors and warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/summary_relative.txt

Impact/Conclusion:
It can be seen that a large amount of warning messages under REPEATED_WORD were because of such hex occurrences.
The changes made reduces the warning count of REPEATED_WORD by more than 60%, ie. from 2797 to 1015 (over v5.6..v5.8)

Aditya
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#2 lore raw
Quoted 11 lines · Aditya
Quoted 10 lines · Aditya Srivastava

Presence of hexadecimal address or symbol results in false warning message by checkpatch.pl.

For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix memory leak in mptcp_subflow_create_socket()") results in warning:

WARNING:REPEATED_WORD: Possible repeated word: 'ff'

    00 00 00 00 00 00 00 00 00 2f 30 0a 81 88 ff ff  ........./0.....

Here, it reports 'ff' to be repeated, but it is infact part of some

Aditya:

s/infact/in fact/

Quoted 3 lines
Quoted 3 lines

address or code, where it has to be repeated. Thus the warning seems unnecessary in this case.

"unnecessary in this case" is a bit weak.
You can say it stronger:

In this case, the intent of the warning to find stylistic issues in commit messages is not met and the warning is just completely wrong in this case.

Quoted 31 lines
Quoted 14 lines

To avoid all such reports, add an additional regex check for a repeating pattern of 4 or more 2-lettered words separated by space in a line.

---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +0 -0
index 9b9ffd876e8a..181c95691715 100755

scripts/checkpatch.pl sub process { · line 3060

Quoted 10 lines
scripts/checkpatch.pl +3 -1
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
 
 				my $first = $1;
 				my $second = $2;

Report of the impact of patch/changes(taken over v5.6..v5.8):

List of errors and warnings after applying the patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/summary.txt

Quoted 9 lines

Change in errors and warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/summary_relative.txt

Impact/Conclusion:
It can be seen that a large amount of warning messages under REPEATED_WORD were because of such hex occurrences.
The changes made reduces the warning count of REPEATED_WORD by more than 60%, ie. from 2797 to 1015 (over v5.6..v5.8)

Aditya, so can you share a quick export of all the warnings that were dropped?
Just to check that all of them are hex stuff and we did not silence another class of valid REPEATED_WORD warnings?

Dwaipayan, can you review this patch and comment if you would have implemented that the same way or if you see other options that you have considered during your review?

Aditya, once you address my stylistic comments on the commit message and once you got feedback from Dwaipayan, you can send the patch to the checkpatch maintainers and lkml and please CC me, Dwaipayan and the linux-kernel-mentees list.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#3 lore raw

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

000 00 ff ff ...

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)
(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Lukas, I think with the changes in place, it is ready to go for discussion.

Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

author
#4 lore raw
Quoted 38 lines · Dwaipayan Ray

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

000 00 ff ff ...

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
(quoted diff) +2 -1
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)

(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

Quoted 8 lines

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Lukas, I think with the changes in place, it is ready to go for discussion.

Thanks,
Dwaipayan.

Thanks Dwaipayan. You're correct.
I'll use \b for checking the word boundaries and regenerate the reports. I used 4 as the minimum as there were some occurrences with 4 hex words, For eg,
WARNING:REPEATED_WORD: Possible repeated word: 'ff'
#15:
d68: 61 29 ff ff ori r9,r9,65535

for the commit 332ce969b763 ("powerpc/8xx: Reduce time spent in allow_user_access() and friends")

In addition to your changes, I also plan to modify regex with [0-9a-f] (instead of a-z).
I'll apply all the changes and send the report, along with the removed warnings again.

Thanks
Aditya
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#5 lore raw
In reply to Dwaipayan Ray
Quoted 17 lines · Dwaipayan Ray

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

Quoted 2 lines

000 00 ff ff ...

I am wondering if this pattern really appears.

Hex stuff is usually written two-letter and spaces.

Maybe it is best to limit it to 0-9a-f, though. I think there should not be matches with other letters than that.

Aditya, evaluations on those alternatives would help to make decisions.

Quoted 19 lines

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
(quoted diff) +2 -1
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)

(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

Quoted 5 lines

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Lukas, I think with the changes in place, it is ready to go for discussion.

Dwaipayan, thanks for your review.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

author
#6 lore raw
Quoted 55 lines · Lukas Bulwahn
Quoted 17 lines · Dwaipayan Ray

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

Quoted 2 lines

000 00 ff ff ...

I am wondering if this pattern really appears.

Hex stuff is usually written two-letter and spaces.

Maybe it is best to limit it to 0-9a-f, though. I think there should not be matches with other letters than that.

Aditya, evaluations on those alternatives would help to make decisions.

Quoted 22 lines

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
(quoted diff) +2 -1
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)

(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Quoted 7 lines
Quoted 2 lines

Lukas, I think with the changes in place, it is ready to go for discussion.

Dwaipayan, thanks for your review.

Lukas

Hi Sir
I made these changes:

 # check for repeated words separated by a single space
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /(\b[0-9a-f]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {

my $first = $1;
my $second = $2;

Reports:
List of errors and warnings after applying the patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/summary.txt

Change in errors and warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/summary_relative.txt

Dropped warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/dropped_warnings/summary.txt

Thanks
Aditya
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

author
#7 lore raw
Quoted 82 lines · Aditya
Quoted 55 lines · Lukas Bulwahn
Quoted 17 lines · Dwaipayan Ray

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

Quoted 2 lines

000 00 ff ff ...

I am wondering if this pattern really appears.

Hex stuff is usually written two-letter and spaces.

Maybe it is best to limit it to 0-9a-f, though. I think there should not be matches with other letters than that.

Aditya, evaluations on those alternatives would help to make decisions.

Quoted 22 lines

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
(quoted diff) +2 -1
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)

(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Quoted 7 lines
Quoted 2 lines

Lukas, I think with the changes in place, it is ready to go for discussion.

Dwaipayan, thanks for your review.

Lukas

Hi Sir
I made these changes:

 # check for repeated words separated by a single space
scripts/checkpatch.pl +3 -1
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /(\b[0-9a-f]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
 
 				my $first = $1;
 				my $second = $2;

Reports:
List of errors and warnings after applying the patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/summary.txt

Quoted 9 lines

Change in errors and warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/summary_relative.txt

Dropped warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/dropped_warnings/summary.txt

Thanks
Aditya

I have also generated report to find the missing warnings from both versions of my patches. Here is the report:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/dropped_warnings/patch_revision_summary.txt

Thank You
Aditya
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#8 lore raw
In reply to Aditya
Quoted 82 lines · Aditya
Quoted 55 lines · Lukas Bulwahn
Quoted 17 lines · Dwaipayan Ray

Hey Aditya and Lukas,

Quoted 11 lines
Quoted 11 lines

scripts/checkpatch.pl sub process { · line 3056

Quoted 11 lines
scripts/checkpatch.pl +2 -1
index 9b9ffd876e8a..181c95691715 100755
@@ -3052,7 +3052,9 @@ sub process {
 
 # check for repeated words separated by a single space
            if ($rawline =~ /^\+/ || $in_commit_log) {
-                   while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                   # avoid repeating hex occurrences like 'ff ff fe 09 ...'
+                   while ($rawline !~ /((\s)*[0-9a-z]{2}( )+){4,}/ &&

Pattern is probably wrong. It doesn't recognize word boundaries or tabs between words. Example of the first type:

Quoted 2 lines

000 00 ff ff ...

I am wondering if this pattern really appears.

Hex stuff is usually written two-letter and spaces.

Maybe it is best to limit it to 0-9a-f, though. I think there should not be matches with other letters than that.

Aditya, evaluations on those alternatives would help to make decisions.

Quoted 22 lines

The regex matches "00 00 ff ff" ignoring the first 0.

I think it could be perhaps better with something like:

 # check for repeated words separated by a single space
(quoted diff) +2 -1
-               if ($rawline =~ /^\+/ || $in_commit_log) {
+               if (($rawline =~ /^\+/ || $in_commit_log) &&
+                   $rawline !~ /(?:\b(?:[0-9a-f]{2}\s+){4,})/) {
                        pos($rawline) = 1 if (!$in_commit_log);
                        while ($rawline =~ /\b($word_pattern)

(?=($word_pattern))/g) {

Please test it though. I only ran it on a few patterns.

Apart from it, this does fix the problem. But I am quite sceptical about matching 4 or more 2 lettered words in a row. There could be counter examples but I guess that is very rare. It's not very general, but for the moment it does the job.

So I think it's probably good with some changes. Not sure what Joe would have in mind though.

Quoted 7 lines
Quoted 2 lines

Lukas, I think with the changes in place, it is ready to go for discussion.

Dwaipayan, thanks for your review.

Lukas

Hi Sir
I made these changes:

 # check for repeated words separated by a single space
scripts/checkpatch.pl +3 -1
 		if ($rawline =~ /^\+/ || $in_commit_log) {
-			while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+			# avoid repeating hex occurrences like 'ff ff fe 09 ...'
+			while ($rawline !~ /(\b[0-9a-f]{2}( )+){4,}/ &&
+				$rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
 
 				my $first = $1;
 				my $second = $2;

Reports:
List of errors and warnings after applying the patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/summary.txt

Quoted 6 lines

Change in errors and warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/summary_relative.txt

Dropped warnings compared to previous patch:
https://github.com/AdityaSrivast/kernel-tasks/blob/master/Task3/relative_summary/dropped_warnings/summary.txt

Looks good.

I suggest you quickly scan through the dropped warnings and confirm, so that you can add something like this to your commit message:

---
A quick evaluation on <git commit range, fill in here> showed that this change reduces REPEATED_WORD warnings from xxx to yyy.

A quick manual check found all cases are related to hex output in commit messages.

---

Then send out the patch again here quickly and if we do not see big mistake, send it our to lkml and Joe Perches.

If you need any help, just let us know.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#9 lore raw
In reply to Aditya

scripts/checkpatch.pl sub process { · line 3055

Quoted 4 lines
 # check for repeated words separated by a single space
                if ($rawline =~ /^\+/ || $in_commit_log) {
scripts/checkpatch.pl +1 -1
-                       while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
+                       # avoid repeating hex occurrences like 'ff ff fe 09 ...'

Hey,
Probably one more change you could do here:

Review

Quoted 2 lines
(quoted diff) +2 -0
+                       while ($rawline !~ /(\b[0-9a-f]{2}( )+){4,}/ &&
+                               $rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {

The hex check is performed everytime a duplicate word is found in the line. A line with multiple duplicate words will lead to unnecessary re run of the hex check.

Example:

"This is is the the repeated word"
Two repeated words: 'is' and 'the', and two runs
of the hex check on the same line.

Probably move it here?
+ if (($rawline =~ /^\+/ || $in_commit_log) &&
+ $rawline !~ /(\b[0-9a-f]{2}( )+){4,}/) {

Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees