Skip to contentSkip to conversation

sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'

PATCH In review [email protected] 2 participants 2 messages Jul 9, 2023 – Oct 18, 2023 1 message not in the archive SuperH

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'

Fix the following warnings reported by checkpatch:

arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 arch/sh/drivers/heartbeat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/sh/drivers/heartbeat.c +2 -2
index 24391b444b28..07f04ed0d517 100644
@@ -30,7 +30,7 @@
 static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };
 
 static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
-                    unsigned bit, unsigned int inverted)
+                    unsigned int bit, unsigned int inverted)
 {
     unsigned int new;
 
@@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
 static void heartbeat_timer(struct timer_list *t)
 {
     struct heartbeat_data *hd = from_timer(hd, t, timer);
-    static unsigned bit = 0, up = 1;
+    static unsigned int bit = 0, up = 1;
 
     heartbeat_toggle_bit(hd, bit, hd->flags & HEARTBEAT_INVERTED);
#2 lore raw
Quoted 26 lines · On Sun, Jul 9, 2023 at 2:39 PM <[email protected]> wrote:

Fix the following warnings reported by checkpatch:

arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
  arch/sh/drivers/heartbeat.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/sh/drivers/heartbeat.c +1 -1
index 24391b444b28..07f04ed0d517 100644
@@ -30,7 +30,7 @@
  static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };
 
  static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
-                    unsigned bit, unsigned int inverted)
+                    unsigned int bit, unsigned int inverted)
  {
      unsigned int new;
 

arch/sh/drivers/heartbeat.c static inline void heartbeat_toggle_bit(struct · line 59

Quoted 1 line
arch/sh/drivers/heartbeat.c +0 -0
@@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct
 heartbeat_data *hd,

patch: **** malformed patch at line 19: heartbeat_data *hd,

Please fix your email setup.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds