Skip to contentSkip to conversation

Depreciate PATCH support for HostName at NetworkProtocol

DISCUSSION Gunnar Mills 2 participants 2 messages Dec 14, 2020 – Dec 15, 2020

lore
Share & tools
lore
#0 lore raw

Hi Ravi,

I believe you implemented PATCH support for HostName at /redfish/v1/Managers/bmc/NetworkProtocol

https://github.com/openbmc/bmcweb/commit/501be32b4230dfa2730467985c6306f15fe7af61

Looking for some background around the commit. Do you know why this was added? Do you know if any clients are PATCHing HostName here?

HostName at /redfish/v1/Managers/bmc/NetworkProtocol is a read-only property and PATCH support here violates the Redfish spec.

HostName at /redfish/v1/Managers/bmc/EthernetInterfaces/<str> is a read-write property and can be PATCHed. This is what webui-vue uses.

Still discussion on how we would depreciate this PATCH support on
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/38475

Does anyone know of a client PATCHing HostName at the NetworkProtocol resource?

https://redfish.dmtf.org/schemas/v1/ManagerNetworkProtocol.v1_6_1.json
https://redfish.dmtf.org/schemas/v1/EthernetInterface.v1_6_2.json

Thanks,
Gunnar

#1 lore raw

Hi Gunnar

yes. there was an issue opened for the same
https://github.com/openbmc/bmcweb/issues/44
I remember adding patch support to fix this issue.. I think we had discussed about hostname property in
ethernet vs network protocol , it has been long back don't remember exactly.

Thanks
Raviteja

Quoted 30 lines · Gunnar Mills

Hi Ravi,

I believe you implemented PATCH support for HostName at /redfish/v1/Managers/bmc/NetworkProtocol

https://github.com/openbmc/bmcweb/commit/501be32b4230dfa2730467985c6306f15fe7af61

Looking for some background around the commit. Do you know why this was added? Do you know if any clients are PATCHing HostName here?

HostName at /redfish/v1/Managers/bmc/NetworkProtocol is a read-only property and PATCH support here violates the Redfish spec.

HostName at /redfish/v1/Managers/bmc/EthernetInterfaces/<str> is a read-write property and can be PATCHed. This is what webui-vue uses.

Still discussion on how we would depreciate this PATCH support on
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/38475

Does anyone know of a client PATCHing HostName at the NetworkProtocol resource?

https://redfish.dmtf.org/schemas/v1/ManagerNetworkProtocol.v1_6_1.json
https://redfish.dmtf.org/schemas/v1/EthernetInterface.v1_6_2.json

Thanks,
Gunnar